TRY to not escape mysql pass by go-sql-driver/mysql lib

illacloud · Feb 5, 2024 · f235636 · f235636
1 parent df3c745
commit f235636
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/actionruntime/mysql/base.go b/src/actionruntime/mysql/base.go
@@ -21,7 +21,6 @@ import (
 	"encoding/pem"
 	"errors"
 	"fmt"
-	"net/url"
 
 	"github.com/go-sql-driver/mysql"
 	_ "github.com/go-sql-driver/mysql"
@@ -48,9 +47,9 @@ func (m *MySQLConnector) getConnectionWithOptions(resourceOptions map[string]int
 }
 
 func (m *MySQLConnector) connectPure() (db *sql.DB, err error) {
-	escapedPassword := url.QueryEscape(m.Resource.DatabasePassword)
+	// escapedPassword := url.QueryEscape(m.Resource.DatabasePassword)
 	dsn := fmt.Sprintf("%s:%s@tcp(%s:%s)/%s", m.Resource.DatabaseUsername,
-		escapedPassword, m.Resource.Host, m.Resource.Port, m.Resource.DatabaseName)
+		m.Resource.DatabasePassword, m.Resource.Host, m.Resource.Port, m.Resource.DatabaseName)
 	db, err = sql.Open("mysql", dsn+"?timeout=30s")
 	if err != nil {
 		return nil, err
@@ -59,9 +58,9 @@ func (m *MySQLConnector) connectPure() (db *sql.DB, err error) {
 }
 
 func (m *MySQLConnector) connectViaSSL() (db *sql.DB, err error) {
-	escapedPassword := url.QueryEscape(m.Resource.DatabasePassword)
+	// escapedPassword := url.QueryEscape(m.Resource.DatabasePassword)
 	dsn := fmt.Sprintf("%s:%s@tcp(%s:%s)/%s", m.Resource.DatabaseUsername,
-		escapedPassword, m.Resource.Host, m.Resource.Port, m.Resource.DatabaseName)
+		m.Resource.DatabasePassword, m.Resource.Host, m.Resource.Port, m.Resource.DatabaseName)
 	pool := x509.NewCertPool()
 	if ok := pool.AppendCertsFromPEM([]byte(m.Resource.SSL.ServerCert)); !ok {
 		return nil, errors.New("MySQL SSL/TLS Connection failed")