Skip to content

Commit 243205a

Browse files
Shnatselkornelski
authored andcommitted
Drop the bpp=4 std::simd codepath, it is not beneficial on Linux and may regress performance on Windows
1 parent c839711 commit 243205a

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/filter.rs

+3-5
Original file line numberDiff line numberDiff line change
@@ -804,11 +804,9 @@ pub(crate) fn unfilter(
804804
}
805805
}
806806
BytesPerPixel::Four => {
807-
#[cfg(all(feature = "unstable", target_arch = "x86_64"))]
808-
{
809-
simd::unfilter_paeth_u8::<4>(previous, current);
810-
return;
811-
}
807+
// Using the `simd` module here has no effect on Linux
808+
// and appears to regress performance on Windows, so we don't use it here.
809+
// See https://github.com/image-rs/image-png/issues/567
812810

813811
let mut a_bpp = [0; 4];
814812
let mut c_bpp = [0; 4];

0 commit comments

Comments
 (0)