Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: imageops:: and DynImage::crop()/crop_imm() breakage #1201

Open
nabijaczleweli opened this issue Apr 17, 2020 · 2 comments
Open

Tracking: imageops:: and DynImage::crop()/crop_imm() breakage #1201

nabijaczleweli opened this issue Apr 17, 2020 · 2 comments
Labels
kind: API missing or awkward public APIs kind: enhancement next: breaking Information tag for PRs and ideas that require an interface break

Comments

@nabijaczleweli
Copy link
Member

Previously: #1200 (comment)

  1. imageops::crop() is to be renamed to crop_mut(), and imageops::crop_imm() to crop()
  2. DynImage::crop()'s signature is to be replaced with crop_imm()'s, and crop_imm() removed
@HeroicKatora HeroicKatora added the next: breaking Information tag for PRs and ideas that require an interface break label Oct 10, 2020
@HeroicKatora HeroicKatora mentioned this issue Feb 13, 2021
22 tasks
@RReverser
Copy link
Contributor

RReverser commented Sep 10, 2023

Just noticed that docs of DynamicImage::crop says the signature will be replaced in 0.24 release, but looks like that never happened even though 0.24 was released some time ago? Should the docs be updated? @HeroicKatora

@fintelia
Copy link
Contributor

Yeah, probably should update the docs. Though if anyone is interested in making a PR, we can make note of it in #1943 to make sure they don't get forgotten when we are making the 0.25 release

@Shnatsel Shnatsel added the kind: API missing or awkward public APIs label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: API missing or awkward public APIs kind: enhancement next: breaking Information tag for PRs and ideas that require an interface break
Projects
None yet
Development

No branches or pull requests

5 participants