Add mvcp server methods to mvcp driver

[jmrunge]

Now only unit methods are implemented. We should implement all methods defined in MVCP protocol.

[Lacrymology]

I wonder why things like "appendClip" are in drivers/mvcp/ and not in melted-node. What's the point of melted-node exactly, if it doesn't have knowledge of the mvcp protocol?

@xaiki ping

[jmrunge]

For me, melted node is a transport between melted and mosto. Its only
responsibility is to make sure it is connected to melted (or give notice of
the opposite) and feed it with commands, sending then the responses to the
client. Sure it could implement the complete mvcp protocol, but I would
prefer to keep it the way it is, I think is cleaner. Its my opinion.

2013/9/17 Tomas Neme [email protected]

I wonder why things like "appendClip" are in drivers/mvcp/ and not in
melted-node. What's the point of melted-node exactly, if it doesn't have
knowledge of the mvcp protocol?

@xaiki https://github.com/xaiki ping

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/61#issuecomment-24619238
.

[Lacrymology]

The problem I see right now is with responsibility separation.

Right now melted-node knows how to parse MVCP responses, but doesn't know
MVCP commands, and doesn't even have an expectancy table of which responses
should what commands return.

What I think is that mvcp driver should convert Media objects to XML, and
cover only the subset of MVCP commands that mosto uses. Melted-node should
handle all commands in a coherent manner.

I don't feel strongly about this, in any case, but I wonder about the
validity of this issue. Why should mvcp driver implement commands that are
not used in mosto?

[jmrunge]

Well, as talked on the chat, we will maintain this issue opened as a
reminder of moving mvcp driver methods (apnd, load, move, etc) to melted
node and let mvcp driver just implement methods needed by mosto.

2013/9/18 Tomas Neme [email protected]

The problem I see right now is with responsibility separation.

Right now melted-node knows how to parse MVCP responses, but doesn't know
MVCP commands, and doesn't even have an expectancy table of which responses
should what commands return.

What I think is that mvcp driver should convert Media objects to XML, and
cover only the subset of MVCP commands that mosto uses. Melted-node should
handle all commands in a coherent manner.

I don't feel strongly about this, in any case, but I wonder about the
validity of this issue. Why should mvcp driver implement commands that are
not used in mosto?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/61#issuecomment-24669455
.