Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor old components #23

Open
11 tasks
simenandre opened this issue Nov 16, 2021 · 2 comments
Open
11 tasks

Refactor old components #23

simenandre opened this issue Nov 16, 2021 · 2 comments

Comments

@simenandre
Copy link
Member

simenandre commented Nov 16, 2021

In src/components we've got a bunch of components that are inherited from the app. None of them was implemented as native Theme UI components, which I think we should change. We should also consider deprecating those we don't need/shouldn't use.

Tasks

  • Refactor ActionBoxItem
  • Refactor Alert
  • Refactor Editor
  • Refactor FieldImage
  • Refactor LabeledButton
  • Refactor Modal
  • Refactor SelectAlt
  • Refactor SelectOption
  • Refactor Select
  • Refactor TagField
  • Refactor TagSelect

What is Native Theme UI Components?

Components built using the special __css and __themeKey arguments and in a theme-agnostic way. When building components, only

@braaar
Copy link
Contributor

braaar commented Nov 16, 2021

LabeledButton is deprecated

@simenandre
Copy link
Member Author

We should consider refactoring the components so they are reusable in any context or layout. The components should not affect anything outside itself. Like, margins shouldn't be used to increase useability on these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants