Add state null checks in history #2232
Open
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSpeekenbrink
changed the title
window.history.state null checks in history
RSpeekenbrink
changed the title
window.history.state null checks in history
|
👍 waiting for this, since this is blocking inertia/nova upgrades in our project. |
|
@reinink is inertiaJS development suspended until further notice about the Laravel takeover? Would be nice to get some info about what's going on ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching from a non-inertia handled page to an inertia page in the same application the state object is not set. Thereby the getScrollRegions() and getDocumentScrollPosition() getters would generate the following error;
This is fixed by adding null checks for history state.
Same goes for
saveScrollPositionswhen the page object on state does not exist.Fixes #2204