Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting clock oscillator compensation factor causes cannot schedule message to the past #845

Open
levy opened this issue Jan 3, 2023 · 1 comment
Assignees
Labels
Milestone

Comments

@levy
Copy link
Contributor

levy commented Jan 3, 2023

The OscillatorBasedClock::scheduleClockEventAt and OscillatorBasedClock::scheduleClockEventAfter functions calculate with the raw simtime values. If the raw value is 1E-12 then the calculation results in a zero and causes problems with message scheduling. These functions should use double arithmetic and include the oscillator compensation factor in the calculation.

@levy levy self-assigned this Jan 3, 2023
@levy levy added the Bug label Jan 3, 2023
@adamgeorge309
Copy link
Contributor

For reproduction:

omnetpp: omnetpp-6.0.x branch (ec0c7f3cf3cb0a0c31029f10947645c9f5b14c11)
inet: 7656138

showcases/tsn/timesychronization/clockdrift, OutOfBandSynchronizationConstantDrift config
also add to config:
*.source*.app[1].synchronizationOscillatorCompensationFactorError = uniform(0.5, 2) (this is needed for the error)

@levy levy added this to the INET 4.5 milestone Feb 20, 2023
@levy levy modified the milestones: INET 4.5, Postponed Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants