Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize big integers in ITF traces as an object #1165

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Serialize big integers in ITF traces as an object #1165

merged 4 commits into from
Sep 14, 2023

Conversation

konnov
Copy link
Contributor

@konnov konnov commented Sep 14, 2023

This PR update the ITF trace format, according to the change made in Apalache, see apalache-mc/apalache#2733. As a result, the ITF writer always writes integers in the format { '#bigint': 'num' }. We still parse JS numbers for backwards compatibility.

Copy link
Collaborator

@bugarela bugarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@konnov konnov enabled auto-merge (squash) September 14, 2023 11:51
@konnov konnov merged commit 5e1843b into main Sep 14, 2023
15 checks passed
@konnov konnov deleted the igor/itf2732 branch September 14, 2023 12:01
@bugarela bugarela mentioned this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants