Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching is not working #61

Closed
eiffel-fl opened this issue Aug 7, 2024 · 2 comments · Fixed by #74 · May be fixed by #94
Closed

Searching is not working #61

eiffel-fl opened this issue Aug 7, 2024 · 2 comments · Fixed by #74 · May be fixed by #94

Comments

@eiffel-fl
Copy link
Member 

          Hi!

I really like the new look and feel of the website.

Nonetheless, I am not sure to understand why you needed to modify docs-fetcher.py.
Moreover, I tried to search on the website and the search field display "Loading...":
image
I tried on both Firefox and Chromium and got the same result, is this expected because the site is in "preview mode"?

Best regards.

Originally posted by @eiffel-fl in #53 (review)
Closed
@sniok sniok mentioned this issue Aug 21, 2024
Merged
@andoriyaprashant
Copy link
Contributor

Hello @eiffel-fl @mauriciovasquezbernal
I’d like to suggest enhancing our website's search feature by integrating Algolia, which would provide a more robust and efficient search experience. If this approach works for you, could you please assign me this issue

Thank you

@eiffel-fl
Copy link
Member Author

Hi!

Hello @eiffel-fl @mauriciovasquezbernal I’d like to suggest enhancing our website's search feature by integrating Algolia, which would provide a more robust and efficient search experience. If this approach works for you, could you please assign me this issue

Algolia seems indeed very powerful but it is proprietary and I would rather stick with simple and open source tool.
If you know some open source search plugin, feel free to recommend them here.

Thank you

Best regards.

flyth added a commit that referenced this issue Sep 11, 2024
@flyth
staticwebapp config: allow unsafe-eval and unsafe-inline in CSP
2a3bd0b 
Currently the website complains that both unsafe-eval and unsafe-inline are not allowed by
the Content Security Policy. However, it seems that the former is required for the search
feature and the latter to be able to store the theme selection. The theme selection could
be imported differently to prevent the need for unsafe-inline, but for the time being this
should solve both issues.

Fixes #61
@flyth flyth mentioned this issue Sep 11, 2024
Open
flyth added a commit that referenced this issue Sep 13, 2024
@flyth
staticwebapp config: add back CSP and allow unsafe-eval and unsafe-in…
0abf831 
…line

This adds the CSP back and also adds unsafe-eval and unsafe-inline which are
needed for the search functionality and theme settings.

Fixes #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eiffel-fl @andoriyaprashant