Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle non-existent fields in reports #5

Open
matiasgarciaisaia opened this issue Jan 22, 2015 · 1 comment
Open

Better handle non-existent fields in reports #5

matiasgarciaisaia opened this issue Jan 22, 2015 · 1 comment

Comments

@matiasgarciaisaia
Copy link
Member

If a field used in any report gets renamed or disappears from the schema, NNDD crashes with a JavaScript error and one can't even delete that report.

A little error handling would be nice for being able to at least delete the report or show the content that don't needs that field.

screen shot 2015-01-22 at 4 19 57 pm

angular.js:10126 TypeError: Cannot read property 'type' of undefined
    at Object.service.deserialize (http://localhost:9000/scripts/services/filters_service.js:13:40)
    at http://localhost:9000/scripts/services/local_reports_service.js:94:33
    at Function.map (http://localhost:9000/bower_components/lodash/dist/lodash.compat.js:3856:27)
    at Object.service.deserialize (http://localhost:9000/scripts/services/local_reports_service.js:93:26)
    at http://localhost:9000/scripts/controllers/report_ctrl.js:72:33
    at deferred.promise.then.wrappedCallback (http://localhost:9000/bower_components/angular/angular.js:11682:81)
    at http://localhost:9000/bower_components/angular/angular.js:11768:26
    at Scope.$get.Scope.$eval (http://localhost:9000/bower_components/angular/angular.js:12811:28)
    at Scope.$get.Scope.$digest (http://localhost:9000/bower_components/angular/angular.js:12623:31)
    at Scope.$get.Scope.$apply (http://localhost:9000/bower_components/angular/angular.js:12915:24)angular.js:10126 (anonymous function)angular.js:7398 $getangular.js:11685 deferred.promise.then.wrappedCallbackangular.js:11768 (anonymous function)angular.js:12811 $get.Scope.$evalangular.js:12623 $get.Scope.$digestangular.js:12915 $get.Scope.$applyangular.js:8450 doneangular.js:8664 completeRequestangular.js:8603 xhr.onreadystatechange
@macoca
Copy link
Contributor

macoca commented Feb 18, 2016

Marked as minor as it only happens when changing the schema between versions, and it can be bypassed by the user by deleting the cookies in the browser.

@macoca macoca removed this from the CDX Release 0.10 milestone Mar 7, 2016
@macoca macoca removed the ready label Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants