Use GEMINI_JSON as default #1286
Open
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 25045ab in 16 seconds
More details
- Looked at
58lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. instructor/client_gemini.py:14
- Draft comment:
The default mode has been changed fromGEMINI_TOOLStoGEMINI_JSON. Ensure that this change is communicated to users, as it may affect existing implementations relying on the previous default. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the default mode from GEMINI_TOOLS to GEMINI_JSON in the from_gemini function. This change is consistent across all overloads and the main function definition. The change aligns with the PR's intent to make GEMINI_JSON the default mode due to its better performance in chain-of-thought reasoning tasks, as described in the issue.
2. docs/concepts/patching.md:38
- Draft comment:
The addition of the warning about field order not being preserved in Gemini tool calling is a good update. It informs users about potential issues with relying on field order in responses. - Reason this comment was not posted:
Confidence changes required:0%
The documentation update in patching.md correctly reflects the change in default mode to GEMINI_JSON. This aligns with the PR's intent and provides users with a warning about the key ordering issue.
3. docs/concepts/patching.md:38
- Draft comment:
The code example should be updated to reflect the new default modeinstructor.Mode.GEMINI_JSON.
genai.GenerativeModel(), mode=instructor.Mode.GEMINI_JSON
- Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_Cl8dA1hv0bkdHYhB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes GEMINI_JSON default, and warns users about key ordering issue.
Fixes #1285.
Important
Change default mode to
GEMINI_JSONinfrom_gemini()and update documentation for field order warning.GEMINI_JSONinfrom_gemini()ininstructor/client_gemini.py.docs/concepts/patching.md.docs/concepts/patching.md.This description was created by
for 25045ab. It will automatically update as commits are pushed.