Implement common argument parsing with argparse #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligned with convention used elsewhere, where "argv" is a list[str] representing the command-line arguments, and "args" is the result of parsing the contents of argv. Signed-off-by: John Pennycook <[email protected]>
Instead of writing multiple functions to handle the parsing of -D, -I and -include arguments, we can construct a simple ArgumentParser. In addition to being more robust, it should be easier to extent with support for additional arguments in the future. Signed-off-by: John Pennycook <[email protected]>
Test handling of -D, -I, -isystem, and -include options. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
_parse_compiler_args was configured to ignore the first argument, assuming that it would be the name of the compiler binary. Everything worked properly for options lists captured from real commands, but the first argument was being incorrectly stripped from generated from user-provided options strings. Signed-off-by: John Pennycook <[email protected]>
7 tasks
laserkelvin
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
-D,-I,-isystem,-includeand user-defined options handling.Proposed changes
extract_defines,extract_include_pathsandextract_includeswith a simplerargparse-based solution.argstoargvto help distinguish between command-line arguments and the result ofparse_args()._parse_compiler_args. Theextract_*functions were never tested directly, only ever via other tests.