fix: test_source_osv.py #4633

Author: Saksham-Sirohi

test/test_source_osv.py

@@ -1,7 +1,6 @@
 # Copyright (C) 2022 Intel Corporation
 # SPDX-License-Identifier: GPL-3.0-or-later
 
-
 import io
 import shutil
 import tempfile
@@ -173,17 +172,26 @@ async def test_update_ecosystems(self):
         ecosystems_txt = make_http_requests(
             "text", url=self.ecosystems_url, timeout=300
         ).strip("\n")
-        expected_ecosystems = set(ecosystems_txt.split("\n"))
-
-        # Because ecosystems.txt does not contain the complete list, this must be
-        # manually fixed up.
-        expected_ecosystems.add("DWF")
-        expected_ecosystems.add("JavaScript")
-
-        # Assert that there are no missing ecosystems
-        assert all(x in self.osv.ecosystems for x in expected_ecosystems)
-        # Assert that there are no extra ecosystems
-        assert all(x in expected_ecosystems for x in self.osv.ecosystems)
+        expected_top_level = set(ecosystems_txt.split("\n"))
+        expected_top_level.discard("[EMPTY]")  # Remove invalid entry
+        expected_top_level.update({"DWF", "JavaScript"})  # Manual additions
+
+        # Inline parent ecosystem extraction
+        code_parent_ecosystems = {
+            ecosystem.split(":")[0] for ecosystem in self.osv.ecosystems
+        }
+
+        # Validate ecosystem consistency
+        missing_parents = expected_top_level - code_parent_ecosystems
+        extra_parents = code_parent_ecosystems - expected_top_level
+
+        error_msg = []
+        if missing_parents:
+            error_msg.append(f"Missing parent ecosystems: {missing_parents}")
+        if extra_parents:
+            error_msg.append(f"Unexpected parent ecosystems: {extra_parents}")
+        if error_msg:
+            pytest.fail("\n".join(error_msg))
 
     @pytest.mark.asyncio
     @pytest.mark.skipif(not EXTERNAL_SYSTEM(), reason="Needs network connection.")