Skip to content

Commit 539d96b

Browse files
vsemenov368jsji
authored andcommitted
Remove SPV_INTEL_fast_composite extension (#3183)
Original commit: KhronosGroup/SPIRV-LLVM-Translator@e23610c8a9e9533
1 parent ee718b7 commit 539d96b

File tree

11 files changed

+1
-101
lines changed

11 files changed

+1
-101
lines changed

llvm-spirv/include/LLVMSPIRVExtensions.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ EXT(SPV_INTEL_arbitrary_precision_integers)
3535
EXT(SPV_INTEL_optimization_hints)
3636
EXT(SPV_INTEL_float_controls2)
3737
EXT(SPV_INTEL_vector_compute)
38-
EXT(SPV_INTEL_fast_composite)
38+
EXT(SPV_INTEL_fast_composite) // TODO: to remove
3939
EXT(SPV_INTEL_usm_storage_classes)
4040
EXT(SPV_INTEL_fpga_buffer_location)
4141
EXT(SPV_INTEL_arbitrary_precision_fixed_point)

llvm-spirv/lib/SPIRV/PreprocessMetadata.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -360,12 +360,6 @@ void PreprocessMetadataBase::preprocessVectorComputeMetadata(Module *M,
360360
.add(SLMSize)
361361
.done();
362362
}
363-
if (Attrs.hasFnAttr(kVCMetadata::VCFCEntry)) {
364-
EM.addOp()
365-
.add(&F)
366-
.add(spv::internal::ExecutionModeFastCompositeKernelINTEL)
367-
.done();
368-
}
369363

370364
if (Attrs.hasFnAttr(kVCMetadata::VCNamedBarrierCount)) {
371365
SPIRVWord NBarrierCnt = 0;

llvm-spirv/lib/SPIRV/SPIRVReader.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4645,12 +4645,6 @@ bool SPIRVToLLVM::transMetadata() {
46454645
if (BM->getDesiredBIsRepresentation() == BIsRepresentation::SPIRVFriendlyIR)
46464646
transFunctionDecorationsToMetadata(BF, F);
46474647

4648-
if (BF->hasDecorate(internal::DecorationCallableFunctionINTEL))
4649-
F->addFnAttr(kVCMetadata::VCCallable);
4650-
if (isKernel(BF) &&
4651-
BF->getExecutionMode(internal::ExecutionModeFastCompositeKernelINTEL))
4652-
F->addFnAttr(kVCMetadata::VCFCEntry);
4653-
46544648
if (F->getCallingConv() != CallingConv::SPIR_KERNEL)
46554649
continue;
46564650

llvm-spirv/lib/SPIRV/SPIRVWriter.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,11 +1025,6 @@ SPIRVFunction *LLVMToSPIRVBase::transFunctionDecl(Function *F) {
10251025
BF->addDecorate(DecorationReferencedIndirectlyINTEL);
10261026
}
10271027

1028-
if (Attrs.hasFnAttr(kVCMetadata::VCCallable) &&
1029-
BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_fast_composite)) {
1030-
BF->addDecorate(internal::DecorationCallableFunctionINTEL);
1031-
}
1032-
10331028
if (BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_vector_compute))
10341029
transVectorComputeMetadata(F);
10351030

@@ -6280,11 +6275,6 @@ bool LLVMToSPIRVBase::transExecutionMode() {
62806275
break;
62816276
AddSingleArgExecutionMode(static_cast<ExecutionMode>(EMode));
62826277
} break;
6283-
case spv::internal::ExecutionModeFastCompositeKernelINTEL: {
6284-
if (BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_fast_composite))
6285-
BF->addExecutionMode(BM->add(new SPIRVExecutionMode(
6286-
OpExecutionMode, BF, static_cast<ExecutionMode>(EMode))));
6287-
} break;
62886278
case spv::internal::ExecutionModeNamedSubgroupSizeINTEL: {
62896279
if (!BM->isAllowedToUseExtension(
62906280
ExtensionID::SPV_INTEL_subgroup_requirements))

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVDecorate.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,6 @@ class SPIRVDecorate : public SPIRVDecorateGeneric {
183183
return ExtensionID::SPV_INTEL_fpga_cluster_attributes;
184184
case DecorationFuseLoopsInFunctionINTEL:
185185
return ExtensionID::SPV_INTEL_loop_fuse;
186-
case internal::DecorationCallableFunctionINTEL:
187-
return ExtensionID::SPV_INTEL_fast_composite;
188186
case DecorationMathOpDSPModeINTEL:
189187
return ExtensionID::SPV_INTEL_fpga_dsp_control;
190188
case DecorationInitiationIntervalINTEL:

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVEntry.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -909,8 +909,6 @@ class SPIRVCapability : public SPIRVEntryNoId<OpCapability> {
909909
case CapabilityVectorComputeINTEL:
910910
case CapabilityVectorAnyINTEL:
911911
return ExtensionID::SPV_INTEL_vector_compute;
912-
case internal::CapabilityFastCompositeINTEL:
913-
return ExtensionID::SPV_INTEL_fast_composite;
914912
case internal::CapabilitySubgroupRequirementsINTEL:
915913
return ExtensionID::SPV_INTEL_subgroup_requirements;
916914
default:

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVEnum.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -290,8 +290,6 @@ template <> inline void SPIRVMap<SPIRVExecutionModeKind, SPIRVCapVec>::init() {
290290
{CapabilityFloatingPointModeINTEL});
291291
ADD_VEC_INIT(ExecutionModeSharedLocalMemorySizeINTEL,
292292
{CapabilityVectorComputeINTEL});
293-
ADD_VEC_INIT(internal::ExecutionModeFastCompositeKernelINTEL,
294-
{internal::CapabilityFastCompositeINTEL});
295293
ADD_VEC_INIT(ExecutionModeRegisterMapInterfaceINTEL,
296294
{CapabilityFPGAKernelAttributesv2INTEL});
297295
ADD_VEC_INIT(ExecutionModeStreamingInterfaceINTEL,
@@ -473,8 +471,6 @@ template <> inline void SPIRVMap<Decoration, SPIRVCapVec>::init() {
473471
ADD_VEC_INIT(DecorationAliasScopeINTEL,
474472
{CapabilityMemoryAccessAliasingINTEL});
475473
ADD_VEC_INIT(DecorationNoAliasINTEL, {CapabilityMemoryAccessAliasingINTEL});
476-
ADD_VEC_INIT(internal::DecorationCallableFunctionINTEL,
477-
{internal::CapabilityFastCompositeINTEL});
478474
ADD_VEC_INIT(DecorationMediaBlockIOINTEL, {CapabilityVectorComputeINTEL});
479475
ADD_VEC_INIT(DecorationStallEnableINTEL,
480476
{CapabilityFPGAClusterAttributesINTEL});

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,6 @@ template <> inline void SPIRVMap<Decoration, std::string>::init() {
225225
add(DecorationCacheControlStoreINTEL, "CacheControlStoreINTEL");
226226

227227
// From spirv_internal.hpp
228-
add(internal::DecorationCallableFunctionINTEL, "CallableFunctionINTEL");
229228
add(internal::DecorationRuntimeAlignedINTEL, "RuntimeAlignedINTEL");
230229
add(internal::DecorationHostAccessINTEL, "HostAccessINTEL");
231230
add(internal::DecorationInitModeINTEL, "InitModeINTEL");
@@ -667,7 +666,6 @@ template <> inline void SPIRVMap<Capability, std::string>::init() {
667666
"SubgroupMatrixMultiplyAccumulateINTEL");
668667
add(CapabilityTernaryBitwiseFunctionINTEL, "TernaryBitwiseFunctionINTEL");
669668
// From spirv_internal.hpp
670-
add(internal::CapabilityFastCompositeINTEL, "FastCompositeINTEL");
671669
add(internal::CapabilityOptNoneINTEL, "OptNoneINTEL");
672670
add(internal::CapabilityTokenTypeINTEL, "TokenTypeINTEL");
673671
add(internal::CapabilityJointMatrixINTEL, "JointMatrixINTEL");

llvm-spirv/lib/SPIRV/libSPIRV/spirv_internal.hpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ enum InternalDecoration {
100100
};
101101

102102
enum InternalCapability {
103-
ICapFastCompositeINTEL = 6093,
104103
ICapOptNoneINTEL = 6094,
105104
ICapTokenTypeINTEL = 6112,
106105
ICapabilityJointMatrixINTEL = 6118,
@@ -124,7 +123,6 @@ enum InternalCapability {
124123
enum InternalFunctionControlMask { IFunctionControlOptNoneINTELMask = 0x10000 };
125124

126125
enum InternalExecutionMode {
127-
IExecModeFastCompositeKernelINTEL = 6088,
128126
IExecModeNamedSubgroupSizeINTEL = 6446,
129127
};
130128

@@ -253,8 +251,6 @@ constexpr SourceLanguage SourceLanguageCPP20 =
253251
constexpr Op OpForward = static_cast<Op>(IOpForward);
254252
constexpr Op OpTypeTokenINTEL = static_cast<Op>(IOpTypeTokenINTEL);
255253

256-
constexpr Decoration DecorationCallableFunctionINTEL =
257-
static_cast<Decoration>(IDecCallableFunctionINTEL);
258254
constexpr Decoration DecorationRuntimeAlignedINTEL =
259255
static_cast<Decoration>(IDecRuntimeAlignedINTEL);
260256
constexpr Decoration DecorationHostAccessINTEL =
@@ -266,8 +262,6 @@ constexpr Decoration DecorationImplementInCSRINTEL =
266262
constexpr Decoration DecorationArgumentAttributeINTEL =
267263
static_cast<Decoration>(IDecArgumentAttributeINTEL);
268264

269-
constexpr Capability CapabilityFastCompositeINTEL =
270-
static_cast<Capability>(ICapFastCompositeINTEL);
271265
constexpr Capability CapabilityOptNoneINTEL =
272266
static_cast<Capability>(ICapOptNoneINTEL);
273267
constexpr Capability CapabilityTokenTypeINTEL =
@@ -278,9 +272,6 @@ constexpr Capability CapabilityGlobalVariableDecorationsINTEL =
278272
constexpr FunctionControlMask FunctionControlOptNoneINTELMask =
279273
static_cast<FunctionControlMask>(IFunctionControlOptNoneINTELMask);
280274

281-
constexpr ExecutionMode ExecutionModeFastCompositeKernelINTEL =
282-
static_cast<ExecutionMode>(IExecModeFastCompositeKernelINTEL);
283-
284275
constexpr ExecutionMode ExecutionModeNamedSubgroupSizeINTEL =
285276
static_cast<ExecutionMode>(IExecModeNamedSubgroupSizeINTEL);
286277

llvm-spirv/test/extensions/INTEL/SPV_INTEL_fast_composite/callable-attribute-decoration.ll

Lines changed: 0 additions & 19 deletions
This file was deleted.

llvm-spirv/test/extensions/INTEL/SPV_INTEL_fast_composite/fast-composit-entry.ll

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)