Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test to check escrow get rewards calls correct pallet #507

Open
bvotteler opened this issue Dec 21, 2022 · 0 comments
Open

Add unit test to check escrow get rewards calls correct pallet #507

bvotteler opened this issue Dec 21, 2022 · 0 comments
Labels
enhancement New feature or request prio:low

Comments

@bvotteler
Copy link
Contributor

We introduced a bug when refactoring some work as getting staked rewards called the incorrect palette’s withdrawRewards() function (ie. escrow rather than escrowAnnuity).

The method making the call: EscrowAPI.buildWithdrawRewardsExtrinsic()

Add a unit test that checks the call is made for the right pallet.
@bvotteler bvotteler added enhancement New feature or request prio:low labels Dec 21, 2022
@nud3l nud3l added this to Backlog Jan 3, 2023
@nud3l nud3l moved this to Todo ⏳ in Backlog Jan 3, 2023
@gregdhill gregdhill changed the title Add unit test to check escrow get rewards calls correct palette Add unit test to check escrow get rewards calls correct pallet Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request prio:low
Projects
Backlog
Status: Todo ⏳
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bvotteler