Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show author names next to final result in author merge tool #10297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ananyakaligal
Copy link
Contributor

@ananyakaligal ananyakaligal commented Jan 8, 2025

Closes #10292

Adds author names next to the merged works in the merge view, improving clarity by making it easier to identify duplicate authors. It ensures author names are shown consistently throughout the process, not just next to unmerged works.

Technical

Added enhancedRecords to the merge function in MergeTable.vue

Testing

Screenshot

Screenshot from 2025-01-09 02-42-50

Stakeholders

@RayBB

@RayBB
Copy link
Collaborator

RayBB commented Jan 8, 2025

@ananyakaligal are you sure all the commits you want are here? The diff looks like only a variable was renamed.

@ananyakaligal
Copy link
Contributor Author

@RayBB, Yes!! I reviewed a pull request on the same issue addressed before (#9920 ), and it was mentioned there to make this simple change to display author names next to the merged works as well.

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and working like a charm!

Now we just need staff to sign off on this one 👍

image

@ananyakaligal
Copy link
Contributor Author

cool

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Jan 13, 2025
@mekarpeles mekarpeles self-assigned this Jan 21, 2025
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a look at this one while on a call with @RayBB , @mekarpeles !

Thank you @ananyakaligal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Waiting Review/Merge from Staff
Development

Successfully merging this pull request may close these issues.

Show author names next to final result in author merge tool
4 participants