-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(carousel): reduce Solr load via lazy loading Related Books Carousels (dev-mohit06) #10388
base: master
Are you sure you want to change the base?
Conversation
…sels (dev-mohit06)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10388 +/- ##
==========================================
+ Coverage 17.44% 17.50% +0.05%
==========================================
Files 89 87 -2
Lines 4792 4793 +1
Branches 848 852 +4
==========================================
+ Hits 836 839 +3
+ Misses 3436 3432 -4
- Partials 520 522 +2 ☔ View full report in Codecov by Sentry. |
Thank you, nice work submitting a PR! |
@mekarpeles What changes should I make since I'm a beginner? I tried reading the repo's docs and did what I understood - please guide me on how to improve the code and merge the branch. |
Hi @mekarpeles, I recently sent you a LinkedIn connection request (Mohit Paddhariya). As a bachelor’s student passionate about open source and tech, connecting with you would mean a lot to me and help guide my career. Hope you can approve it! 😊 Thanks a ton! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally and it works well.
Maybe we can bump up the root margin so that it loads a bit sooner. Like 500px? I'd say do 50vh but it has to be absolute or percentages.
@mekarpeles do you want to give it a spin and see if this achieves what you'd like it?
Hello @RayBB, could you please let me know when my branch is expected to be merged? Thank you! |
Yes, it will be merged right after staff approve it.
…On Tue, Jan 28, 2025, 11:18 AM Mohit Paddhariya ***@***.***> wrote:
Hello @RayBB <https://github.com/RayBB>, could you please let me know
when my branch is expected to be merged? Thank you!
—
Reply to this email directly, view it on GitHub
<#10388 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHA5AOUITGMNDNKWO46VHD2M6UVXAVCNFSM6AAAAABV4WCFCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJZGQ3DKNRVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @RayBB and @mekarpeles, Thank you again for your thoughtful review of my PR implementing lazy loading for the Related Books carousels! Your feedback was incredibly helpful, and I’m grateful for the chance to learn through contributing to such a meaningful project. As a bachelor’s student passionate about open-source development, I’m eager to apply for Google Summer of Code (GSoC) this year and would love to collaborate with the Internet Archive as my chosen organization. I deeply align with the Archive’s mission to provide universal access to knowledge, and I’m committed to contributing meaningfully to its technical ecosystem. To strengthen my GSoC application and continue growing as a contributor, I’d appreciate your advice on:
I’m enthusiastic about deepening my collaboration with the team and am open to any suggestions—whether contributing to more issues, participating in discussions, or exploring project ideas aligned with the Archive’s roadmap. Thank you for your mentorship and for considering my request. I’m excited to keep learning and contributing! Best regards, |
2947f59
to
fb469a6
Compare
Reduce Solr Load via Lazy Loading Related Books Carousels (dev-mohit06)
Closes #10354
Performance Optimization
Implement lazy loading for Related Books Carousels to reduce unnecessary Solr API calls and improve page load performance.
Technical
carousels_partials.js
to fetch carousel data only when visibleTesting
Screenshot
No UI changes - performance optimization
Stakeholders
@RayBB @mekarpeles
Attribution
Code implementation based on recommended approach in issue discussion.