Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping of heading titles in 'merges' page #10386

Open
Craig-Rosario opened this issue Jan 26, 2025 · 0 comments · May be fixed by #10387
Open

Clipping of heading titles in 'merges' page #10386

Craig-Rosario opened this issue Jan 26, 2025 · 0 comments · May be fixed by #10387
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@Craig-Rosario
Copy link
Contributor

Problem

In the (https://openlibrary.org/merges) page, when we resize the page. We see the that the heading titles clip outside to box.

Image

In some devices, it completely clips out of the box:

Image

Reproducing the bug

  1. Go to https://openlibrary.org/merges
  2. Resize the page to any mobile device screen
  • Expected behavior: The heading titles shouldn't clip out of the box
  • Actual behavior: These titles are clipping outside the box

Context

  • Browser (Chrome, Safari, Firefox, etc): Chrome/Firefox
  • OS (Windows, Mac, etc): Windows
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders

Status

Willing to work on this issue, after conformation from leads/maintainers


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@Craig-Rosario Craig-Rosario added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Jan 26, 2025
abhiyaligar added a commit to abhiyaligar/openlibrary that referenced this issue Jan 26, 2025
@mekarpeles mekarpeles added Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants