Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit specific edition #10392

Open
zorae opened this issue Jan 28, 2025 · 2 comments
Open

Cannot edit specific edition #10392

zorae opened this issue Jan 28, 2025 · 2 comments
Labels
Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]

Comments

@zorae
Copy link

zorae commented Jan 28, 2025

Problem

I’m unable to edit this specific edition. Trying to save changes always results in an internal error. The problem might be related to a malformed entry in the “weight” field, but clearing the field doesn’t resolve the issue either.

Even with debug=true, the errors just look like:
Sorry. There seems to be a problem with what you were just looking at.
We've noted the error 2025-01-28/100418148893 and will look into it as soon as possible.

Reproducing the bug

  1. Go to https://openlibrary.org/books/OL34402860M/Painted_Diagrams/edit
  2. Make any change to the work or edition
  3. Save
  • Expected behavior: The change is saved.
  • Actual behavior: An internal server error occurs.

Context

  • Browser (Chrome, Safari, Firefox, etc): Safari
  • OS (Windows, Mac, etc):
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

@seabelis has reproduced the problem

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@zorae zorae added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Jan 28, 2025
@hornc
Copy link
Collaborator

hornc commented Jan 28, 2025

@zorae it looks like multiple edits have been made to this record since the issue was opened. Maybe the first one that set the weight to 0.01 fixed the problem? I think there was another issue where there's a minimum weight?

The weight had no units, and seems made up, so I cleared it. Does it look ok now?

@zorae
Copy link
Author

zorae commented Jan 29, 2025

@hornc Yep, seems like it’s fixed! Can anyone confirm if setting the weight to 0.01 is really the trick to resolving these issues? I’ve come across broken editions like this in the past, so I’m sure there’s others still out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

2 participants