Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering autocomplete with certain search terms results in Solr exceptions #3872

Open
Tracked by #7673
jimchamp opened this issue Oct 1, 2020 · 1 comment
Open
Tracked by #7673
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@jimchamp
Copy link
Collaborator

jimchamp commented Oct 1, 2020

Solr throws parsing exceptions when certain search terms are typed into the search bar and autocomplete is triggered.

Search Terms:
title:
author_name:
key:

There may be other terms that will cause this. To make matters worse, if one of the above terms are followed with a double quote character, autocomplete calls will continue to fail until a closing double quote character is typed.

Evidence / Screenshot (if possible)

autocomplete_bug

Search terms for each request in the above screenshot are as follows:

  1. title
  2. title:
  3. title:"abc
  4. title:"abc"

Note: This screenshot is from my local instance. 502 HTTP errors are returned in dev.

Relevant url?

https://openlibrary.org/

Steps to Reproduce

  1. Navigate to any Open Library page that has a search bar.
  2. Select a search facet that allows for auto-completion of search terms (either all, title, or author).
  3. Type one of the search terms listed above.
  • Actual: Autocomplete XHR call fails.
  • Expected: Autocomplete XHR returns 200, and suggested results are listed.

Details

  • Logged in (Y/N)? N/A
  • Browser type/version? N/A
  • Operating system? N/A
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders

@jimchamp jimchamp added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Oct 1, 2020
@xayhewalo xayhewalo added Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Oct 5, 2020
@mekarpeles mekarpeles mentioned this issue Mar 16, 2023
3 tasks
@jimchamp
Copy link
Collaborator Author

Possibly related to #10390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Solr Issues related to the configuration or use of the Solr subsystem. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

2 participants