From 186b7c1372584216a386d64c201e7ddaca87e3e6 Mon Sep 17 00:00:00 2001
From: Jacob Mischka <jacob@mischka.me>
Date: Tue, 12 Jul 2022 10:00:19 -0500
Subject: [PATCH 1/3] Enforce io.select defaultValue being in provided options

If not the case, log a warning in the console and discard the provided
value (if `select.multiple`, discard the entire `defaultValue` array
instead of filtering).

To unify the `defaultValue` logic on our frontend, only use it when
determining the initial results array in TransactionUI, and use
the resulting `props.value` in each IO component's component.

Closes #669
---
 src/classes/IOClient.ts          | 12 ++++-
 src/components/selectMultiple.ts | 78 ++++++++++++++++++--------------
 src/components/selectSingle.ts   | 76 +++++++++++++++++--------------
 src/examples/basic/index.ts      | 14 ++++++
 src/ioSchema.ts                  |  4 ++
 5 files changed, 115 insertions(+), 69 deletions(-)

diff --git a/src/classes/IOClient.ts b/src/classes/IOClient.ts
index a8848b8..aa85057 100644
--- a/src/classes/IOClient.ts
+++ b/src/classes/IOClient.ts
@@ -338,8 +338,16 @@ export class IOClient {
         richText: this.createIOMethod('INPUT_RICH_TEXT'),
       },
       select: {
-        single: this.createIOMethod('SELECT_SINGLE', true, selectSingle),
-        multiple: this.createIOMethod('SELECT_MULTIPLE', true, selectMultiple),
+        single: this.createIOMethod(
+          'SELECT_SINGLE',
+          true,
+          selectSingle(this.logger)
+        ),
+        multiple: this.createIOMethod(
+          'SELECT_MULTIPLE',
+          true,
+          selectMultiple(this.logger)
+        ),
         table: this.createIOMethod(
           'SELECT_TABLE',
           true,
diff --git a/src/components/selectMultiple.ts b/src/components/selectMultiple.ts
index abd82a2..794be70 100644
--- a/src/components/selectMultiple.ts
+++ b/src/components/selectMultiple.ts
@@ -1,5 +1,6 @@
 import { z } from 'zod'
 import { T_IO_PROPS, T_IO_RETURNS, labelValue } from '../ioSchema'
+import Logger from '../classes/Logger'
 
 type SelectMultipleProps<Option extends z.infer<typeof labelValue> | string> =
   Omit<T_IO_PROPS<'SELECT_MULTIPLE'>, 'options' | 'defaultValue'> & {
@@ -7,47 +8,56 @@ type SelectMultipleProps<Option extends z.infer<typeof labelValue> | string> =
     defaultValue?: Option[]
   }
 
-export default function selectMultiple<
-  Option extends z.infer<typeof labelValue> | string
->(props: SelectMultipleProps<Option>) {
-  const normalizedOptions: z.infer<typeof labelValue>[] = props.options.map(
-    option => {
-      if (typeof option === 'string') {
+export default function selectMultiple(logger: Logger) {
+  return <Option extends z.infer<typeof labelValue> | string>(
+    props: SelectMultipleProps<Option>
+  ) => {
+    const normalizedOptions: z.infer<typeof labelValue>[] = props.options.map(
+      option => {
+        if (typeof option === 'string') {
+          return {
+            label: option,
+            value: option,
+          }
+        } else {
+          return option as Exclude<Option, string>
+        }
+      }
+    )
+    type Options = typeof props.options
+    const optionMap = new Map(
+      normalizedOptions.map((o, i) => [o.value, props.options[i]])
+    )
+
+    let defaultValue = props.defaultValue?.map(d => {
+      if (typeof d === 'string') {
         return {
-          label: option,
-          value: option,
+          label: d,
+          value: d,
         }
       } else {
-        return option as Exclude<Option, string>
+        return d as Exclude<Option, string>
       }
-    }
-  )
-  type Options = typeof props.options
-  const optionMap = new Map(
-    normalizedOptions.map((o, i) => [o.value, props.options[i]])
-  )
+    })
 
-  const defaultValue = props.defaultValue?.map(d => {
-    if (typeof d === 'string') {
-      return {
-        label: d,
-        value: d,
-      }
-    } else {
-      return d
+    if (defaultValue && defaultValue.every(val => !optionMap.has(val.value))) {
+      logger.warn(
+        'The defaultValue property must be a subset of the provided options, the provided defaultValue will be discarded.'
+      )
+      defaultValue = []
     }
-  })
 
-  const stripper = labelValue.strip()
+    const stripper = labelValue.strip()
 
-  return {
-    props: {
-      ...props,
-      defaultValue: defaultValue?.map(o => stripper.parse(o)),
-      options: normalizedOptions.map(o => stripper.parse(o)),
-    },
-    getValue(response: T_IO_RETURNS<'SELECT_MULTIPLE'>): Options {
-      return response.map(r => optionMap.get(r.value)) as Options
-    },
+    return {
+      props: {
+        ...props,
+        defaultValue: defaultValue?.map(o => stripper.parse(o)),
+        options: normalizedOptions.map(o => stripper.parse(o)),
+      },
+      getValue(response: T_IO_RETURNS<'SELECT_MULTIPLE'>): Options {
+        return response.map(r => optionMap.get(r.value)) as Options
+      },
+    }
   }
 }
diff --git a/src/components/selectSingle.ts b/src/components/selectSingle.ts
index 2a0b225..eb315f5 100644
--- a/src/components/selectSingle.ts
+++ b/src/components/selectSingle.ts
@@ -1,5 +1,6 @@
 import { z } from 'zod'
 import { T_IO_PROPS, T_IO_RETURNS, richSelectOption } from '../ioSchema'
+import Logger from '../classes/Logger'
 
 type SelectSingleProps<
   Option extends z.infer<typeof richSelectOption> | string
@@ -8,42 +9,51 @@ type SelectSingleProps<
   defaultValue?: Option
 }
 
-export default function selectSingle<
-  Option extends z.infer<typeof richSelectOption> | string
->(props: SelectSingleProps<Option>) {
-  const normalizedOptions = props.options.map(option => {
-    if (typeof option === 'string') {
-      return {
-        label: option,
-        value: option,
+export default function selectSingle(logger: Logger) {
+  return <Option extends z.infer<typeof richSelectOption> | string>(
+    props: SelectSingleProps<Option>
+  ) => {
+    const normalizedOptions = props.options.map(option => {
+      if (typeof option === 'string') {
+        return {
+          label: option,
+          value: option,
+        }
+      } else {
+        return option as Exclude<Option, string>
       }
-    } else {
-      return option as Exclude<Option, string>
-    }
-  })
+    })
 
-  type Options = typeof props.options
-  const optionMap = new Map(
-    normalizedOptions.map((o, i) => [o.value, props.options[i]])
-  )
-  const stripper = richSelectOption.strip()
+    type Options = typeof props.options
+    const optionMap = new Map(
+      normalizedOptions.map((o, i) => [o.value, props.options[i]])
+    )
+    const stripper = richSelectOption.strip()
 
-  const defaultValue =
-    typeof props.defaultValue === 'string'
-      ? {
-          label: props.defaultValue,
-          value: props.defaultValue,
-        }
-      : (props.defaultValue as Exclude<Option, string>)
+    let defaultValue =
+      typeof props.defaultValue === 'string'
+        ? {
+            label: props.defaultValue,
+            value: props.defaultValue,
+          }
+        : (props.defaultValue as Exclude<Option, string> | undefined)
 
-  return {
-    props: {
-      ...props,
-      defaultValue: defaultValue ? stripper.parse(defaultValue) : undefined,
-      options: normalizedOptions.map(o => stripper.parse(o)),
-    },
-    getValue(response: T_IO_RETURNS<'SELECT_SINGLE'>) {
-      return optionMap.get(response.value) as Options[0]
-    },
+    if (defaultValue && !optionMap.has(defaultValue.value)) {
+      logger.warn(
+        'The defaultValue property must be a value in the provided options, the provided defaultValue will be discarded.'
+      )
+      defaultValue = undefined
+    }
+
+    return {
+      props: {
+        ...props,
+        defaultValue: defaultValue ? stripper.parse(defaultValue) : undefined,
+        options: normalizedOptions.map(o => stripper.parse(o)),
+      },
+      getValue(response: T_IO_RETURNS<'SELECT_SINGLE'>) {
+        return optionMap.get(response.value) as Options[0]
+      },
+    }
   }
 }
diff --git a/src/examples/basic/index.ts b/src/examples/basic/index.ts
index 8a2fc2a..fbd010a 100644
--- a/src/examples/basic/index.ts
+++ b/src/examples/basic/index.ts
@@ -147,6 +147,20 @@ const interval = new Interval({
         io.input.boolean('Boolean'),
       ])
     },
+    petr_repro: async () => {
+      // Data will be undefined if you just click "continue" without modifying the form.
+      const data = await io.select.single('Some field', {
+        options: [],
+        defaultValue: { label: 'my label', value: 'my_value' },
+      })
+
+      // This should be an object equal to the defaultValue
+      console.log('data', data)
+
+      await io.display.object('Return', {
+        data: { mySuperValue: data || 'No data' },
+      })
+    },
     enter_a_number: async io => {
       const num = await io.input.number('Enter a number')
 
diff --git a/src/ioSchema.ts b/src/ioSchema.ts
index 1a808cd..04e4b6c 100644
--- a/src/ioSchema.ts
+++ b/src/ioSchema.ts
@@ -51,6 +51,8 @@ export const labelValue = z
   })
   .passthrough()
 
+export type LabelValue = z.infer<typeof labelValue>
+
 export const richSelectOption = z
   .object({
     label: z.string(),
@@ -60,6 +62,8 @@ export const richSelectOption = z
   })
   .passthrough()
 
+export type RichSelectOption = z.infer<typeof richSelectOption>
+
 const objectLiteralSchema = z.union([
   z.string(),
   z.number(),

From 1423ec3ac8ac174b9b1e1dbdae95031dcc579a6b Mon Sep 17 00:00:00 2001
From: Jacob Mischka <jacob@mischka.me>
Date: Thu, 14 Jul 2022 11:11:17 -0500
Subject: [PATCH 2/3] Bump working SDK version to 0.22.0-dev

Oops, should have done this before making any SDK changes. Also add test
suite for 0.21.0 release.
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index df9763a..9f146f6 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@interval/sdk",
-  "version": "0.21.0",
+  "version": "0.22.0-dev",
   "homepage": "https://interval.com",
   "repository": {
     "type": "git",

From e0753151bfdb667d1bb01b22395a4350f09cabb0 Mon Sep 17 00:00:00 2001
From: Jacob Mischka <jacob@mischka.me>
Date: Fri, 15 Jul 2022 08:45:18 -0500
Subject: [PATCH 3/3] Re-export io and ctx from experimental entrypoint for
 convenience

---
 src/examples/nested/index.ts | 4 ++--
 src/experimental.ts          | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/examples/nested/index.ts b/src/examples/nested/index.ts
index 8ea171b..9e75deb 100644
--- a/src/examples/nested/index.ts
+++ b/src/examples/nested/index.ts
@@ -1,5 +1,5 @@
 import { IntervalActionHandler } from '../..'
-import ExperimentalInterval, { ActionGroup } from '../../experimental'
+import ExperimentalInterval, { ActionGroup, io } from '../../experimental'
 
 const interval = new ExperimentalInterval({
   apiKey: 'alex_dev_kcLjzxNFxmGLf0aKtLVhuckt6sziQJtxFOdtM19tBrMUp5mj',
@@ -7,7 +7,7 @@ const interval = new ExperimentalInterval({
   endpoint: 'ws://localhost:3000/websocket',
 })
 
-const action: IntervalActionHandler = async io => {
+const action: IntervalActionHandler = async () => {
   const message = await io.input.text('Hello?')
 
   return message
diff --git a/src/experimental.ts b/src/experimental.ts
index 4e636fd..0b41e71 100644
--- a/src/experimental.ts
+++ b/src/experimental.ts
@@ -1,7 +1,7 @@
 import { z } from 'zod'
 import fetch from 'node-fetch'
 import type { IncomingMessage, ServerResponse } from 'http'
-import Interval, { IntervalError } from '.'
+import Interval, { io, ctx, IntervalError } from '.'
 import IntervalClient from './classes/IntervalClient'
 import ActionGroup from './classes/ActionGroup'
 import * as pkg from '../package.json'
@@ -13,7 +13,7 @@ import {
   LambdaResponse,
 } from './utils/http'
 
-export { ActionGroup }
+export { ActionGroup, io, ctx, IntervalError }
 
 export default class ExperimentalInterval extends Interval {
   /*