Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checkbox): add helperText and errorText properties #30140
base: feature-8.5
Are you sure you want to change the base?
feat(checkbox): add helperText and errorText properties #30140
Changes from all commits
2aaf9e4
315642c
7e86b42
b3aeac1
e4531ea
804ebbd
a09d2da
b67d888
e72fe10
bfc9617
0f03052
4794ed7
444e213
54da960
662d1ff
bfc8cf7
d61c38d
45141d5
e08d608
4ece469
e32256f
39e6d9f
7996747
5f86dd9
d771da6
38ac4f9
bac7383
d8a1502
6b83b14
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this because without it the text is really small.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above* :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text alignment change is necessary because without it the label is left aligned and when you change between helper/error text it jumps:
helper-stacked.mov
After my changes:
helper-stacked-fixed.mov
This issue does not exist without helper/error text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. Everything is centered already so the supporting text should follow that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't make changes to any of this code I just moved it lower so it would take priority over the
justify-content
I specified inlabel-placement-end
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class
checkbox-bottom
doesn't make as much sense here since it's not on the bottom of the entire checkbox but it is under the label still and I named it this to remain consistent with input, textarea, etc.