-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toggle): add helperText and errorText properties #30161
base: feature-8.5
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The supporting text being read twice is the main issue.
The rest are just questions that were asked over in the checkbox PR that can be applied here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// ---------------------------------------------------------------- | ||
|
||
.toggle-bottom { | ||
@include padding(4px, null, null, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be on the native partial and on Ionic theme use the proper space token.
Issue number: N/A
What is the current behavior?
Toggle does not support helper and error text.
What is the new behavior?
Adds support for helper and error text, similar to input and textarea.
Does this introduce a breaking change?
Other information