Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): fix auto scroll to selected item in ion-select #30202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(select): fix auto scroll to selected item in ion-select #30202

wants to merge 1 commit into from

Conversation

JoaoFerreira-FrontEnd
Copy link

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Feb 20, 2025 •
edited
Loading

Issue number: resolves #19296

What is the current behavior?

  • when the ion-select is with the interface action-sheet or alert is not scrolling to the selected item on open

What is the new behavior?

  • change test page so all select have scroll;
  • guarantee focusVisibleElement is called on all interfaces;

Does this introduce a breaking change?

  • Yes
  • No

Other information

@JoaoFerreira-FrontEnd
- guarantee focusVisibleElement is called on all interfaces;
b8f428f 
- change test page so all select have scroll;
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner February 20, 2025 20:51
@vercel Vercel
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 8:51pm

@github-actions github-actions bot added the package: core @ionic/core package label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenOsodrac BenOsodrac BenOsodrac approved these changes

@ShaneK ShaneK Awaiting requested review from ShaneK ShaneK is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Auto scroll to selected item in ion-select
2 participants
@JoaoFerreira-FrontEnd @BenOsodrac