-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(searchbar): add sizes for ionic theme #30211
Open
thetaPC
wants to merge
14
commits into
next
Choose a base branch
from
ROU-11251
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b24cc94
feat(searchbar): add sizes for ionic theme
thetaPC afbcdfe
test(searchbar): add snapshots
thetaPC 86df4b7
chore(searchbar): run build
thetaPC 7523cb4
test(searchbar): update states snapshots
thetaPC 4531a40
refactor(searchbar): add missing new line
thetaPC 7323496
test(searchbar): update snapshots
thetaPC 0e5ed2e
refactor(searchbar): add test case
thetaPC 733876a
Merge branch 'next' of github.com:ionic-team/ionic-framework into ROU…
thetaPC e986338
refactor(searchbar): update icon sizes
thetaPC f0ee79c
test(searchbar): update snapshots
thetaPC b0e2e7f
refactor(searchbar): update heights
thetaPC 3ea2e9a
test(searchbar): add small
thetaPC 75bc4d3
chore(searchbar): run build
thetaPC a82105d
refactor(searchbar): update large padding
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<!DOCTYPE html> | ||
<html lang="en" dir="ltr"> | ||
<head> | ||
<meta charset="UTF-8" /> | ||
<title>Searchbar - Size</title> | ||
<meta | ||
name="viewport" | ||
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no, viewport-fit=cover" | ||
/> | ||
<link href="../../../../../css/ionic.bundle.css" rel="stylesheet" /> | ||
<link href="../../../../../scripts/testing/styles.css" rel="stylesheet" /> | ||
<script src="../../../../../scripts/testing/scripts.js"></script> | ||
<script nomodule src="../../../../../dist/ionic/ionic.js"></script> | ||
<script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script> | ||
</head> | ||
|
||
<body> | ||
<ion-app> | ||
<ion-content> | ||
<h5 class="ion-padding-start ion-padding-top">Search - Default</h5> | ||
<ion-searchbar show-clear-button="always" value="Filled text"></ion-searchbar> | ||
|
||
<h5 class="ion-padding-start ion-padding-top">Search - Medium</h5> | ||
<ion-searchbar size="medium" show-clear-button="always" value="Filled text"></ion-searchbar> | ||
|
||
<h5 class="ion-padding-start ion-padding-top">Search - Large</h5> | ||
<ion-searchbar size="large" show-clear-button="always" value="Filled text"></ion-searchbar> | ||
</ion-content> | ||
</ion-app> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { expect } from '@playwright/test'; | ||
import { configs, test } from '@utils/test/playwright'; | ||
|
||
/** | ||
* This behavior only applies to the `ionic` theme. | ||
* This behavior does not vary across directions. | ||
*/ | ||
configs({ directions: ['ltr'], modes: ['ionic-md'] }).forEach(({ title, screenshot, config }) => { | ||
test.describe(title('searchbar: size'), () => { | ||
['medium', 'large'].forEach((size) => { | ||
test(`${size} - should not have visual regressions`, async ({ page }) => { | ||
await page.setContent( | ||
` | ||
<ion-searchbar size="${size}" show-clear-button="always" value="Filled text"></ion-searchbar> | ||
`, | ||
config | ||
); | ||
|
||
const searchbar = page.locator('ion-searchbar'); | ||
|
||
await expect(searchbar).toHaveScreenshot(screenshot(`searchbar-size-${size}`)); | ||
}); | ||
}); | ||
}); | ||
}); |
Binary file added
BIN
+1.96 KB
...2e.ts-snapshots/searchbar-size-large-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.46 KB
...e.ts-snapshots/searchbar-size-large-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.06 KB
...2e.ts-snapshots/searchbar-size-large-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.92 KB
...e.ts-snapshots/searchbar-size-medium-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.35 KB
....ts-snapshots/searchbar-size-medium-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.02 KB
...e.ts-snapshots/searchbar-size-medium-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed because it doesn't seem to be used.