Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): scroll to the selected option before the overlay is visible #30214

Open
wants to merge 2 commits into
base: ROU-11568_V2
Choose a base branch
from
Open

fix(select): scroll to the selected option before the overlay is visible #30214

wants to merge 2 commits into from

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Feb 25, 2025 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Feb 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:22pm

@github-actions github-actions bot added the package: core @ionic/core package label Feb 25, 2025
@brandyscarney brandyscarney marked this pull request as ready for review February 26, 2025 15:29
@brandyscarney brandyscarney requested a review from a team as a code owner February 26, 2025 15:29
@brandyscarney brandyscarney requested review from thetaPC and removed request for a team February 26, 2025 15:29
thetaPC
thetaPC approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!! Just a tiny suggestion but not a blocker.

thetaPC
thetaPC approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@BenOsodrac BenOsodrac BenOsodrac approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandyscarney @thetaPC @BenOsodrac