Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): adding test app for react 19, fixing framework support for react 19 #30217

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ShaneK
Copy link
Member

@ShaneK ShaneK commented Feb 26, 2025

Issue number: resolves #


What is the current behavior?

Currently, there is no test app for React 19. Also, the output test in the react 18 test app is broken because it uses vitest but that file is trying to use jest still.

What is the new behavior?

Now, there is a test app for React 19

  • Additionally, fixed the output test for react 18 by moving to vitest
  • Going forward, react test apps will default to the vitest test app

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ShaneK ShaneK requested a review from a team as a code owner February 26, 2025 19:10
@ShaneK ShaneK requested a review from gnbm February 26, 2025 19:10
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 9:50pm

@github-actions github-actions bot added the package: react @ionic/react package label Feb 26, 2025
@ShaneK ShaneK changed the title feat(react): Adding test app for React 19 feat(react): adding test app for React 19 Feb 26, 2025
@ShaneK ShaneK changed the title feat(react): adding test app for React 19 feat(react): adding test app for react 19 Feb 26, 2025
@ShaneK ShaneK changed the title feat(react): adding test app for react 19 feat(react): adding test app for react 19, fixing framework support for react 19 Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants