fix(focusVisibleElement): set focus on custom appRootSelector #30218
+66
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
requested review from
ShaneK,
brandyscarney and
JoaoFerreira-FrontEnd
and removed request for
ShaneK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
focusVisibleElementfunction does not take into account that a user might use a customappRootSelector. If they do, the thesetFocusfunction will throw an error that it does not exist leading to focus not being established on the elements.This error can be seen when opening a
ion-selectwith a modal interface.What is the new behavior?
ion-appand for the custom app root selector. This will make sure that there will be consistency between both if that logic needs to change in the future.Does this introduce a breaking change?
Other information