Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp segment metrics are misleading #123

Closed
brayniac opened this issue Nov 30, 2023 · 0 comments · Fixed by #124
Closed

tcp segment metrics are misleading #123

brayniac opened this issue Nov 30, 2023 · 0 comments · Fixed by #124

Comments

@brayniac
Copy link
Contributor

The tcp/transmit/segments and tcp/receive/segments metrics are misleading because we have instrumented closer to the socket level.

This means that for workloads with large payloads we can undercount because we count before fragmentation and count after reassembly.

We should rename these metrics and clarify in the metric descriptions that these are logical sends/recvs and not segment counts. We should augment the existing metrics with rx/tx metrics along the softirq path.

brayniac added a commit to brayniac/rezolus that referenced this issue Nov 30, 2023
Fixes iopsystems#123 by using /proc/net/snmp to report TCP in/out segments
and renaming the eBPF metrics so we can continue to report logical
sends/recvs before fragmentation and after reassembly respectively.
brayniac added a commit that referenced this issue Nov 30, 2023
Fixes #123 by using /proc/net/snmp to report TCP in/out segments
and renaming the eBPF metrics so we can continue to report logical
sends/recvs before fragmentation and after reassembly respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant