Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error when a mutliaddr without peer ID is passed #64

Open
2color opened this issue Sep 6, 2024 · 0 comments
Open

Improve error when a mutliaddr without peer ID is passed #64

2color opened this issue Sep 6, 2024 · 0 comments
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week P2 Medium: Good to have, but can wait until someone steps up

Comments

@2color
Copy link
Member

2color commented Sep 6, 2024

UX Problem

Passing a multiaddr without a peer ID will yield the following error:

⚠️ backend returned an error: 500 invalid p2p multiaddr

For example:
Screenshot 2024-09-06 at 12 36 47 PM

Suggested solution

Either perform client side validation on the multiaddr and require a PeerID in the multiaddr or improve the error message from the backend.
@lidel lidel added P2 Medium: Good to have, but can wait until someone steps up dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @2color