Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo PartOfSpeach -> PartOfSpeech #20

Open
tailhook opened this issue Aug 27, 2018 · 2 comments
Open

Typo PartOfSpeach -> PartOfSpeech #20

tailhook opened this issue Aug 27, 2018 · 2 comments

Comments

@tailhook
Copy link
Contributor

I would send a PR, but I'm not sure if there is a policy about breaking changes.

Also while we're at it, I think rust leans towards unabbreviating such enumerations. I.e. full name like Gerund should be used as enum option and conversion methods provided like opencorpora_to_str() for compatibility with other systems.
@alexander-irbis
Copy link
Collaborator

As mentioned in readme, there is no stable API, so feel free to fix such issues.
Anyway, they should be fixed to provide everyone with a non-confusing API.

@alexander-irbis
Copy link
Collaborator

Also, we can discuss any issues on the gitter channel.

tailhook added a commit to tailhook/rsmorphy that referenced this issue Aug 27, 2018
@tailhook
Fix PartOfSpeach -> PartOfSpeech typo (fixes irbis-labs#20)
51b465d
@tailhook tailhook mentioned this issue Aug 27, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tailhook @alexander-irbis