Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie created without samesite property set #35

Closed
steve-forth opened this issue Nov 8, 2022 · 1 comment · Fixed by #40 or #42
Closed

Cookie created without samesite property set #35

steve-forth opened this issue Nov 8, 2022 · 1 comment · Fixed by #40 or #42
Milestone

Comments

@steve-forth
Copy link

A recent pen test of an application using this code highlighted that the CV cookie is set without specifying the SameSite property. I understand this cookie is used to connect callbacks after redirection to the authentication provider such as Okta.

SameSite prevents the browser from sending this cookie along with cross-site requests. The main goal is to mitigate the risk of cross-origin information leakage. It also provides some protection against cross-site request forgery attacks. Possible values for the flag are none, lax, or strict.

The strict value will prevent the cookie from being sent by the browser to the target site in all cross-site browsing contexts, even when following a regular link.

The lax value provides a reasonable balance between security and usability for websites that want to maintain user’s logged-in session after the user arrives from an external link.

The none value won’t give any kind of protection. The browser attaches the cookies in all cross-site browsing contexts.

Proposed remediation
Enable the SameSite attribute in strict mode for the CV cookie to mitigate the risk against cross-site request forgery attacks

@SiCoe
Copy link

SiCoe commented Oct 2, 2023

Changes for this issue have been merged into master and released as v4.0.0

@SiCoe SiCoe closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants