Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ansible Playbook for deploying multiple docker compose instances. #348

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

hey-johnnypark
Copy link
Member

Hi @jekutzsche ,

this feature enables the installation of n - number of clients using Ansible.

Copy link
Member

@jekutzsche jekutzsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am irritated by all the copying of the certificate and key files. Wouldn't it be better to work with only one directory or with links here, so that it is less error-prone later when checking or exchanging the certificates.

Comment on lines +1 to +2
sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
sudo chmod +x /usr/local/bin/docker-compose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make more sense to use https://github.com/docker/compose/releases/latest/download/docker-compose… so that you don't always have to maintain the version?

Comment on lines +72 to +74
vars:
cert: "{{ nginx.cert}}"
key: "{{ nginx.key}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find anything where these variables are used.

@jekutzsche jekutzsche force-pushed the develop branch 7 times, most recently from 1a856bc to 7ed21c6 Compare September 23, 2021 12:43
@jekutzsche jekutzsche force-pushed the develop branch 4 times, most recently from ceb58c0 to c1e8368 Compare December 20, 2021 10:12
@jekutzsche jekutzsche force-pushed the develop branch 8 times, most recently from 7f0b9b1 to 272c2ac Compare April 14, 2022 09:32
@jekutzsche jekutzsche force-pushed the develop branch 7 times, most recently from 079e7dd to bbabf0a Compare April 14, 2022 11:58
@jekutzsche jekutzsche force-pushed the develop branch 2 times, most recently from 6ae7c6b to 9c2857d Compare May 5, 2022 05:51
@jekutzsche jekutzsche force-pushed the develop branch 2 times, most recently from 1f556c6 to eef57e6 Compare June 8, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants