From d50a9b156b80d4ccb83810ff1cf1bb9f21bee7ed Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sun, 14 Feb 2021 21:13:53 +0100
Subject: [PATCH 01/22] [scriptassist2] init

---
 scripts/scriptassist2.pl | 266 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 266 insertions(+)
 create mode 100644 scripts/scriptassist2.pl

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
new file mode 100644
index 000000000..6e3327ae6
--- /dev/null
+++ b/scripts/scriptassist2.pl
@@ -0,0 +1,266 @@
+use strict;
+use vars qw($VERSION %IRSSI);
+use utf8;
+use POSIX;
+use File::Glob qw/:bsd_glob/;
+use CPAN::Meta::YAML;
+use File::Fetch;
+use Time::Piece;
+use Digest::file qw/digest_file_hex/;
+use Storable qw/store_fd fd_retrieve freeze thaw/;
+use debug;
+
+use Irssi;
+
+$VERSION = '0.01';
+%IRSSI = (
+    authors	=> 'bw1',
+    contact	=> 'bw1@aol.at',
+    name	=> 'scriptassist2',
+    description	=> 'This script really does nothing. Sorry.',
+    license	=> 'lgpl',
+    url		=> 'https://scripts.irssi.org/',
+    changed	=> '2021-02-13',
+    modules => '',
+    commands=> 'scriptassist2',
+);
+
+my $help = << "END";
+%9Name%9
+  $IRSSI{name}
+%9Version%9
+  $VERSION
+%9description%9
+  $IRSSI{description}
+%9See also%9
+  https://perldoc.perl.org/perl.html
+  https://github.com/irssi/irssi/blob/master/docs/perl.txt
+  https://github.com/irssi/irssi/blob/master/docs/signals.txt
+  https://github.com/irssi/irssi/blob/master/docs/formats.txt
+END
+
+# config path
+my $path;
+
+# data root
+my $d;
+# ->{rconfig}->@
+# ->{rscripts}
+# ->{rstat}
+
+my %bg_process= ();
+
+sub background {
+	my ($cmd) =@_;
+	my ($fh_r, $fh_w);
+	pipe $fh_r, $fh_w;
+	my $pid = fork();
+	if ($pid ==0 ) {
+		my @res;
+		@res= &{$cmd->{cmd}}(@{$cmd->{args}});
+		#store_fd \@res, $fh_w;
+		my $yml=CPAN::Meta::YAML->new(\@res);
+		print $fh_w $yml->write_string();
+		close $fh_w;
+		POSIX::_exit(1);
+	} else {
+		$cmd->{fh_r}=$fh_r;
+		$bg_process{$pid}=$cmd;
+		#Irssi::pidwait_add($pid);
+		my $pipetag;
+        my @args = ($pid, \$pipetag );
+        $pipetag = Irssi::input_add(fileno($fh_r), INPUT_READ, \&sig_pidwait, \@args);
+	}
+}
+
+sub sig_pidwait {
+	#my ($pid, $status) = @_;
+	my ($pid, $pipetag) = @{@_[0]};
+	if (exists $bg_process{$pid}) {
+		#my @res= @{ fd_retrieve($bg_process{$pid}->{fh_r})};
+		my $fh_r= $bg_process{$pid}->{fh_r};
+		my $ystr = do { local $/; <$fh_r>; };
+		close $fh_r;
+    	Irssi::input_remove($$pipetag);
+		my $yml = CPAN::Meta::YAML->read_string($ystr);
+		my @res = @{ $yml->[0] };
+		$bg_process{$pid}->{res}=[@res];
+		if (exists $bg_process{$pid}->{last}) {
+			foreach my $p (@{$bg_process{$pid}->{last}}) {
+				&$p($bg_process{$pid});
+			}
+		} else {
+			Irssi::print(join(" ",@res), MSGLEVEL_CLIENTCRAP);
+		}
+		delete $bg_process{$pid};
+	}
+}
+
+sub print_box {
+	my ( $head,  $foot, @inside)=@_;
+	Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_header', $head); 
+	foreach my $n ( @inside ) {
+		foreach ( split /\n/, $n ) {
+			#Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_inside', $_); 
+			Irssi::print("%R|%n $_", MSGLEVEL_CLIENTCRAP); 
+		}
+	}
+	Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_footer', $foot); 
+}
+
+sub init {
+	if ( -e "$path/cache.yml" ) {
+		my $yml= CPAN::Meta::YAML->read("$path/cache.yml");
+		$d= $yml->[0];
+	}
+		
+	if (! exists $d->{rconfig} ) {
+		$d->{rconfig}=();
+		my %n;
+		$n{name}="irssi";
+		$n{type}="yaml";
+		$n{url_db}="https://scripts.irssi.org/scripts.yml";
+		$n{url_sc}="https://scripts.irssi.org/scripts";
+		push @{$d->{rconfig}}, {%n};
+	}
+}
+
+sub save {
+	my $yml= CPAN::Meta::YAML->new( $d );
+	$yml->write("$path/cache.yml");
+}
+
+sub fetch {
+	my ($uri)= @_;
+	my $ff = File::Fetch->new (
+		uri => $uri,
+	);
+	my $w= $ff->fetch(to => $path,);
+	if ( $w ) {
+		return $ff->file;
+	} else {
+		return undef;
+	}
+}
+
+sub update {
+	foreach my $n ( @{ $d->{rconfig} } ) {
+		my $fn=fetch( $n->{url_db} );
+		if ( defined $fn && $n->{type} eq 'yaml' ) {
+			my $di=digest_file_hex("$path/$fn", 'MD5');
+			if ( $di ne $d->{rstat}->{$n->{name}}->{digest} ) {
+				my $yml= CPAN::Meta::YAML->read("$path/$fn");
+				my $sl;
+				foreach my $sn ( @{$yml->[0]} ) {
+					$sl->{$sn->{filename}}=$sn;
+				}
+				$d->{rscripts}->{$n->{name}}= $sl;
+			}
+			my $t=localtime();
+			$d->{rstat}->{$n->{name}}->{last}= $t->epoch;
+			$d->{rstat}->{$n->{name}}->{digest}= $di; 
+			unlink "$path/$fn";
+		}
+	}
+	#my $ser = freeze $d;
+	#return $ser;
+	return $d;
+	#return "hello from uptate";
+}
+
+sub print_update {
+	my ( $pn ) = @_;
+	debug "func hallo";
+	#debug $pn->{res};
+}
+
+sub cmd_reload {
+	my ($args, $server, $witem)=@_;
+	init();
+}
+
+sub cmd_save {
+	my ($args, $server, $witem)=@_;
+	save();
+}
+
+sub cmd_update {
+	my ($args, $server, $witem)=@_;
+	my $ser=update();
+	debug "fine", length $ser;
+}
+
+sub cmd {
+	my ($args, $server, $witem)=@_;
+	if ($args =~ m/^reload/) {
+		cmd_reload( $args, $server, $witem);
+	} elsif ($args =~ m/^save/) {
+		cmd_save( $args, $server, $witem);
+	} elsif ($args eq 'update') {
+		background({ 
+			cmd => \&update,
+			last => [ \&print_update ],
+		});
+	} elsif ($args =~ m/^update2/) {
+		cmd_update( $args, $server, $witem);
+	} else {
+		$args= $IRSSI{name};
+		cmd_help( $args, $server, $witem);
+	}
+	#if (defined $witem) {
+	#	$witem->printformat(MSGLEVEL_CLIENTCRAP, 'example_theme',
+	#		$path, $path, $path);
+	#} else {
+	#	Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'example_theme',
+	#		$path, $path, $path);
+	#}
+}
+
+sub cmd_help {
+	my ($args, $server, $witem)=@_;
+	$args=~ s/\s+//g;
+	if ($IRSSI{name} eq $args) {
+		print_box($IRSSI{name}, "$IRSSI{name} help", $help);
+		#Irssi::print($help, MSGLEVEL_CLIENTCRAP);
+		Irssi::signal_stop();
+	}
+}
+
+sub sig_setup_changed {
+	$path= Irssi::settings_get_str($IRSSI{name}.'_path');
+	if ( $path =~ m/^[~\.]/ ) {
+		$path = bsd_glob($path);
+	} elsif ($path !~ m#^/# ) {
+		$path= Irssi::get_irssi_dir()."/$path";
+	}
+	if ( !-e $path ) {
+		mkdir $path;
+	}
+
+}
+
+sub UNLOAD {
+	save();
+}
+
+Irssi::theme_register([
+	#'example_theme', '{hilight $0} $1 {error $2}',
+	'box_header', '%R,--[%n$*%R]%n',
+	#'box_inside', '%R|%n $*',
+	'box_footer', '%R`--<%n$*%R>->%n',
+]);
+
+Irssi::signal_add('setup changed', \&sig_setup_changed);
+#Irssi::signal_add('pidwait', \&sig_pidwait);
+
+Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
+
+Irssi::command_bind($IRSSI{name}, \&cmd);
+my @cmds= qw/reload save update help/;
+foreach ( @cmds ) {
+	Irssi::command_bind("$IRSSI{name} $_", \&cmd);
+}
+Irssi::command_bind('help', \&cmd_help);
+
+sig_setup_changed();
+init();

From 1144207c49130d645093294393787e9d4542dffb Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sun, 14 Feb 2021 22:33:26 +0100
Subject: [PATCH 02/22] pipe

---
 scripts/scriptassist2.pl | 40 +++++++++++++++++++++++++++-------------
 1 file changed, 27 insertions(+), 13 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 6e3327ae6..4d1676a39 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -60,29 +60,43 @@ sub background {
 		@res= &{$cmd->{cmd}}(@{$cmd->{args}});
 		#store_fd \@res, $fh_w;
 		my $yml=CPAN::Meta::YAML->new(\@res);
+		#my $fh_old = select $fh_w;
+		#local $|=1;
+		#select $fh_old;
 		print $fh_w $yml->write_string();
 		close $fh_w;
 		POSIX::_exit(1);
 	} else {
 		$cmd->{fh_r}=$fh_r;
-		$bg_process{$pid}=$cmd;
-		#Irssi::pidwait_add($pid);
 		my $pipetag;
         my @args = ($pid, \$pipetag );
-        $pipetag = Irssi::input_add(fileno($fh_r), INPUT_READ, \&sig_pidwait, \@args);
+        $pipetag = Irssi::input_add(fileno($fh_r), Irssi::INPUT_READ, \&sig_pipe, \@args);
+		$cmd->{pipetag} = $pipetag;
+		$bg_process{$pid}=$cmd;
+		Irssi::pidwait_add($pid);
+	}
+}
+
+sub sig_pipe {
+	my ($pid, $pipetag) = @{$_[0]};
+	debug "sig_pipe $pid";
+	#debug \%bg_process;
+	if (exists $bg_process{$pid}) {
+		my $fh_r= $bg_process{$pid}->{fh_r};
+		$bg_process{$pid}->{res_str} .= do { local $/; <$fh_r>; };
+	} else {
+		Irssi::input_remove($$pipetag);
 	}
 }
 
 sub sig_pidwait {
-	#my ($pid, $status) = @_;
-	my ($pid, $pipetag) = @{@_[0]};
+	my ($pid, $status) = @_;
+	debug "sig_pidwait $pid";
 	if (exists $bg_process{$pid}) {
 		#my @res= @{ fd_retrieve($bg_process{$pid}->{fh_r})};
-		my $fh_r= $bg_process{$pid}->{fh_r};
-		my $ystr = do { local $/; <$fh_r>; };
-		close $fh_r;
-    	Irssi::input_remove($$pipetag);
-		my $yml = CPAN::Meta::YAML->read_string($ystr);
+		close $bg_process{$pid}->{fh_r};
+		Irssi::input_remove($bg_process{$pid}->{pipetag});
+		my $yml = CPAN::Meta::YAML->read_string($bg_process{$pid}->{res_str});
 		my @res = @{ $yml->[0] };
 		$bg_process{$pid}->{res}=[@res];
 		if (exists $bg_process{$pid}->{last}) {
@@ -164,8 +178,8 @@ sub update {
 	}
 	#my $ser = freeze $d;
 	#return $ser;
-	return $d;
-	#return "hello from uptate";
+	#return $d;
+	return "hello from uptate";
 }
 
 sub print_update {
@@ -251,7 +265,7 @@ sub UNLOAD {
 ]);
 
 Irssi::signal_add('setup changed', \&sig_setup_changed);
-#Irssi::signal_add('pidwait', \&sig_pidwait);
+Irssi::signal_add('pidwait', \&sig_pidwait);
 
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
 

From 2e1c19dadd1b5522d5c1141a3b988e0563bb2d7c Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Tue, 16 Feb 2021 06:48:26 +0100
Subject: [PATCH 03/22] info

---
 scripts/scriptassist2.pl | 206 ++++++++++++++++++++++++++++++---------
 1 file changed, 158 insertions(+), 48 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 4d1676a39..79576febf 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -7,7 +7,8 @@
 use File::Fetch;
 use Time::Piece;
 use Digest::file qw/digest_file_hex/;
-use Storable qw/store_fd fd_retrieve freeze thaw/;
+use Digest::MD5 qw/md5_hex/;
+use Text::Wrap;
 use debug;
 
 use Irssi;
@@ -32,6 +33,33 @@
   $VERSION
 %9description%9
   $IRSSI{description}
+%9commands%9
+  /scriptassist check
+      Check all loaded scripts for new available versions
+  /scriptassist update <script|all>
+      Update the selected or all script to the newest version
+  /scriptassist search <query>
+      Search the script database
+  /scriptassist info <scripts>
+      Display information about <scripts>
+  /scriptassist ratings <scripts|all>
+      Retrieve the average ratings of the the scripts
+  /scriptassist top <num>
+      Retrieve the first <num> top rated scripts
+  /scriptassist new <num>
+      Display the newest <num> scripts
+  /scriptassist rate <script>
+      Rate the script if you like it
+  /scriptassist contact <script>
+      Write an email to the author of the script
+      (Requires OpenURL)
+  /scriptassist cpan <module>
+      Visit CPAN to look for missing Perl modules
+      (Requires OpenURL)
+  /scriptassist install <script>
+      Retrieve and load the script
+  /scriptassist autorun <script>
+      Toggles automatic loading of <script>
 %9See also%9
   https://perldoc.perl.org/perl.html
   https://github.com/irssi/irssi/blob/master/docs/perl.txt
@@ -45,8 +73,11 @@ END
 # data root
 my $d;
 # ->{rconfig}->@
-# ->{rscripts}
-# ->{rstat}
+# ->{rscripts}->%
+# ->{rstat}->%
+
+# links to $d->{rconfig}->@
+my %source;
 
 my %bg_process= ();
 
@@ -58,11 +89,7 @@ sub background {
 	if ($pid ==0 ) {
 		my @res;
 		@res= &{$cmd->{cmd}}(@{$cmd->{args}});
-		#store_fd \@res, $fh_w;
 		my $yml=CPAN::Meta::YAML->new(\@res);
-		#my $fh_old = select $fh_w;
-		#local $|=1;
-		#select $fh_old;
 		print $fh_w $yml->write_string();
 		close $fh_w;
 		POSIX::_exit(1);
@@ -80,11 +107,9 @@ sub background {
 sub sig_pipe {
 	my ($pid, $pipetag) = @{$_[0]};
 	debug "sig_pipe $pid";
-	#debug \%bg_process;
 	if (exists $bg_process{$pid}) {
 		my $fh_r= $bg_process{$pid}->{fh_r};
 		$bg_process{$pid}->{res_str} .= do { local $/; <$fh_r>; };
-	} else {
 		Irssi::input_remove($$pipetag);
 	}
 }
@@ -93,9 +118,9 @@ sub sig_pidwait {
 	my ($pid, $status) = @_;
 	debug "sig_pidwait $pid";
 	if (exists $bg_process{$pid}) {
-		#my @res= @{ fd_retrieve($bg_process{$pid}->{fh_r})};
 		close $bg_process{$pid}->{fh_r};
 		Irssi::input_remove($bg_process{$pid}->{pipetag});
+		utf8::decode($bg_process{$pid}->{res_str});
 		my $yml = CPAN::Meta::YAML->read_string($bg_process{$pid}->{res_str});
 		my @res = @{ $yml->[0] };
 		$bg_process{$pid}->{res}=[@res];
@@ -122,13 +147,19 @@ sub print_box {
 	Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_footer', $foot); 
 }
 
+sub print_short {
+	my ( $str )= @_;
+	Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'short_msg', $str); 
+}
+
 sub init {
 	if ( -e "$path/cache.yml" ) {
 		my $yml= CPAN::Meta::YAML->read("$path/cache.yml");
 		$d= $yml->[0];
 	}
 		
-	if (! exists $d->{rconfig} ) {
+	if ( ref($d) ne 'HASH' || ! exists $d->{rconfig} ) {
+		$d= undef;
 		$d->{rconfig}=();
 		my %n;
 		$n{name}="irssi";
@@ -137,6 +168,10 @@ sub init {
 		$n{url_sc}="https://scripts.irssi.org/scripts";
 		push @{$d->{rconfig}}, {%n};
 	}
+
+	foreach my $n ( @{ $d->{rconfig} } ) {
+		$source{$n->{name}}= $n;
+	}
 }
 
 sub save {
@@ -149,7 +184,8 @@ sub fetch {
 	my $ff = File::Fetch->new (
 		uri => $uri,
 	);
-	my $w= $ff->fetch(to => $path,);
+	my $w;
+	eval { $w = $ff->fetch(to => $path,); };
 	if ( $w ) {
 		return $ff->file;
 	} else {
@@ -158,76 +194,148 @@ sub fetch {
 }
 
 sub update {
+	my @msg;
 	foreach my $n ( @{ $d->{rconfig} } ) {
 		my $fn=fetch( $n->{url_db} );
-		if ( defined $fn && $n->{type} eq 'yaml' ) {
-			my $di=digest_file_hex("$path/$fn", 'MD5');
-			if ( $di ne $d->{rstat}->{$n->{name}}->{digest} ) {
-				my $yml= CPAN::Meta::YAML->read("$path/$fn");
-				my $sl;
-				foreach my $sn ( @{$yml->[0]} ) {
-					$sl->{$sn->{filename}}=$sn;
+		if ( defined $fn ) {
+			if ( $n->{type} eq 'yaml' ) {
+				my $di=digest_file_hex("$path/$fn", 'MD5');
+				if ( $di ne $d->{rstat}->{$n->{name}}->{digest} ) {
+					my $yml= CPAN::Meta::YAML->read("$path/$fn");
+					my $sl;
+					foreach my $sn ( @{$yml->[0]} ) {
+						$sl->{$sn->{filename}}=$sn;
+					}
+					$d->{rscripts}->{$n->{name}}= $sl;
 				}
-				$d->{rscripts}->{$n->{name}}= $sl;
+				my $t=localtime();
+				$d->{rstat}->{$n->{name}}->{last}= $t->epoch;
+				$d->{rstat}->{$n->{name}}->{digest}= $di; 
+				unlink "$path/$fn";
 			}
-			my $t=localtime();
-			$d->{rstat}->{$n->{name}}->{last}= $t->epoch;
-			$d->{rstat}->{$n->{name}}->{digest}= $di; 
-			unlink "$path/$fn";
+		} else {
+			push @msg, "Error: fetch $n->{name} ($n->{url_db})";
 		}
 	}
-	#my $ser = freeze $d;
-	#return $ser;
-	#return $d;
-	return "hello from uptate";
+	return $d, [@msg] ;
 }
 
 sub print_update {
 	my ( $pn ) = @_;
-	debug "func hallo";
-	#debug $pn->{res};
+	# write back to main!
+	$d= $pn->{res}->[0] ;
+	foreach my $n ( @{ $d->{rconfig} } ) {
+		$source{$n->{name}}= $n;
+	}
+	foreach my $s (@{$pn->{res}->[1]} ) {
+		print_short $s; 
+	}
+	print_short "database cache updatet"; 
 }
 
 sub cmd_reload {
 	my ($args, $server, $witem)=@_;
 	init();
+	print_short "reloadet"; 
 }
 
 sub cmd_save {
 	my ($args, $server, $witem)=@_;
 	save();
+	print_short "write to disk"; 
 }
 
-sub cmd_update {
-	my ($args, $server, $witem)=@_;
-	my $ser=update();
-	debug "fine", length $ser;
+# o scriptassist
+#   Version    : 2020042700
+#   Source     : https://scripts.irssi.org/
+#   Installed  : 2020042700
+#   Autorun    : no
+#   Authors    : Stefan 'tommie' Tomanek
+#   Contact    : stefan@pico.ruhr.de
+#   Description: keeps your scripts on the cutting edge
+# 
+#   Needed Perl modules:
+#   -> LWP::UserAgent (found)
+
+sub sinfo {
+	my ( $nl, $name, $value)=@_;
+	my $v;
+	{
+		local $Text::Wrap::columns = 60;
+		local $Text::Wrap::unexpand= 0;
+		$v =wrap('', ' 'x($nl+2+2), $value);
+	}
+	return sprintf "  %-${nl}s: %s", $name, $v;
+}
+
+sub installed_version {
+	my ( $scriptname )= @_;
+	my $r;
+	no strict 'refs';
+	#debug keys (%Irssi::Script::);
+	$r = ${ "Irssi::Script::${scriptname}::VERSION" };
+	return $r;
+}
+
+sub autorun {
+	my ( $filename )= @_;
+	my $r;
+	if ( -e Irssi::get_irssi_dir()."/scripts/autorun/$filename" ) {
+		$r=1;
+	}
+	return $r;
+}
+
+sub cmd_info {
+	my ($args, $server, $witem, @args)=@_;
+	my @r;
+	foreach my $sn ( @args ) {
+		my $fn=$sn;
+		$fn =~ s/$/\.pl/ if ( $sn !~ m/\.pl$/ );
+		foreach my $sl ( keys %{ $d->{rscripts} } ) {
+			if ( exists $d->{rscripts}->{$sl}->{$fn} ) {
+				my $n=$d->{rscripts}->{$sl}->{$fn};
+				my $iver=installed_version($sn);
+				if ( defined $iver ) {
+					push @r, "%go%n $sn";
+				} else {
+					push @r, "%ro%n $sn";
+				}
+				push @r, sinfo 11, "Version", $n->{version};
+				push @r, sinfo 11, "Source", $source{$sl}->{url_sc};
+				push @r, sinfo 11, "Installed", $iver if (defined $iver);
+				if ( defined $iver ) {
+					push @r, sinfo 11, "Autorun", autorun($fn) ? "yes" : "no";
+				}
+				push @r, sinfo 11, "Authors", $n->{authors};
+				push @r, sinfo 11, "Contact", $n->{contact};
+				push @r, sinfo 11, "Description", $n->{description};
+			}
+		}
+	}
+	print_box($IRSSI{name},"info", @r);
 }
 
 sub cmd {
 	my ($args, $server, $witem)=@_;
-	if ($args =~ m/^reload/) {
+	my @args = split /\s+/, $args;
+	my $c = shift @args;
+	if ($c eq 'reload') {
 		cmd_reload( $args, $server, $witem);
-	} elsif ($args =~ m/^save/) {
+	} elsif ($c eq 'save') {
 		cmd_save( $args, $server, $witem);
-	} elsif ($args eq 'update') {
+	} elsif ($c eq 'update') {
+		print_short "Please wait..."; 
 		background({ 
 			cmd => \&update,
 			last => [ \&print_update ],
 		});
-	} elsif ($args =~ m/^update2/) {
-		cmd_update( $args, $server, $witem);
+	} elsif ($c eq 'info') {
+		cmd_info( $args, $server, $witem, @args);
 	} else {
 		$args= $IRSSI{name};
 		cmd_help( $args, $server, $witem);
 	}
-	#if (defined $witem) {
-	#	$witem->printformat(MSGLEVEL_CLIENTCRAP, 'example_theme',
-	#		$path, $path, $path);
-	#} else {
-	#	Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'example_theme',
-	#		$path, $path, $path);
-	#}
 }
 
 sub cmd_help {
@@ -235,7 +343,6 @@ sub cmd_help {
 	$args=~ s/\s+//g;
 	if ($IRSSI{name} eq $args) {
 		print_box($IRSSI{name}, "$IRSSI{name} help", $help);
-		#Irssi::print($help, MSGLEVEL_CLIENTCRAP);
 		Irssi::signal_stop();
 	}
 }
@@ -262,6 +369,7 @@ sub UNLOAD {
 	'box_header', '%R,--[%n$*%R]%n',
 	#'box_inside', '%R|%n $*',
 	'box_footer', '%R`--<%n$*%R>->%n',
+	'short_msg', '%R>>%n $*',
 ]);
 
 Irssi::signal_add('setup changed', \&sig_setup_changed);
@@ -270,7 +378,7 @@ sub UNLOAD {
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
 
 Irssi::command_bind($IRSSI{name}, \&cmd);
-my @cmds= qw/reload save update help/;
+my @cmds= qw/reload save update info help/;
 foreach ( @cmds ) {
 	Irssi::command_bind("$IRSSI{name} $_", \&cmd);
 }
@@ -278,3 +386,5 @@ sub UNLOAD {
 
 sig_setup_changed();
 init();
+
+Irssi::print "%B>>%n $IRSSI{name} $VERSION loaded: /$IRSSI{name} help for help", MSGLEVEL_CLIENTCRAP;

From 94af2ebaae970d3780e4f13dcd21cf9a828715b5 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Wed, 17 Feb 2021 06:47:45 +0100
Subject: [PATCH 04/22] search

---
 scripts/scriptassist2.pl | 97 ++++++++++++++++++++++++++++++++++------
 1 file changed, 83 insertions(+), 14 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 79576febf..663a38f54 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -67,6 +67,21 @@
   https://github.com/irssi/irssi/blob/master/docs/formats.txt
 END
 
+# TODO
+#
+#  /scriptassist check
+#  /scriptassist update <script|all>
+#  		update != upgrade
+#  /scriptassist new <num>
+#  /scriptassist contact <script>
+#  /scriptassist cpan <module>
+#  /scriptassist install <script>
+#  /scriptassist autorun <script>
+#
+#  /scriptassist rate <script>
+#  /scriptassist ratings <scripts|all>
+#  /scriptassist top <num>
+
 # config path
 my $path;
 
@@ -245,18 +260,6 @@ sub cmd_save {
 	print_short "write to disk"; 
 }
 
-# o scriptassist
-#   Version    : 2020042700
-#   Source     : https://scripts.irssi.org/
-#   Installed  : 2020042700
-#   Autorun    : no
-#   Authors    : Stefan 'tommie' Tomanek
-#   Contact    : stefan@pico.ruhr.de
-#   Description: keeps your scripts on the cutting edge
-# 
-#   Needed Perl modules:
-#   -> LWP::UserAgent (found)
-
 sub sinfo {
 	my ( $nl, $name, $value)=@_;
 	my $v;
@@ -277,7 +280,16 @@ sub installed_version {
 	return $r;
 }
 
-sub autorun {
+sub module_exist {
+	my ($module) = @_;
+	$module =~ s/::/\//g;
+	foreach (@INC) {
+		return 1 if (-e $_."/".$module.".pm");
+	}
+	return 0;
+}
+
+sub check_autorun {
 	my ( $filename )= @_;
 	my $r;
 	if ( -e Irssi::get_irssi_dir()."/scripts/autorun/$filename" ) {
@@ -305,17 +317,72 @@ sub cmd_info {
 				push @r, sinfo 11, "Source", $source{$sl}->{url_sc};
 				push @r, sinfo 11, "Installed", $iver if (defined $iver);
 				if ( defined $iver ) {
-					push @r, sinfo 11, "Autorun", autorun($fn) ? "yes" : "no";
+					push @r, sinfo 11, "Autorun", check_autorun($fn) ? "yes" : "no";
 				}
 				push @r, sinfo 11, "Authors", $n->{authors};
 				push @r, sinfo 11, "Contact", $n->{contact};
 				push @r, sinfo 11, "Description", $n->{description};
+				if ( exists $n->{modules} ) {
+					push @r, " ";
+					push @r, "  Needed Perl modules:";
+					foreach my $m ( sort split /\s+/, $n->{modules} ) {
+						if ( module_exist $m ) {
+							push @r, "   %g->%n $m (found)";
+						} else {
+							push @r, "   %r->%n $m (not found)";
+						}
+					}
+				}
+				if ( exists $n->{depends} ) {
+					push @r, " ";
+					push @r, "  Needed Irssi Scripts:";
+					foreach my $d ( sort split /\s+/, $n->{depends} ) {
+						if ( installed_version $d ) {
+							push @r, "   %g->%n $d (loaded)";
+						} else {
+							push @r, "   %r->%n $d (not loaded)";
+						}
+					}
+				}
 			}
 		}
 	}
 	print_box($IRSSI{name},"info", @r);
 }
 
+sub oneline_info {
+	my ( $search, $name, $desc, $aut )=@_;
+	my $d;
+	my $l= length( $name) +3;
+	{
+		local $Text::Wrap::columns = 60;
+		local $Text::Wrap::unexpand= 0;
+		$d =wrap('', ' 'x$l, "$desc ($aut)");
+	}
+	my $p= (installed_version $name) ? "%go%n " : "%yo%n ";
+	my $s= "$name $d";
+	$s =~ s/($search)/%U\1%n/i;
+	return $p.$s;
+}
+
+sub cmd_search {
+	my ($args, $server, $witem, @args)=@_;
+	my @r;
+	foreach my $sk ( keys %{ $d->{rscripts} }) {
+		foreach my $fn ( sort keys %{ $d->{rscripts}->{$sk} } ) {
+		my $n= $d->{rscripts}->{$sk}->{$fn};
+			if ( $fn =~ m/$args[0]/i ||
+				$n->{name} =~ m/$args[0]/i ||
+				$n->{description} =~ m/$args[0]/i ) {
+				my $sn= $fn;
+				$sn=~ s/\.pl$//;
+				push @r, oneline_info( $args[0], $sn, $n->{description}, $n->{authors});
+			}
+		}
+	}
+	print_box($IRSSI{name},"search", @r);
+}
+
 sub cmd {
 	my ($args, $server, $witem)=@_;
 	my @args = split /\s+/, $args;
@@ -332,6 +399,8 @@ sub cmd {
 		});
 	} elsif ($c eq 'info') {
 		cmd_info( $args, $server, $witem, @args);
+	} elsif ($c eq 'search') {
+		cmd_search( $args, $server, $witem, @args);
 	} else {
 		$args= $IRSSI{name};
 		cmd_help( $args, $server, $witem);

From aa27ea1877e96a772d4cb95d700351fee161b907 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Wed, 17 Feb 2021 21:57:44 +0100
Subject: [PATCH 05/22] check

---
 scripts/scriptassist2.pl | 58 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 56 insertions(+), 2 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 663a38f54..0fc96c74d 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -69,7 +69,6 @@ END
 
 # TODO
 #
-#  /scriptassist check
 #  /scriptassist update <script|all>
 #  		update != upgrade
 #  /scriptassist new <num>
@@ -383,6 +382,59 @@ sub cmd_search {
 	print_box($IRSSI{name},"search", @r);
 }
 
+sub compare_versions {
+	my ($ver1, $ver2) = @_;
+	for ($ver1, $ver2) {
+		$_ = "0:$_" unless /:/;
+	}
+	my @ver1 = split /[.:]/, $ver1;
+	my @ver2 = split /[.:]/, $ver2;
+	my $cmp = 0;
+	### Special thanks to Clemens Heidinger
+	no warnings 'uninitialized';
+	$cmp ||= $ver1[$_] <=> $ver2[$_] || $ver1[$_] cmp $ver2[$_] for 0..scalar(@ver2);
+	return 'newer' if $cmp == 1;
+	return 'older' if $cmp == -1;
+	return 'equal';
+}
+
+sub cmd_check {
+	my ($args, $server, $witem)=@_;
+	my @res;
+	my @sn;
+	my $lm;
+	foreach my $sn (keys %Irssi::Script:: ) {
+		$sn =~ s/:+$//;
+		$lm = length $sn if ( $lm < length $sn);
+		push @sn, $sn;
+	}
+	foreach my $sn (sort @sn ) {
+		my $v = installed_version $sn;
+		my $rv;
+		foreach my $sk ( keys %{ $d->{rscripts} } ) {
+			my $fn = "$sn.pl";
+			if ( exists $d->{rscripts}->{$sk}->{$fn} ) {
+				$rv= $d->{rscripts}->{$sk}->{$fn}->{version};
+			}
+		}
+		my $s;
+		if ( defined $rv ) {
+			my $r= compare_versions $v, $rv;
+			if ( $r eq 'equal' ) {
+				$s = sprintf "%%go%%n %%9%-${lm}s%%9 Up to date. ($v)", $sn;
+			} elsif ( $r eq 'newer') {
+				$s = sprintf "%%bo%%n %%9%-${lm}s%%9 Your version is newer ($v->$rv)", $sn;
+			} elsif ( $r eq 'older') {
+				$s = sprintf "%%ro%%n %%9%-${lm}s%%9 A new version is available ($v->$rv)", $sn;
+			}
+		} else {
+			$s = sprintf "%%mo%%n %%9%-${lm}s%%9 No version information available on network.", $sn;
+		}
+		push @res, $s;
+	}
+	print_box($IRSSI{name},"check", @res);
+}
+
 sub cmd {
 	my ($args, $server, $witem)=@_;
 	my @args = split /\s+/, $args;
@@ -401,6 +453,8 @@ sub cmd {
 		cmd_info( $args, $server, $witem, @args);
 	} elsif ($c eq 'search') {
 		cmd_search( $args, $server, $witem, @args);
+	} elsif ($c eq 'check') {
+		cmd_check( $args, $server, $witem);
 	} else {
 		$args= $IRSSI{name};
 		cmd_help( $args, $server, $witem);
@@ -447,7 +501,7 @@ sub UNLOAD {
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
 
 Irssi::command_bind($IRSSI{name}, \&cmd);
-my @cmds= qw/reload save update info help/;
+my @cmds= qw/reload save update info search check help/;
 foreach ( @cmds ) {
 	Irssi::command_bind("$IRSSI{name} $_", \&cmd);
 }

From dbda9e74f988415b3364a98a9d42bbbf9f3dc356 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Thu, 18 Feb 2021 18:20:53 +0100
Subject: [PATCH 06/22] format

---
 scripts/scriptassist2.pl | 656 +++++++++++++++++++--------------------
 1 file changed, 328 insertions(+), 328 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 0fc96c74d..89ea921b3 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -15,13 +15,13 @@
 
 $VERSION = '0.01';
 %IRSSI = (
-    authors	=> 'bw1',
-    contact	=> 'bw1@aol.at',
-    name	=> 'scriptassist2',
-    description	=> 'This script really does nothing. Sorry.',
-    license	=> 'lgpl',
-    url		=> 'https://scripts.irssi.org/',
-    changed	=> '2021-02-13',
+    authors => 'bw1',
+    contact => 'bw1@aol.at',
+    name => 'scriptassist2',
+    description   => 'This script really does nothing. Sorry.',
+    license => 'lgpl',
+    url     => 'https://scripts.irssi.org/',
+    changed => '2021-02-13',
     modules => '',
     commands=> 'scriptassist2',
 );
@@ -70,7 +70,7 @@ END
 # TODO
 #
 #  /scriptassist update <script|all>
-#  		update != upgrade
+#        update != upgrade
 #  /scriptassist new <num>
 #  /scriptassist contact <script>
 #  /scriptassist cpan <module>
@@ -80,6 +80,7 @@ END
 #  /scriptassist rate <script>
 #  /scriptassist ratings <scripts|all>
 #  /scriptassist top <num>
+#  signature
 
 # config path
 my $path;
@@ -96,403 +97,400 @@ END
 my %bg_process= ();
 
 sub background {
-	my ($cmd) =@_;
-	my ($fh_r, $fh_w);
-	pipe $fh_r, $fh_w;
-	my $pid = fork();
-	if ($pid ==0 ) {
-		my @res;
-		@res= &{$cmd->{cmd}}(@{$cmd->{args}});
-		my $yml=CPAN::Meta::YAML->new(\@res);
-		print $fh_w $yml->write_string();
-		close $fh_w;
-		POSIX::_exit(1);
-	} else {
-		$cmd->{fh_r}=$fh_r;
-		my $pipetag;
+   my ($cmd) =@_;
+   my ($fh_r, $fh_w);
+   pipe $fh_r, $fh_w;
+   my $pid = fork();
+   if ($pid ==0 ) {
+      my @res;
+      @res= &{$cmd->{cmd}}(@{$cmd->{args}});
+      my $yml=CPAN::Meta::YAML->new(\@res);
+      print $fh_w $yml->write_string();
+      close $fh_w;
+      POSIX::_exit(1);
+   } else {
+      $cmd->{fh_r}=$fh_r;
+      my $pipetag;
         my @args = ($pid, \$pipetag );
         $pipetag = Irssi::input_add(fileno($fh_r), Irssi::INPUT_READ, \&sig_pipe, \@args);
-		$cmd->{pipetag} = $pipetag;
-		$bg_process{$pid}=$cmd;
-		Irssi::pidwait_add($pid);
-	}
+      $cmd->{pipetag} = $pipetag;
+      $bg_process{$pid}=$cmd;
+      Irssi::pidwait_add($pid);
+   }
 }
 
 sub sig_pipe {
-	my ($pid, $pipetag) = @{$_[0]};
-	debug "sig_pipe $pid";
-	if (exists $bg_process{$pid}) {
-		my $fh_r= $bg_process{$pid}->{fh_r};
-		$bg_process{$pid}->{res_str} .= do { local $/; <$fh_r>; };
-		Irssi::input_remove($$pipetag);
-	}
+   my ($pid, $pipetag) = @{$_[0]};
+   debug "sig_pipe $pid";
+   if (exists $bg_process{$pid}) {
+      my $fh_r= $bg_process{$pid}->{fh_r};
+      $bg_process{$pid}->{res_str} .= do { local $/; <$fh_r>; };
+      Irssi::input_remove($$pipetag);
+   }
 }
 
 sub sig_pidwait {
-	my ($pid, $status) = @_;
-	debug "sig_pidwait $pid";
-	if (exists $bg_process{$pid}) {
-		close $bg_process{$pid}->{fh_r};
-		Irssi::input_remove($bg_process{$pid}->{pipetag});
-		utf8::decode($bg_process{$pid}->{res_str});
-		my $yml = CPAN::Meta::YAML->read_string($bg_process{$pid}->{res_str});
-		my @res = @{ $yml->[0] };
-		$bg_process{$pid}->{res}=[@res];
-		if (exists $bg_process{$pid}->{last}) {
-			foreach my $p (@{$bg_process{$pid}->{last}}) {
-				&$p($bg_process{$pid});
-			}
-		} else {
-			Irssi::print(join(" ",@res), MSGLEVEL_CLIENTCRAP);
-		}
-		delete $bg_process{$pid};
-	}
+   my ($pid, $status) = @_;
+   debug "sig_pidwait $pid";
+   if (exists $bg_process{$pid}) {
+      close $bg_process{$pid}->{fh_r};
+      Irssi::input_remove($bg_process{$pid}->{pipetag});
+      utf8::decode($bg_process{$pid}->{res_str});
+      my $yml = CPAN::Meta::YAML->read_string($bg_process{$pid}->{res_str});
+      my @res = @{ $yml->[0] };
+      $bg_process{$pid}->{res}=[@res];
+      if (exists $bg_process{$pid}->{last}) {
+         foreach my $p (@{$bg_process{$pid}->{last}}) {
+            &$p($bg_process{$pid});
+         }
+      } else {
+         Irssi::print(join(" ",@res), MSGLEVEL_CLIENTCRAP);
+      }
+      delete $bg_process{$pid};
+   }
 }
 
 sub print_box {
-	my ( $head,  $foot, @inside)=@_;
-	Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_header', $head); 
-	foreach my $n ( @inside ) {
-		foreach ( split /\n/, $n ) {
-			#Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_inside', $_); 
-			Irssi::print("%R|%n $_", MSGLEVEL_CLIENTCRAP); 
-		}
-	}
-	Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_footer', $foot); 
+   my ( $head,  $foot, @inside)=@_;
+   Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_header', $head); 
+   foreach my $n ( @inside ) {
+      foreach ( split /\n/, $n ) {
+         #Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_inside', $_); 
+         Irssi::print("%R|%n $_", MSGLEVEL_CLIENTCRAP); 
+      }
+   }
+   Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_footer', $foot); 
 }
 
 sub print_short {
-	my ( $str )= @_;
-	Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'short_msg', $str); 
+   my ( $str )= @_;
+   Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'short_msg', $str); 
 }
 
 sub init {
-	if ( -e "$path/cache.yml" ) {
-		my $yml= CPAN::Meta::YAML->read("$path/cache.yml");
-		$d= $yml->[0];
-	}
-		
-	if ( ref($d) ne 'HASH' || ! exists $d->{rconfig} ) {
-		$d= undef;
-		$d->{rconfig}=();
-		my %n;
-		$n{name}="irssi";
-		$n{type}="yaml";
-		$n{url_db}="https://scripts.irssi.org/scripts.yml";
-		$n{url_sc}="https://scripts.irssi.org/scripts";
-		push @{$d->{rconfig}}, {%n};
-	}
-
-	foreach my $n ( @{ $d->{rconfig} } ) {
-		$source{$n->{name}}= $n;
-	}
+   if ( -e "$path/cache.yml" ) {
+      my $yml= CPAN::Meta::YAML->read("$path/cache.yml");
+      $d= $yml->[0];
+   }
+      
+   if ( ref($d) ne 'HASH' || ! exists $d->{rconfig} ) {
+      $d= undef;
+      $d->{rconfig}=();
+      my %n;
+      $n{name}="irssi";
+      $n{type}="yaml";
+      $n{url_db}="https://scripts.irssi.org/scripts.yml";
+      $n{url_sc}="https://scripts.irssi.org/scripts";
+      push @{$d->{rconfig}}, {%n};
+   }
+
+   foreach my $n ( @{ $d->{rconfig} } ) {
+      $source{$n->{name}}= $n;
+   }
 }
 
 sub save {
-	my $yml= CPAN::Meta::YAML->new( $d );
-	$yml->write("$path/cache.yml");
+   my $yml= CPAN::Meta::YAML->new( $d );
+   $yml->write("$path/cache.yml");
 }
 
 sub fetch {
-	my ($uri)= @_;
-	my $ff = File::Fetch->new (
-		uri => $uri,
-	);
-	my $w;
-	eval { $w = $ff->fetch(to => $path,); };
-	if ( $w ) {
-		return $ff->file;
-	} else {
-		return undef;
-	}
+   my ($uri)= @_;
+   my $ff = File::Fetch->new (
+      uri => $uri,
+   );
+   my $w;
+   eval { $w = $ff->fetch(to => $path,); };
+   if ( $w ) {
+      return $ff->file;
+   } else {
+      return undef;
+   }
 }
 
 sub update {
-	my @msg;
-	foreach my $n ( @{ $d->{rconfig} } ) {
-		my $fn=fetch( $n->{url_db} );
-		if ( defined $fn ) {
-			if ( $n->{type} eq 'yaml' ) {
-				my $di=digest_file_hex("$path/$fn", 'MD5');
-				if ( $di ne $d->{rstat}->{$n->{name}}->{digest} ) {
-					my $yml= CPAN::Meta::YAML->read("$path/$fn");
-					my $sl;
-					foreach my $sn ( @{$yml->[0]} ) {
-						$sl->{$sn->{filename}}=$sn;
-					}
-					$d->{rscripts}->{$n->{name}}= $sl;
-				}
-				my $t=localtime();
-				$d->{rstat}->{$n->{name}}->{last}= $t->epoch;
-				$d->{rstat}->{$n->{name}}->{digest}= $di; 
-				unlink "$path/$fn";
-			}
-		} else {
-			push @msg, "Error: fetch $n->{name} ($n->{url_db})";
-		}
-	}
-	return $d, [@msg] ;
+   my @msg;
+   foreach my $n ( @{ $d->{rconfig} } ) {
+      my $fn=fetch( $n->{url_db} );
+      if ( defined $fn ) {
+         if ( $n->{type} eq 'yaml' ) {
+            my $di=digest_file_hex("$path/$fn", 'MD5');
+            if ( $di ne $d->{rstat}->{$n->{name}}->{digest} ) {
+               my $yml= CPAN::Meta::YAML->read("$path/$fn");
+               my $sl;
+               foreach my $sn ( @{$yml->[0]} ) {
+                  $sl->{$sn->{filename}}=$sn;
+               }
+               $d->{rscripts}->{$n->{name}}= $sl;
+            }
+            my $t=localtime();
+            $d->{rstat}->{$n->{name}}->{last}= $t->epoch;
+            $d->{rstat}->{$n->{name}}->{digest}= $di; 
+            unlink "$path/$fn";
+         }
+      } else {
+         push @msg, "Error: fetch $n->{name} ($n->{url_db})";
+      }
+   }
+   return $d, [@msg] ;
 }
 
 sub print_update {
-	my ( $pn ) = @_;
-	# write back to main!
-	$d= $pn->{res}->[0] ;
-	foreach my $n ( @{ $d->{rconfig} } ) {
-		$source{$n->{name}}= $n;
-	}
-	foreach my $s (@{$pn->{res}->[1]} ) {
-		print_short $s; 
-	}
-	print_short "database cache updatet"; 
+   my ( $pn ) = @_;
+   # write back to main!
+   $d= $pn->{res}->[0] ;
+   foreach my $n ( @{ $d->{rconfig} } ) {
+      $source{$n->{name}}= $n;
+   }
+   foreach my $s (@{$pn->{res}->[1]} ) {
+      print_short $s; 
+   }
+   print_short "database cache updatet"; 
 }
 
 sub cmd_reload {
-	my ($args, $server, $witem)=@_;
-	init();
-	print_short "reloadet"; 
+   init();
+   print_short "reloadet"; 
 }
 
 sub cmd_save {
-	my ($args, $server, $witem)=@_;
-	save();
-	print_short "write to disk"; 
+   save();
+   print_short "write to disk"; 
 }
 
 sub sinfo {
-	my ( $nl, $name, $value)=@_;
-	my $v;
-	{
-		local $Text::Wrap::columns = 60;
-		local $Text::Wrap::unexpand= 0;
-		$v =wrap('', ' 'x($nl+2+2), $value);
-	}
-	return sprintf "  %-${nl}s: %s", $name, $v;
+   my ( $nl, $name, $value)=@_;
+   my $v;
+   {
+      local $Text::Wrap::columns = 60;
+      local $Text::Wrap::unexpand= 0;
+      $v =wrap('', ' 'x($nl+2+2), $value);
+   }
+   return sprintf "  %-${nl}s: %s", $name, $v;
 }
 
 sub installed_version {
-	my ( $scriptname )= @_;
-	my $r;
-	no strict 'refs';
-	#debug keys (%Irssi::Script::);
-	$r = ${ "Irssi::Script::${scriptname}::VERSION" };
-	return $r;
+   my ( $scriptname )= @_;
+   my $r;
+   no strict 'refs';
+   #debug keys (%Irssi::Script::);
+   $r = ${ "Irssi::Script::${scriptname}::VERSION" };
+   return $r;
 }
 
 sub module_exist {
-	my ($module) = @_;
-	$module =~ s/::/\//g;
-	foreach (@INC) {
-		return 1 if (-e $_."/".$module.".pm");
-	}
-	return 0;
+   my ($module) = @_;
+   $module =~ s/::/\//g;
+   foreach (@INC) {
+      return 1 if (-e $_."/".$module.".pm");
+   }
+   return 0;
 }
 
 sub check_autorun {
-	my ( $filename )= @_;
-	my $r;
-	if ( -e Irssi::get_irssi_dir()."/scripts/autorun/$filename" ) {
-		$r=1;
-	}
-	return $r;
+   my ( $filename )= @_;
+   my $r;
+   if ( -e Irssi::get_irssi_dir()."/scripts/autorun/$filename" ) {
+      $r=1;
+   }
+   return $r;
 }
 
 sub cmd_info {
-	my ($args, $server, $witem, @args)=@_;
-	my @r;
-	foreach my $sn ( @args ) {
-		my $fn=$sn;
-		$fn =~ s/$/\.pl/ if ( $sn !~ m/\.pl$/ );
-		foreach my $sl ( keys %{ $d->{rscripts} } ) {
-			if ( exists $d->{rscripts}->{$sl}->{$fn} ) {
-				my $n=$d->{rscripts}->{$sl}->{$fn};
-				my $iver=installed_version($sn);
-				if ( defined $iver ) {
-					push @r, "%go%n $sn";
-				} else {
-					push @r, "%ro%n $sn";
-				}
-				push @r, sinfo 11, "Version", $n->{version};
-				push @r, sinfo 11, "Source", $source{$sl}->{url_sc};
-				push @r, sinfo 11, "Installed", $iver if (defined $iver);
-				if ( defined $iver ) {
-					push @r, sinfo 11, "Autorun", check_autorun($fn) ? "yes" : "no";
-				}
-				push @r, sinfo 11, "Authors", $n->{authors};
-				push @r, sinfo 11, "Contact", $n->{contact};
-				push @r, sinfo 11, "Description", $n->{description};
-				if ( exists $n->{modules} ) {
-					push @r, " ";
-					push @r, "  Needed Perl modules:";
-					foreach my $m ( sort split /\s+/, $n->{modules} ) {
-						if ( module_exist $m ) {
-							push @r, "   %g->%n $m (found)";
-						} else {
-							push @r, "   %r->%n $m (not found)";
-						}
-					}
-				}
-				if ( exists $n->{depends} ) {
-					push @r, " ";
-					push @r, "  Needed Irssi Scripts:";
-					foreach my $d ( sort split /\s+/, $n->{depends} ) {
-						if ( installed_version $d ) {
-							push @r, "   %g->%n $d (loaded)";
-						} else {
-							push @r, "   %r->%n $d (not loaded)";
-						}
-					}
-				}
-			}
-		}
-	}
-	print_box($IRSSI{name},"info", @r);
+   my ( @args)=@_;
+   my @r;
+   foreach my $sn ( @args ) {
+      my $fn=$sn;
+      $fn =~ s/$/\.pl/ if ( $sn !~ m/\.pl$/ );
+      foreach my $sl ( keys %{ $d->{rscripts} } ) {
+         if ( exists $d->{rscripts}->{$sl}->{$fn} ) {
+            my $n=$d->{rscripts}->{$sl}->{$fn};
+            my $iver=installed_version($sn);
+            if ( defined $iver ) {
+               push @r, "%go%n $sn";
+            } else {
+               push @r, "%ro%n $sn";
+            }
+            push @r, sinfo 11, "Version", $n->{version};
+            push @r, sinfo 11, "Source", $source{$sl}->{url_sc};
+            push @r, sinfo 11, "Installed", $iver if (defined $iver);
+            if ( defined $iver ) {
+               push @r, sinfo 11, "Autorun", check_autorun($fn) ? "yes" : "no";
+            }
+            push @r, sinfo 11, "Authors", $n->{authors};
+            push @r, sinfo 11, "Contact", $n->{contact};
+            push @r, sinfo 11, "Description", $n->{description};
+            if ( exists $n->{modules} ) {
+               push @r, " ";
+               push @r, "  Needed Perl modules:";
+               foreach my $m ( sort split /\s+/, $n->{modules} ) {
+                  if ( module_exist $m ) {
+                     push @r, "   %g->%n $m (found)";
+                  } else {
+                     push @r, "   %r->%n $m (not found)";
+                  }
+               }
+            }
+            if ( exists $n->{depends} ) {
+               push @r, " ";
+               push @r, "  Needed Irssi Scripts:";
+               foreach my $d ( sort split /\s+/, $n->{depends} ) {
+                  if ( installed_version $d ) {
+                     push @r, "   %g->%n $d (loaded)";
+                  } else {
+                     push @r, "   %r->%n $d (not loaded)";
+                  }
+               }
+            }
+         }
+      }
+   }
+   print_box($IRSSI{name},"info", @r);
 }
 
 sub oneline_info {
-	my ( $search, $name, $desc, $aut )=@_;
-	my $d;
-	my $l= length( $name) +3;
-	{
-		local $Text::Wrap::columns = 60;
-		local $Text::Wrap::unexpand= 0;
-		$d =wrap('', ' 'x$l, "$desc ($aut)");
-	}
-	my $p= (installed_version $name) ? "%go%n " : "%yo%n ";
-	my $s= "$name $d";
-	$s =~ s/($search)/%U\1%n/i;
-	return $p.$s;
+   my ( $search, $name, $desc, $aut )=@_;
+   my $d;
+   my $l= length( $name) +3;
+   {
+      local $Text::Wrap::columns = 60;
+      local $Text::Wrap::unexpand= 0;
+      $d =wrap('', ' 'x$l, "$desc ($aut)");
+   }
+   my $p= (installed_version $name) ? "%go%n " : "%yo%n ";
+   my $s= "$name $d";
+   $s =~ s/($search)/%U\1%n/i;
+   return $p.$s;
 }
 
 sub cmd_search {
-	my ($args, $server, $witem, @args)=@_;
-	my @r;
-	foreach my $sk ( keys %{ $d->{rscripts} }) {
-		foreach my $fn ( sort keys %{ $d->{rscripts}->{$sk} } ) {
-		my $n= $d->{rscripts}->{$sk}->{$fn};
-			if ( $fn =~ m/$args[0]/i ||
-				$n->{name} =~ m/$args[0]/i ||
-				$n->{description} =~ m/$args[0]/i ) {
-				my $sn= $fn;
-				$sn=~ s/\.pl$//;
-				push @r, oneline_info( $args[0], $sn, $n->{description}, $n->{authors});
-			}
-		}
-	}
-	print_box($IRSSI{name},"search", @r);
+   my (@args)=@_;
+   my @r;
+   foreach my $sk ( keys %{ $d->{rscripts} }) {
+      foreach my $fn ( sort keys %{ $d->{rscripts}->{$sk} } ) {
+      my $n= $d->{rscripts}->{$sk}->{$fn};
+         if ( $fn =~ m/$args[0]/i ||
+            $n->{name} =~ m/$args[0]/i ||
+            $n->{description} =~ m/$args[0]/i ) {
+            my $sn= $fn;
+            $sn=~ s/\.pl$//;
+            push @r, oneline_info( $args[0], $sn, $n->{description}, $n->{authors});
+         }
+      }
+   }
+   print_box($IRSSI{name},"search", @r);
 }
 
 sub compare_versions {
-	my ($ver1, $ver2) = @_;
-	for ($ver1, $ver2) {
-		$_ = "0:$_" unless /:/;
-	}
-	my @ver1 = split /[.:]/, $ver1;
-	my @ver2 = split /[.:]/, $ver2;
-	my $cmp = 0;
-	### Special thanks to Clemens Heidinger
-	no warnings 'uninitialized';
-	$cmp ||= $ver1[$_] <=> $ver2[$_] || $ver1[$_] cmp $ver2[$_] for 0..scalar(@ver2);
-	return 'newer' if $cmp == 1;
-	return 'older' if $cmp == -1;
-	return 'equal';
+   my ($ver1, $ver2) = @_;
+   for ($ver1, $ver2) {
+      $_ = "0:$_" unless /:/;
+   }
+   my @ver1 = split /[.:]/, $ver1;
+   my @ver2 = split /[.:]/, $ver2;
+   my $cmp = 0;
+   ### Special thanks to Clemens Heidinger
+   no warnings 'uninitialized';
+   $cmp ||= $ver1[$_] <=> $ver2[$_] || $ver1[$_] cmp $ver2[$_] for 0..scalar(@ver2);
+   return 'newer' if $cmp == 1;
+   return 'older' if $cmp == -1;
+   return 'equal';
 }
 
 sub cmd_check {
-	my ($args, $server, $witem)=@_;
-	my @res;
-	my @sn;
-	my $lm;
-	foreach my $sn (keys %Irssi::Script:: ) {
-		$sn =~ s/:+$//;
-		$lm = length $sn if ( $lm < length $sn);
-		push @sn, $sn;
-	}
-	foreach my $sn (sort @sn ) {
-		my $v = installed_version $sn;
-		my $rv;
-		foreach my $sk ( keys %{ $d->{rscripts} } ) {
-			my $fn = "$sn.pl";
-			if ( exists $d->{rscripts}->{$sk}->{$fn} ) {
-				$rv= $d->{rscripts}->{$sk}->{$fn}->{version};
-			}
-		}
-		my $s;
-		if ( defined $rv ) {
-			my $r= compare_versions $v, $rv;
-			if ( $r eq 'equal' ) {
-				$s = sprintf "%%go%%n %%9%-${lm}s%%9 Up to date. ($v)", $sn;
-			} elsif ( $r eq 'newer') {
-				$s = sprintf "%%bo%%n %%9%-${lm}s%%9 Your version is newer ($v->$rv)", $sn;
-			} elsif ( $r eq 'older') {
-				$s = sprintf "%%ro%%n %%9%-${lm}s%%9 A new version is available ($v->$rv)", $sn;
-			}
-		} else {
-			$s = sprintf "%%mo%%n %%9%-${lm}s%%9 No version information available on network.", $sn;
-		}
-		push @res, $s;
-	}
-	print_box($IRSSI{name},"check", @res);
+   my @res;
+   my @sn;
+   my $lm;
+   foreach my $sn (keys %Irssi::Script:: ) {
+      $sn =~ s/:+$//;
+      $lm = length $sn if ( $lm < length $sn);
+      push @sn, $sn;
+   }
+   foreach my $sn (sort @sn ) {
+      my $v = installed_version $sn;
+      my $rv;
+      foreach my $sk ( keys %{ $d->{rscripts} } ) {
+         my $fn = "$sn.pl";
+         if ( exists $d->{rscripts}->{$sk}->{$fn} ) {
+            $rv= $d->{rscripts}->{$sk}->{$fn}->{version};
+         }
+      }
+      my $s;
+      if ( defined $rv ) {
+         my $r= compare_versions $v, $rv;
+         if ( $r eq 'equal' ) {
+            $s = sprintf "%%go%%n %%9%-${lm}s%%9 Up to date. ($v)", $sn;
+         } elsif ( $r eq 'newer') {
+            $s = sprintf "%%bo%%n %%9%-${lm}s%%9 Your version is newer ($v->$rv)", $sn;
+         } elsif ( $r eq 'older') {
+            $s = sprintf "%%ro%%n %%9%-${lm}s%%9 A new version is available ($v->$rv)", $sn;
+         }
+      } else {
+         $s = sprintf "%%mo%%n %%9%-${lm}s%%9 No version information available on network.", $sn;
+      }
+      push @res, $s;
+   }
+   print_box($IRSSI{name},"check", @res);
 }
 
 sub cmd {
-	my ($args, $server, $witem)=@_;
-	my @args = split /\s+/, $args;
-	my $c = shift @args;
-	if ($c eq 'reload') {
-		cmd_reload( $args, $server, $witem);
-	} elsif ($c eq 'save') {
-		cmd_save( $args, $server, $witem);
-	} elsif ($c eq 'update') {
-		print_short "Please wait..."; 
-		background({ 
-			cmd => \&update,
-			last => [ \&print_update ],
-		});
-	} elsif ($c eq 'info') {
-		cmd_info( $args, $server, $witem, @args);
-	} elsif ($c eq 'search') {
-		cmd_search( $args, $server, $witem, @args);
-	} elsif ($c eq 'check') {
-		cmd_check( $args, $server, $witem);
-	} else {
-		$args= $IRSSI{name};
-		cmd_help( $args, $server, $witem);
-	}
+   my ($args, $server, $witem)=@_;
+   my @args = split /\s+/, $args;
+   my $c = shift @args;
+   if ($c eq 'reload') {
+      cmd_reload( );
+   } elsif ($c eq 'save') {
+      cmd_save( );
+   } elsif ($c eq 'update') {
+      print_short "Please wait..."; 
+      background({ 
+         cmd => \&update,
+         last => [ \&print_update ],
+      });
+   } elsif ($c eq 'info') {
+      cmd_info( @args);
+   } elsif ($c eq 'search') {
+      cmd_search( @args);
+   } elsif ($c eq 'check') {
+      cmd_check();
+   } else {
+      $args= $IRSSI{name};
+      cmd_help( $args, $server, $witem);
+   }
 }
 
 sub cmd_help {
-	my ($args, $server, $witem)=@_;
-	$args=~ s/\s+//g;
-	if ($IRSSI{name} eq $args) {
-		print_box($IRSSI{name}, "$IRSSI{name} help", $help);
-		Irssi::signal_stop();
-	}
+   my ($args, $server, $witem)=@_;
+   $args=~ s/\s+//g;
+   if ($IRSSI{name} eq $args) {
+      print_box($IRSSI{name}, "$IRSSI{name} help", $help);
+      Irssi::signal_stop();
+   }
 }
 
 sub sig_setup_changed {
-	$path= Irssi::settings_get_str($IRSSI{name}.'_path');
-	if ( $path =~ m/^[~\.]/ ) {
-		$path = bsd_glob($path);
-	} elsif ($path !~ m#^/# ) {
-		$path= Irssi::get_irssi_dir()."/$path";
-	}
-	if ( !-e $path ) {
-		mkdir $path;
-	}
+   $path= Irssi::settings_get_str($IRSSI{name}.'_path');
+   if ( $path =~ m/^[~\.]/ ) {
+      $path = bsd_glob($path);
+   } elsif ($path !~ m#^/# ) {
+      $path= Irssi::get_irssi_dir()."/$path";
+   }
+   if ( !-e $path ) {
+      mkdir $path;
+   }
 
 }
 
 sub UNLOAD {
-	save();
+   save();
 }
 
 Irssi::theme_register([
-	#'example_theme', '{hilight $0} $1 {error $2}',
-	'box_header', '%R,--[%n$*%R]%n',
-	#'box_inside', '%R|%n $*',
-	'box_footer', '%R`--<%n$*%R>->%n',
-	'short_msg', '%R>>%n $*',
+   #'example_theme', '{hilight $0} $1 {error $2}',
+   'box_header', '%R,--[%n$*%R]%n',
+   #'box_inside', '%R|%n $*',
+   'box_footer', '%R`--<%n$*%R>->%n',
+   'short_msg', '%R>>%n $*',
 ]);
 
 Irssi::signal_add('setup changed', \&sig_setup_changed);
@@ -503,7 +501,7 @@ sub UNLOAD {
 Irssi::command_bind($IRSSI{name}, \&cmd);
 my @cmds= qw/reload save update info search check help/;
 foreach ( @cmds ) {
-	Irssi::command_bind("$IRSSI{name} $_", \&cmd);
+   Irssi::command_bind("$IRSSI{name} $_", \&cmd);
 }
 Irssi::command_bind('help', \&cmd_help);
 
@@ -511,3 +509,5 @@ sub UNLOAD {
 init();
 
 Irssi::print "%B>>%n $IRSSI{name} $VERSION loaded: /$IRSSI{name} help for help", MSGLEVEL_CLIENTCRAP;
+
+# vim: set ts=3 sw=3 et:

From 1214c00dc77e049e25b9ac73fa9b179a45c9dc33 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Fri, 19 Feb 2021 06:37:48 +0100
Subject: [PATCH 07/22] new

---
 scripts/scriptassist2.pl | 49 ++++++++++++++++++++++++++++++++++++----
 1 file changed, 44 insertions(+), 5 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 89ea921b3..3bd2b8d9f 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -9,7 +9,7 @@
 use Digest::file qw/digest_file_hex/;
 use Digest::MD5 qw/md5_hex/;
 use Text::Wrap;
-use debug;
+#use debug;
 
 use Irssi;
 
@@ -121,7 +121,6 @@ sub background {
 
 sub sig_pipe {
    my ($pid, $pipetag) = @{$_[0]};
-   debug "sig_pipe $pid";
    if (exists $bg_process{$pid}) {
       my $fh_r= $bg_process{$pid}->{fh_r};
       $bg_process{$pid}->{res_str} .= do { local $/; <$fh_r>; };
@@ -131,7 +130,6 @@ sub sig_pipe {
 
 sub sig_pidwait {
    my ($pid, $status) = @_;
-   debug "sig_pidwait $pid";
    if (exists $bg_process{$pid}) {
       close $bg_process{$pid}->{fh_r};
       Irssi::input_remove($bg_process{$pid}->{pipetag});
@@ -273,7 +271,6 @@ sub installed_version {
    my ( $scriptname )= @_;
    my $r;
    no strict 'refs';
-   #debug keys (%Irssi::Script::);
    $r = ${ "Irssi::Script::${scriptname}::VERSION" };
    return $r;
 }
@@ -433,6 +430,46 @@ sub cmd_check {
    print_box($IRSSI{name},"check", @res);
 }
 
+sub cmd_new {
+   my ( @args )= @_;
+   my $as;
+   foreach my $sk ( keys %{ $d->{rscripts} } ) {
+      foreach my $fn ( keys %{ $d->{rscripts}->{$sk} } ) {
+         if ( exists $as->{$fn} ) {
+            if ( ($as->{$fn}->{modified} cmp $d->{rscripts}->{$sk}->{$fn}->{modified}) == -1) {
+               $as->{$fn}= $d->{rscripts}->{$sk}->{$fn};
+            }
+         } else {
+            $as->{$fn}= $d->{rscripts}->{$sk}->{$fn};
+         }
+      }
+   }
+   my $count = $args[0]*1;
+   $count=5 if ( $count <1 );
+   my @res;
+   my $mlen;
+   foreach ( sort { $as->{$b}->{modified} cmp $as->{$a}->{modified} } keys %$as ) {
+      last if ( $count==0);
+      push @res,$_;
+      $mlen = length $_ if ( $mlen < length $_ );
+      $count--;
+   }
+   my @r;
+   $mlen -= 3;
+   foreach ( @res ) {
+      my $sn=$_;
+      $sn =~ s/\.pl$//i;
+      my $p;
+      if ( installed_version $sn ) {
+         $p = "%go%n ";
+      } else {
+         $p = "%yo%n ";
+      }
+      push @r, $p.sprintf "%%9%-${mlen}s%%9 $as->{$_}->{modified}", $sn;
+   }
+   print_box($IRSSI{name},"new", @r);
+}
+
 sub cmd {
    my ($args, $server, $witem)=@_;
    my @args = split /\s+/, $args;
@@ -453,6 +490,8 @@ sub cmd {
       cmd_search( @args);
    } elsif ($c eq 'check') {
       cmd_check();
+   } elsif ($c eq 'new') {
+      cmd_new( @args );
    } else {
       $args= $IRSSI{name};
       cmd_help( $args, $server, $witem);
@@ -499,7 +538,7 @@ sub UNLOAD {
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
 
 Irssi::command_bind($IRSSI{name}, \&cmd);
-my @cmds= qw/reload save update info search check help/;
+my @cmds= qw/reload save update info search check new help/;
 foreach ( @cmds ) {
    Irssi::command_bind("$IRSSI{name} $_", \&cmd);
 }

From bf24462af3446028b37762dd37ff111a0e1423dc Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sat, 20 Feb 2021 10:09:31 +0100
Subject: [PATCH 08/22] install

---
 scripts/scriptassist2.pl | 81 ++++++++++++++++++++++++++++++++++------
 1 file changed, 69 insertions(+), 12 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 3bd2b8d9f..1328cd1a7 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -9,7 +9,7 @@
 use Digest::file qw/digest_file_hex/;
 use Digest::MD5 qw/md5_hex/;
 use Text::Wrap;
-#use debug;
+use debug;
 
 use Irssi;
 
@@ -71,10 +71,8 @@ END
 #
 #  /scriptassist update <script|all>
 #        update != upgrade
-#  /scriptassist new <num>
 #  /scriptassist contact <script>
 #  /scriptassist cpan <module>
-#  /scriptassist install <script>
 #  /scriptassist autorun <script>
 #
 #  /scriptassist rate <script>
@@ -111,8 +109,8 @@ sub background {
    } else {
       $cmd->{fh_r}=$fh_r;
       my $pipetag;
-        my @args = ($pid, \$pipetag );
-        $pipetag = Irssi::input_add(fileno($fh_r), Irssi::INPUT_READ, \&sig_pipe, \@args);
+      my @args = ($pid, \$pipetag );
+      $pipetag = Irssi::input_add(fileno($fh_r), Irssi::INPUT_READ, \&sig_pipe, \@args);
       $cmd->{pipetag} = $pipetag;
       $bg_process{$pid}=$cmd;
       Irssi::pidwait_add($pid);
@@ -194,16 +192,16 @@ sub save {
 
 sub fetch {
    my ($uri)= @_;
-   my $ff = File::Fetch->new (
+   my ($ff, $w, $res);
+	local $File::Fetch::WARN=0;
+   $ff = File::Fetch->new (
       uri => $uri,
    );
-   my $w;
-   eval { $w = $ff->fetch(to => $path,); };
+   $w = $ff->fetch(to => $path,); 
    if ( $w ) {
-      return $ff->file;
-   } else {
-      return undef;
+      $res= $ff->file;
    }
+   return $res;
 }
 
 sub update {
@@ -470,6 +468,63 @@ sub cmd_new {
    print_box($IRSSI{name},"new", @r);
 }
 
+sub cmd_install {
+   my ( @args )= @_;
+   my @sl;
+   foreach my $sn ( @args ) {
+      $sn =~ s/\.pl$//i;
+      my $fn ="$sn.pl";
+      my $rd;
+      foreach my $rc ( @{ $d->{rconfig} } ) {
+         if ( exists $d->{rscripts}->{$rc->{name}}->{$fn} ) {
+            $rd= $rc;
+         }
+      }
+      if ( defined $rd ) {
+         my $s="$rd->{url_sc}/$fn";
+         push @sl, $s;
+      }
+   }
+   print_short "Please wait..."; 
+   background({ 
+      cmd => \&bg_install,
+      args => [ @sl ],
+      last => [ \&print_install ],
+   });
+}
+
+sub bg_install {
+   my ( @sl )= @_;
+   my @r;
+   foreach my $url ( @sl ) {
+      my $fn=fetch( $url );
+      if (defined $fn ) {
+         if ( -e Irssi::get_irssi_dir()."/scripts/$fn" ) {
+            rename Irssi::get_irssi_dir()."/scripts/$fn", Irssi::get_irssi_dir()."/scripts/$fn.bak";
+         }
+         rename "$path/$fn", Irssi::get_irssi_dir()."/scripts/$fn";
+         push @r, $fn; 
+      }
+   }
+   return @r;
+}
+
+sub print_install {
+   my ( $pn ) = @_;
+   my @res;
+   foreach my $fn ( @{ $pn->{res} } ) {
+      my $sn= $fn;
+      $sn =~ s/\.pl$//i;
+      if ( !installed_version $sn ) {
+         Irssi::command("script load $fn");
+         push @res, "%go%n %9$sn%9 installed";
+      } else {
+         push @res, "%ro%n %9$sn%9 already loaded, please try 'update'";
+      }
+   }
+   print_box($IRSSI{name},"install", @res);
+}
+
 sub cmd {
    my ($args, $server, $witem)=@_;
    my @args = split /\s+/, $args;
@@ -492,6 +547,8 @@ sub cmd {
       cmd_check();
    } elsif ($c eq 'new') {
       cmd_new( @args );
+   } elsif ($c eq 'install') {
+      cmd_install( @args );
    } else {
       $args= $IRSSI{name};
       cmd_help( $args, $server, $witem);
@@ -538,7 +595,7 @@ sub UNLOAD {
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
 
 Irssi::command_bind($IRSSI{name}, \&cmd);
-my @cmds= qw/reload save update info search check new help/;
+my @cmds= qw/reload save update info search check new install help/;
 foreach ( @cmds ) {
    Irssi::command_bind("$IRSSI{name} $_", \&cmd);
 }

From 6af2b66cd6282fdeb12c7d7c9d17917176808b30 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sat, 20 Feb 2021 11:42:54 +0100
Subject: [PATCH 09/22] autorun

---
 scripts/scriptassist2.pl | 73 +++++++++++++++++++++++++++++++++-------
 1 file changed, 60 insertions(+), 13 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 1328cd1a7..7001a1509 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -9,7 +9,7 @@
 use Digest::file qw/digest_file_hex/;
 use Digest::MD5 qw/md5_hex/;
 use Text::Wrap;
-use debug;
+#use debug;
 
 use Irssi;
 
@@ -73,7 +73,6 @@ END
 #        update != upgrade
 #  /scriptassist contact <script>
 #  /scriptassist cpan <module>
-#  /scriptassist autorun <script>
 #
 #  /scriptassist rate <script>
 #  /scriptassist ratings <scripts|all>
@@ -163,12 +162,19 @@ sub print_short {
    Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'short_msg', $str); 
 }
 
+sub installed_version {
+   my ( $scriptname )= @_;
+   my $r;
+   no strict 'refs';
+   $r = ${ "Irssi::Script::${scriptname}::VERSION" };
+   return $r;
+}
+
 sub init {
    if ( -e "$path/cache.yml" ) {
       my $yml= CPAN::Meta::YAML->read("$path/cache.yml");
       $d= $yml->[0];
    }
-      
    if ( ref($d) ne 'HASH' || ! exists $d->{rconfig} ) {
       $d= undef;
       $d->{rconfig}=();
@@ -179,10 +185,18 @@ sub init {
       $n{url_sc}="https://scripts.irssi.org/scripts";
       push @{$d->{rconfig}}, {%n};
    }
-
    foreach my $n ( @{ $d->{rconfig} } ) {
       $source{$n->{name}}= $n;
    }
+   if ( exists $d->{autorun} ) {
+      foreach my $fn ( @{$d->{autorun}} ) {
+         my $sn= $fn;
+         $sn =~ s/\.pl$//i;
+         if (! (installed_version $sn )) {
+            Irssi::command("script load $fn");
+         }
+      }
+   }
 }
 
 sub save {
@@ -265,14 +279,6 @@ sub sinfo {
    return sprintf "  %-${nl}s: %s", $name, $v;
 }
 
-sub installed_version {
-   my ( $scriptname )= @_;
-   my $r;
-   no strict 'refs';
-   $r = ${ "Irssi::Script::${scriptname}::VERSION" };
-   return $r;
-}
-
 sub module_exist {
    my ($module) = @_;
    $module =~ s/::/\//g;
@@ -525,6 +531,44 @@ sub print_install {
    print_box($IRSSI{name},"install", @res);
 }
 
+sub cmd_autorun {
+   my ( @args )= @_;
+   foreach my $sn ( @args ){
+      $sn =~ s/\.pl$//i;
+      my $fn = "$sn.pl";
+      my $of=Irssi::get_irssi_dir()."/scripts/$fn";
+      if (Irssi::settings_get_bool($IRSSI{name}.'_autorun_link') ) {
+         my $af=Irssi::get_irssi_dir()."/scripts/autorun/$fn";
+         if (-e $af ) {
+            unlink $af;
+            print_short "Autorun of $sn disabled";
+         } else {
+            if ( -e $of ) {
+               symlink "../$fn", $af;
+               print_short "Autorun of $sn enabled";
+            }
+         }
+      } else {
+         if ( !exists $d->{autorun} ) {
+            $d->{autorun}=[];
+         }
+         my $r;
+         for (my $c=0; $c < scalar( @{ $d->{autorun} } ) ; $c++) {
+            if ($d->{autorun}->[$c] eq $fn) {
+               splice @{ $d->{autorun} } , $c ,1;
+               $r=1;
+               print_short "Autorun of $sn disabled";
+               last;
+            }
+         }
+         if (!$r && -e $of ) {
+            push @{ $d->{autorun} }, $fn;
+            print_short "Autorun of $sn enabled";
+         }
+      }
+   }
+}
+
 sub cmd {
    my ($args, $server, $witem)=@_;
    my @args = split /\s+/, $args;
@@ -549,6 +593,8 @@ sub cmd {
       cmd_new( @args );
    } elsif ($c eq 'install') {
       cmd_install( @args );
+   } elsif ($c eq 'autorun') {
+      cmd_autorun( @args );
    } else {
       $args= $IRSSI{name};
       cmd_help( $args, $server, $witem);
@@ -593,9 +639,10 @@ sub UNLOAD {
 Irssi::signal_add('pidwait', \&sig_pidwait);
 
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
+Irssi::settings_add_bool($IRSSI{name} ,$IRSSI{name}.'_autorun_link', 1);
 
 Irssi::command_bind($IRSSI{name}, \&cmd);
-my @cmds= qw/reload save update info search check new install help/;
+my @cmds= qw/reload save update info search check new install autorun help/;
 foreach ( @cmds ) {
    Irssi::command_bind("$IRSSI{name} $_", \&cmd);
 }

From a657f6a788c7e942a73c725aaf4c3f4215b06212 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sun, 21 Feb 2021 14:07:09 +0100
Subject: [PATCH 10/22] update

---
 scripts/scriptassist2.pl | 99 +++++++++++++++++++++++++++++++++++-----
 1 file changed, 88 insertions(+), 11 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 7001a1509..18ba56762 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -9,7 +9,7 @@
 use Digest::file qw/digest_file_hex/;
 use Digest::MD5 qw/md5_hex/;
 use Text::Wrap;
-#use debug;
+use debug;
 
 use Irssi;
 
@@ -69,8 +69,6 @@ END
 
 # TODO
 #
-#  /scriptassist update <script|all>
-#        update != upgrade
 #  /scriptassist contact <script>
 #  /scriptassist cpan <module>
 #
@@ -87,6 +85,7 @@ END
 # ->{rconfig}->@
 # ->{rscripts}->%
 # ->{rstat}->%
+# ->{autorun}->@
 
 # links to $d->{rconfig}->@
 my %source;
@@ -218,7 +217,7 @@ sub fetch {
    return $res;
 }
 
-sub update {
+sub getmeta {
    my @msg;
    foreach my $n ( @{ $d->{rconfig} } ) {
       my $fn=fetch( $n->{url_db} );
@@ -245,7 +244,7 @@ sub update {
    return $d, [@msg] ;
 }
 
-sub print_update {
+sub print_getmeta {
    my ( $pn ) = @_;
    # write back to main!
    $d= $pn->{res}->[0] ;
@@ -540,8 +539,12 @@ sub cmd_autorun {
       if (Irssi::settings_get_bool($IRSSI{name}.'_autorun_link') ) {
          my $af=Irssi::get_irssi_dir()."/scripts/autorun/$fn";
          if (-e $af ) {
-            unlink $af;
-            print_short "Autorun of $sn disabled";
+            if ( -l $af ) {
+               unlink $af;
+               print_short "Autorun of $sn disabled";
+            } else {
+               print_short "$fn is not a symlink";
+            }
          } else {
             if ( -e $of ) {
                symlink "../$fn", $af;
@@ -569,6 +572,78 @@ sub cmd_autorun {
    }
 }
 
+sub cmd_update {
+   my ( @args )= @_;
+   my @sn;
+   if ( $args[0] eq 'all' ) {
+      foreach my $sn (keys %Irssi::Script:: ) {
+         $sn =~ s/:+$//;
+         push @sn, $sn;
+      }
+   } else {
+      foreach my $sn ( @args ) {
+         $sn =~ s/\.pl$//i;
+         push @sn, $sn;
+      }
+   }
+   my @r;
+   my @current;
+   foreach my $sn ( @sn ) {
+      my $fn = "$sn.pl";
+      my $iv= installed_version $sn;
+      my $rv;
+      foreach my $n (  @{ $d->{rconfig} } ) {
+         my $sk= $n->{name};
+         if ( exists $d->{rscripts}->{$sk}->{$fn} ) {
+            $rv=$d->{rscripts}->{$sk}->{$fn}->{version};
+            if ( ($iv cmp $rv) == -1 ) {
+               push @r, "$n->{url_sc}/$fn";
+            } else {
+               push @current, $sn;
+            }
+            last;
+         }
+      }
+   }
+   print_short "Please wait..."; 
+   background({ 
+      cmd => \&bg_install,
+      args => [ @r ],
+      current => [ @current ],
+      last => [ \&print_update ],
+   });
+}
+
+sub print_update {
+   my ( $pn ) = @_;
+   my %res;
+   my @r;
+   my $mlen;
+   foreach my $fn ( @{ $pn->{res} } ) {
+      $mlen= length $fn if $mlen < length $fn;
+   }
+   $mlen -= 3;
+   foreach my $sn ( @{ $pn->{current} } ) {
+      $mlen= length $sn if $mlen < length $sn;
+   }
+   foreach my $fn ( @{ $pn->{res} } ) {
+      my $sn= $fn;
+      $sn =~ s/\.pl$//i;
+      my $ov= installed_version $sn;
+      Irssi::command("script load $fn");
+      my $nv= installed_version $sn;
+      $res{$sn}= "%yo%n %9".sprintf("%-${mlen}s",$sn)."%9 upgradet ($ov->$nv)";
+   }
+   foreach my $sn ( @{ $pn->{current} } ) {
+      my $v= installed_version $sn;
+      $res{$sn}= "%go%n %9".sprintf("%-${mlen}s",$sn)."%9 already at the latest version ($v)";
+   }
+   foreach my $sn (sort keys %res ) {
+      push @r, $res{$sn};
+   }
+   print_box($IRSSI{name},"update", @r);
+}
+
 sub cmd {
    my ($args, $server, $witem)=@_;
    my @args = split /\s+/, $args;
@@ -577,11 +652,11 @@ sub cmd {
       cmd_reload( );
    } elsif ($c eq 'save') {
       cmd_save( );
-   } elsif ($c eq 'update') {
+   } elsif ($c eq 'getmeta') {
       print_short "Please wait..."; 
       background({ 
-         cmd => \&update,
-         last => [ \&print_update ],
+         cmd => \&getmeta,
+         last => [ \&print_getmeta ],
       });
    } elsif ($c eq 'info') {
       cmd_info( @args);
@@ -595,6 +670,8 @@ sub cmd {
       cmd_install( @args );
    } elsif ($c eq 'autorun') {
       cmd_autorun( @args );
+   } elsif ($c eq 'update') {
+      cmd_update( @args );
    } else {
       $args= $IRSSI{name};
       cmd_help( $args, $server, $witem);
@@ -642,7 +719,7 @@ sub UNLOAD {
 Irssi::settings_add_bool($IRSSI{name} ,$IRSSI{name}.'_autorun_link', 1);
 
 Irssi::command_bind($IRSSI{name}, \&cmd);
-my @cmds= qw/reload save update info search check new install autorun help/;
+my @cmds= qw/reload save getmeta info search check new install autorun update help/;
 foreach ( @cmds ) {
    Irssi::command_bind("$IRSSI{name} $_", \&cmd);
 }

From 8e82b5e081aa7b19067d1deefc487efa5eb78559 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Wed, 24 Feb 2021 18:08:03 +0100
Subject: [PATCH 11/22] contact

---
 scripts/scriptassist2.pl | 70 ++++++++++++++++++++++++++++++++++------
 1 file changed, 60 insertions(+), 10 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 18ba56762..1f3ca276b 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -9,7 +9,7 @@
 use Digest::file qw/digest_file_hex/;
 use Digest::MD5 qw/md5_hex/;
 use Text::Wrap;
-use debug;
+#use debug;
 
 use Irssi;
 
@@ -69,9 +69,6 @@ END
 
 # TODO
 #
-#  /scriptassist contact <script>
-#  /scriptassist cpan <module>
-#
 #  /scriptassist rate <script>
 #  /scriptassist ratings <scripts|all>
 #  /scriptassist top <num>
@@ -164,11 +161,24 @@ sub print_short {
 sub installed_version {
    my ( $scriptname )= @_;
    my $r;
-   no strict 'refs';
-   $r = ${ "Irssi::Script::${scriptname}::VERSION" };
+   if ( exists $Irssi::Script::{"${scriptname}::"} ) {
+      no strict 'refs';
+      $r = ${ "Irssi::Script::${scriptname}::VERSION" };
+   }
    return $r;
 }
 
+sub call_openurl {
+   my ($url) = @_;
+   # check for a loaded openurl
+   if (my $code = Irssi::Script::openurl::->can('launch_url')) {
+      $code->($url);
+   } else {
+      print_short "Please install openurl.pl";
+      print_short "   or open < $url > manually";
+   }
+}
+
 sub init {
    if ( -e "$path/cache.yml" ) {
       my $yml= CPAN::Meta::YAML->read("$path/cache.yml");
@@ -300,8 +310,8 @@ sub cmd_info {
    my ( @args)=@_;
    my @r;
    foreach my $sn ( @args ) {
-      my $fn=$sn;
-      $fn =~ s/$/\.pl/ if ( $sn !~ m/\.pl$/ );
+      $sn =~ s/\.pl$//i;
+      my $fn="$sn.pl";
       foreach my $sl ( keys %{ $d->{rscripts} } ) {
          if ( exists $d->{rscripts}->{$sl}->{$fn} ) {
             my $n=$d->{rscripts}->{$sl}->{$fn};
@@ -644,6 +654,35 @@ sub print_update {
    print_box($IRSSI{name},"update", @r);
 }
 
+sub cmd_cpan {
+   my ( @args )= @_;
+	call_openurl('http://search.cpan.org/search?mode=module&query='.$args[0]);
+}
+
+sub cmd_contact {
+   my ( @args )= @_;
+   my ($sn)= @args;
+   $sn =~ s/\.pl//i;
+   my $fn= "$sn.pl";
+   my $iv= installed_version $sn;
+   my $aut;
+   foreach my $sk (keys %{ $d->{rscripts}} ) {
+      if ( exists $d->{rscripts}->{$sk}->{$fn} ) {
+         if ( exists $d->{rscripts}->{$sk}->{$fn}->{contact} ) {
+            $aut= $d->{rscripts}->{$sk}->{$fn}->{contact};
+            last;
+         }
+      }
+   }
+   my @ml = $aut =~ m/([\w.]+?@[\w.]+)[\s,>\|]*/g;
+   if ( scalar(@ml) > 0 ) {
+      my $murl = $ml[0];
+      $murl .= "?subject=$sn";
+      $murl .= "_$iv" if (defined $iv);
+      call_openurl $murl;
+   }
+}
+
 sub cmd {
    my ($args, $server, $witem)=@_;
    my @args = split /\s+/, $args;
@@ -672,7 +711,11 @@ sub cmd {
       cmd_autorun( @args );
    } elsif ($c eq 'update') {
       cmd_update( @args );
-   } else {
+   } elsif ($c eq 'cpan') {
+      cmd_cpan( @args );
+   } elsif ($c eq 'contact') {
+      cmd_contact( @args );
+   } elsif ($c eq 'help') {
       $args= $IRSSI{name};
       cmd_help( $args, $server, $witem);
    }
@@ -717,12 +760,19 @@ sub UNLOAD {
 
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
 Irssi::settings_add_bool($IRSSI{name} ,$IRSSI{name}.'_autorun_link', 1);
+Irssi::settings_add_bool($IRSSI{name}, $IRSSI{name}.'_integrate', 1);
 
+my @cmds= qw/reload save getmeta info search check new install autorun update cpan contact help/;
 Irssi::command_bind($IRSSI{name}, \&cmd);
-my @cmds= qw/reload save getmeta info search check new install autorun update help/;
 foreach ( @cmds ) {
    Irssi::command_bind("$IRSSI{name} $_", \&cmd);
 }
+if ( Irssi::settings_get_bool($IRSSI{name}.'_integrate')) {
+   Irssi::command_bind('script', \&cmd);
+   foreach ( @cmds ) {
+      Irssi::command_bind("script $_", \&cmd);
+   }
+}
 Irssi::command_bind('help', \&cmd_help);
 
 sig_setup_changed();

From c41caa7caac85daea188c8273671202da8eed908 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Fri, 26 Feb 2021 20:53:49 +0100
Subject: [PATCH 12/22] cache_timeout

---
 scripts/scriptassist2.pl | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 1f3ca276b..258488bba 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -685,6 +685,31 @@ sub cmd_contact {
 
 sub cmd {
    my ($args, $server, $witem)=@_;
+   my $t=localtime();
+   my $r;
+   my $to = Irssi::settings_get_int($IRSSI{name}.'_cache_timeout');
+   foreach my $hn ( keys %{ $d->{rstat} } ) {
+      if ( $d->{rstat}->{$hn}->{last}+ $to < $t->epoch) {
+         $r=1;
+      }
+   }
+   if ( $r ) {
+      print_short "Please wait..."; 
+      background({ 
+         cmd => \&getmeta,
+         cmd_args => $args,
+         last => [ \&print_getmeta, \&cmd_main ],
+      });
+   } else {
+      cmd_main( $args, $server, $witem);
+   }
+}
+
+sub cmd_main {
+   my ($args, $server, $witem)=@_;
+   if ( ref($args) eq 'HASH' && $args->{cmd_args} ) {
+      $args = $args->{cmd_args};
+   }
    my @args = split /\s+/, $args;
    my $c = shift @args;
    if ($c eq 'reload') {
@@ -761,6 +786,7 @@ sub UNLOAD {
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
 Irssi::settings_add_bool($IRSSI{name} ,$IRSSI{name}.'_autorun_link', 1);
 Irssi::settings_add_bool($IRSSI{name}, $IRSSI{name}.'_integrate', 1);
+Irssi::settings_add_int($IRSSI{name}, $IRSSI{name}.'_cache_timeout', 24*60*60);
 
 my @cmds= qw/reload save getmeta info search check new install autorun update cpan contact help/;
 Irssi::command_bind($IRSSI{name}, \&cmd);

From 47639ed0451d7ed7f55761f349ee3dfa763a9e2a Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sun, 28 Feb 2021 16:39:22 +0100
Subject: [PATCH 13/22] rate

---
 scripts/scriptassist2.pl | 202 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 197 insertions(+), 5 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 258488bba..8863a20e5 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -9,6 +9,7 @@
 use Digest::file qw/digest_file_hex/;
 use Digest::MD5 qw/md5_hex/;
 use Text::Wrap;
+use JSON::PP;
 #use debug;
 
 use Irssi;
@@ -69,9 +70,6 @@ END
 
 # TODO
 #
-#  /scriptassist rate <script>
-#  /scriptassist ratings <scripts|all>
-#  /scriptassist top <num>
 #  signature
 
 # config path
@@ -87,6 +85,9 @@ END
 # links to $d->{rconfig}->@
 my %source;
 
+# sortet rate;
+my %srate;
+
 my %bg_process= ();
 
 sub background {
@@ -192,11 +193,16 @@ sub init {
       $n{type}="yaml";
       $n{url_db}="https://scripts.irssi.org/scripts.yml";
       $n{url_sc}="https://scripts.irssi.org/scripts";
+      #$n{url_rate}="https://api.github.com/repos/ailin-nemui/scripts.irssi.org/issues?state=closed";
+      $n{url_rate}="https://api.github.com/repos/ailin-nemui/irssi-script-votes/issues?state=closed";
       push @{$d->{rconfig}}, {%n};
    }
    foreach my $n ( @{ $d->{rconfig} } ) {
       $source{$n->{name}}= $n;
    }
+   if ( exists $d->{rrate} ) {
+      sort_rate();
+   }
    if ( exists $d->{autorun} ) {
       foreach my $fn ( @{$d->{autorun}} ) {
          my $sn= $fn;
@@ -257,7 +263,8 @@ sub getmeta {
 sub print_getmeta {
    my ( $pn ) = @_;
    # write back to main!
-   $d= $pn->{res}->[0] ;
+   $d->{rscripts} = $pn->{res}->[0]->{rscripts} ;
+   $d->{rstat} = $pn->{res}->[0]->{rstat} ;
    foreach my $n ( @{ $d->{rconfig} } ) {
       $source{$n->{name}}= $n;
    }
@@ -705,6 +712,182 @@ sub cmd {
    }
 }
 
+sub fetch_gh_json {
+   my ( $url ) = @_;
+   my $ua = LWP::UserAgent->new(timeout => 10);
+   $ua->env_proxy;
+   $ua->default_header(
+      'Accept' => 'application/vnd.github.squirrel-girl-preview+json',
+      #'Accept'=> 'application/vnd.github.v3+json',
+   );
+   my $response = $ua->get($url );
+   if ($response->is_success) {
+      return decode_json($response->decoded_content);
+   } else {
+      return undef;
+   }
+}
+
+sub get_rate {
+   my %all;
+   my @err;
+   foreach my $n ( reverse  @{$d->{rconfig}} ) {
+      next unless exists( $n->{url_rate} );
+      my $t = fetch_gh_json $n->{url_rate} ;
+      push @err, "error fetch issue list ($n->{url_rate})" unless defined $t;
+      foreach my $is ( @$t ) {
+         my $com = fetch_gh_json $is->{comments_url}.'?per_page=100';
+         push @err, "error fetch comments ($is->{comments_url})" unless defined $com;
+         foreach my $n ( @$com ) {
+            my $b=$n->{body};
+            $b =~ m/([\w-]+\.pl)/;
+            my $fn= $1;
+            my $p = $n->{reactions}->{'+1'} 
+                        + $n->{reactions}->{'hooray'} 
+                        + $n->{reactions}->{'rocket'} 
+                        + $n->{reactions}->{'heart'} ;
+            my $m = $n->{reactions}->{'-1'} 
+                        + $n->{reactions}->{'confused'};
+            my $sum= $p-$m;
+            if ( $p >0 || $m >0) {
+               $all{$fn}->{vote} += $sum;
+            }
+            $all{$fn}->{vote_url}= $n->{html_url};
+         }
+      }
+   }
+   return {%all}, [ @err ] ;
+}
+
+sub sort_rate {
+   %srate=();
+   foreach my $k ( keys %{ $d->{rrate}} ) {
+      if ( exists $d->{rrate}->{$k}->{vote} ) {
+         if ( ! exists $srate{ $d->{rrate}->{$k}->{vote} } ) {
+            $srate{ $d->{rrate}->{$k}->{vote} }=[];
+         }
+         push @{$srate{ $d->{rrate}->{$k}->{vote} }}, $k;
+      }
+   }
+}
+
+sub cmd_getrate {
+   if (!module_exist('LWP::UserAgent')) {
+      print_short 'LWP::UserAgent not exists';
+      return;
+   }
+   use LWP::UserAgent;
+   print_short "Please wait..."; 
+   background({ 
+      cmd => \&get_rate,
+      last => [ \&print_getrate ],
+   });
+}
+
+sub print_getrate {
+   my ( $pn ) = @_;
+   # write back to main!
+   $d->{rrate} = $pn->{res}->[0] ;
+   my $err= $pn->{res}->[1];
+   if (ref($err) eq "ARRAY" && scalar(@$err) >0 ) {
+      foreach ( @$err) {
+         print_short $_;
+      }
+      print_short "rate cache not updatet";
+      return;
+   }
+   sort_rate();
+   my $t=localtime();
+   $d->{rrate_state}->{last}= $t->epoch;
+   print_short "rate cache updatet";
+}
+
+sub cmd_rate {
+   my ( @args )= @_;
+   foreach my $sn ( @args ) {
+      $sn =~ s/\.pl$//i;
+      my $fn = "$sn.pl";
+      if ( exists $d->{rrate}->{$fn} ) {
+         call_openurl $d->{rrate}->{$fn}->{vote_url};
+      }
+   }
+}
+
+sub cmd_ratings {
+   my ( @args )= @_;
+   for(my $c=0; $c<=$#args; $c++) {
+      if ( $args[$c] eq 'all') {
+         splice @args, $c, 1;
+         foreach my $sn (keys %Irssi::Script:: ) {
+            $sn =~ s/:+$//;
+            push @args, $sn;
+         }
+         last;
+      }
+   }
+   my %ra;
+   foreach my $sn ( @args ) {
+      $sn =~ s/\.pl$//i;
+      my $fn = "$sn.pl";
+      my $vote= $d->{rrate}->{$fn}->{vote};
+      $ra{$vote}=[] if !exists($ra{$vote});
+      push @{$ra{$vote}}, $sn;
+   }
+   print_rating('ratings', 0, \%ra);
+}
+
+sub print_rating {
+   my ( $tail, $maxl, $ratings )=@_;
+   my @res;
+   my $lmax;
+   my $max=$maxl;
+   foreach my $r ( sort { $b <=> $a } keys %$ratings ) {
+      foreach my $sn ( sort @{ $ratings->{$r} } ) {
+         $sn =~ s/\.pl$//i;
+         my $fn = "$sn.pl";
+         if ( exists $d->{rrate}->{$fn} ) {
+            $lmax =length $sn if $lmax < length $sn;
+            $max--;
+            last if ( $max == 0 );
+         }
+      }
+      last if ( $max == 0 );
+   }
+   foreach my $r ( sort { $b <=> $a } keys %$ratings ) {
+      foreach my $sn ( sort @{ $ratings->{$r} } ) {
+         $sn =~ s/\.pl$//i;
+         my $fn = "$sn.pl";
+         if ( exists $d->{rrate}->{$fn} ) {
+            my $s;
+            if ( installed_version $sn ) {
+               $s="%go%n %9";
+            } else {
+               $s="%yo%n %9";
+            }
+            my $vote= $d->{rrate}->{$fn}->{vote};
+            if ( $vote == 0 ) {
+               $s .=sprintf("%-${lmax}s",$sn)."%9 [no votes]";
+            } else {
+               $s .=sprintf("%-${lmax}s",$sn)."%9 [$vote votes]";
+            }
+            push @res, $s;
+            $maxl--;
+            last if ( $maxl == 0 );
+         }
+      }
+      last if ( $maxl == 0 );
+   }
+   print_box $IRSSI{name}, $tail, @res;
+}
+
+sub cmd_top {
+   my ( $maxl ) = @_;
+   if ( !defined $maxl || $maxl == 0 ) {
+      $maxl=10;
+   }
+   print_rating 'top', $maxl, \%srate;
+}
+
 sub cmd_main {
    my ($args, $server, $witem)=@_;
    if ( ref($args) eq 'HASH' && $args->{cmd_args} ) {
@@ -740,6 +923,14 @@ sub cmd_main {
       cmd_cpan( @args );
    } elsif ($c eq 'contact') {
       cmd_contact( @args );
+   } elsif ($c eq 'getrate') {
+      cmd_getrate( );
+   } elsif ($c eq 'rate') {
+      cmd_rate( @args );
+   } elsif ($c eq 'ratings') {
+      cmd_ratings( @args );
+   } elsif ($c eq 'top') {
+      cmd_top( @args );
    } elsif ($c eq 'help') {
       $args= $IRSSI{name};
       cmd_help( $args, $server, $witem);
@@ -788,7 +979,8 @@ sub UNLOAD {
 Irssi::settings_add_bool($IRSSI{name}, $IRSSI{name}.'_integrate', 1);
 Irssi::settings_add_int($IRSSI{name}, $IRSSI{name}.'_cache_timeout', 24*60*60);
 
-my @cmds= qw/reload save getmeta info search check new install autorun update cpan contact help/;
+my @cmds= qw/reload save getmeta info search check new install autorun update cpan contact/;
+push @cmds, qw/getrate rate ratings top help/;
 Irssi::command_bind($IRSSI{name}, \&cmd);
 foreach ( @cmds ) {
    Irssi::command_bind("$IRSSI{name} $_", \&cmd);

From 56f054b7cc111411f493a1163c7b7706c36918de Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sat, 6 Mar 2021 19:35:02 +0100
Subject: [PATCH 14/22] cmd

---
 scripts/scriptassist2.pl | 194 +++++++++++++++++++++++++--------------
 1 file changed, 126 insertions(+), 68 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 8863a20e5..b7376d9f2 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -88,6 +88,8 @@ END
 # sortet rate;
 my %srate;
 
+my %cmds;
+
 my %bg_process= ();
 
 sub background {
@@ -260,6 +262,14 @@ sub getmeta {
    return $d, [@msg] ;
 }
 
+sub cmd_getmeta {
+   print_short "Please wait..."; 
+   background({ 
+      cmd => \&getmeta,
+      last => [ \&print_getmeta ],
+   });
+}
+
 sub print_getmeta {
    my ( $pn ) = @_;
    # write back to main!
@@ -690,28 +700,6 @@ sub cmd_contact {
    }
 }
 
-sub cmd {
-   my ($args, $server, $witem)=@_;
-   my $t=localtime();
-   my $r;
-   my $to = Irssi::settings_get_int($IRSSI{name}.'_cache_timeout');
-   foreach my $hn ( keys %{ $d->{rstat} } ) {
-      if ( $d->{rstat}->{$hn}->{last}+ $to < $t->epoch) {
-         $r=1;
-      }
-   }
-   if ( $r ) {
-      print_short "Please wait..."; 
-      background({ 
-         cmd => \&getmeta,
-         cmd_args => $args,
-         last => [ \&print_getmeta, \&cmd_main ],
-      });
-   } else {
-      cmd_main( $args, $server, $witem);
-   }
-}
-
 sub fetch_gh_json {
    my ( $url ) = @_;
    my $ua = LWP::UserAgent->new(timeout => 10);
@@ -776,7 +764,8 @@ sub cmd_getrate {
       print_short 'LWP::UserAgent not exists';
       return;
    }
-   use LWP::UserAgent;
+   #use LWP::UserAgent;
+   require LWP::UserAgent;
    print_short "Please wait..."; 
    background({ 
       cmd => \&get_rate,
@@ -888,55 +877,126 @@ sub cmd_top {
    print_rating 'top', $maxl, \%srate;
 }
 
-sub cmd_main {
+%cmds= (
+   reload=> {
+         cmd=> \&cmd_reload,
+   },
+   save=> {
+         cmd=> \&cmd_save,
+   },
+   getmeta=> {
+         cmd=> \&cmd_getmeta,
+   },
+   info=> {
+         cmd=> \&cmd_info,
+         meta=>1,
+   },
+   search=> {
+         cmd=> \&cmd_search,
+         meta=>1,
+   },
+   check=> {
+         cmd=> \&cmd_check,
+         meta=>1,
+   },
+   new=> {
+         cmd=> \&cmd_new,
+         meta=>1,
+   },
+   install=> {
+         cmd=> \&cmd_install,
+   },
+   autorun=> {
+         cmd=> \&cmd_autorun,
+   },
+   update=> {
+         cmd=> \&cmd_update,
+         meta=>1,
+   },
+   cpan=> {
+         cmd=> \&cmd_cpan,
+         meta=>1,
+   },
+   contact=> {
+         cmd=> \&cmd_contact,
+         meta=>1,
+   },
+   getrate=> {
+         cmd=> \&cmd_getrate,
+   },
+   rate=> {
+         cmd=> \&cmd_rate,
+         rate=>1,
+   },
+   ratings=> {
+         cmd=> \&cmd_ratings,
+         rate=>1,
+   },
+   top=> {
+         cmd=> \&cmd_top,
+         rate=>1,
+   },
+);
+
+sub cmd {
    my ($args, $server, $witem)=@_;
-   if ( ref($args) eq 'HASH' && $args->{cmd_args} ) {
-      $args = $args->{cmd_args};
-   }
    my @args = split /\s+/, $args;
    my $c = shift @args;
-   if ($c eq 'reload') {
-      cmd_reload( );
-   } elsif ($c eq 'save') {
-      cmd_save( );
-   } elsif ($c eq 'getmeta') {
-      print_short "Please wait..."; 
-      background({ 
-         cmd => \&getmeta,
-         last => [ \&print_getmeta ],
-      });
-   } elsif ($c eq 'info') {
-      cmd_info( @args);
-   } elsif ($c eq 'search') {
-      cmd_search( @args);
-   } elsif ($c eq 'check') {
-      cmd_check();
-   } elsif ($c eq 'new') {
-      cmd_new( @args );
-   } elsif ($c eq 'install') {
-      cmd_install( @args );
-   } elsif ($c eq 'autorun') {
-      cmd_autorun( @args );
-   } elsif ($c eq 'update') {
-      cmd_update( @args );
-   } elsif ($c eq 'cpan') {
-      cmd_cpan( @args );
-   } elsif ($c eq 'contact') {
-      cmd_contact( @args );
-   } elsif ($c eq 'getrate') {
-      cmd_getrate( );
-   } elsif ($c eq 'rate') {
-      cmd_rate( @args );
-   } elsif ($c eq 'ratings') {
-      cmd_ratings( @args );
-   } elsif ($c eq 'top') {
-      cmd_top( @args );
-   } elsif ($c eq 'help') {
+   if ( exists $cmds{$c} ) {
+      my $t=localtime();
+      my $to = Irssi::settings_get_int($IRSSI{name}.'_cache_timeout');
+      if (exists $cmds{$c}->{meta} ) {
+         my $r;
+         $r=1 if ( scalar(keys %{ $d->{rstat}})==0 );
+         foreach my $hn ( keys %{ $d->{rstat} } ) {
+            if ( ($d->{rstat}->{$hn}->{last}+ $to) < $t->epoch) {
+               $r=1;
+            }
+         }
+         if ( $r ) {
+            print_short "Please wait..."; 
+            background({ 
+               cmd => \&getmeta,
+               cmd_args => [$c, @args],
+               last => [ \&print_getmeta, \&last_cmd ],
+            });
+         } else {
+            &{$cmds{$c}->{cmd}}(@args);
+         }
+      } elsif (exists $cmds{$c}->{rate} ) {
+         if ( ($d->{rrate_state}->{last}+ $to) < $t->epoch) {
+            if (!module_exist('LWP::UserAgent')) {
+               print_short 'LWP::UserAgent not exists';
+               return;
+            }
+            require LWP::UserAgent;
+            print_short "Please wait..."; 
+            background({ 
+               cmd => \&get_rate,
+               cmd_args => [$c, @args],
+               last => [ \&print_getrate, \&last_cmd ],
+            });
+         } else {
+            &{$cmds{$c}->{cmd}}(@args);
+         }
+      } else {
+         &{$cmds{$c}->{cmd}}(@args);
+      }
+   } elsif ( $c eq 'help' ) {
       $args= $IRSSI{name};
       cmd_help( $args, $server, $witem);
    }
 }
 
+sub last_cmd {
+   my ($pn)= @_;
+   my @args= @{ $pn->{cmd_args} };
+   my $c = shift @args;
+   if ( exists $cmds{$c} ) {
+      &{$cmds{$c}->{cmd}}(@args);
+   }
+}
+
 sub cmd_help {
    my ($args, $server, $witem)=@_;
    $args=~ s/\s+//g;
@@ -979,15 +1039,13 @@ sub UNLOAD {
 Irssi::settings_add_bool($IRSSI{name}, $IRSSI{name}.'_integrate', 1);
 Irssi::settings_add_int($IRSSI{name}, $IRSSI{name}.'_cache_timeout', 24*60*60);
 
-my @cmds= qw/reload save getmeta info search check new install autorun update cpan contact/;
-push @cmds, qw/getrate rate ratings top help/;
 Irssi::command_bind($IRSSI{name}, \&cmd);
-foreach ( @cmds ) {
+foreach ( 'help', keys %cmds ) {
    Irssi::command_bind("$IRSSI{name} $_", \&cmd);
 }
 if ( Irssi::settings_get_bool($IRSSI{name}.'_integrate')) {
    Irssi::command_bind('script', \&cmd);
-   foreach ( @cmds ) {
+   foreach ( keys %cmds ) {
       Irssi::command_bind("script $_", \&cmd);
    }
 }

From 809ce7f6f57f71970a48424200743ce123bec37d Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Mon, 8 Mar 2021 17:44:02 +0100
Subject: [PATCH 15/22] fetch

---
 scripts/scriptassist2.pl | 94 ++++++++++++++++++++++++++++++++++++----
 1 file changed, 86 insertions(+), 8 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index b7376d9f2..fda050286 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -10,6 +10,7 @@
 use Digest::MD5 qw/md5_hex/;
 use Text::Wrap;
 use JSON::PP;
+use Cwd;
 #use debug;
 
 use Irssi;
@@ -90,6 +91,8 @@ END
 
 my %cmds;
 
+my ($fetch_system, %fetchsys);
+
 my %bg_process= ();
 
 sub background {
@@ -183,6 +186,10 @@ sub call_openurl {
 }
 
 sub init {
+   if ( $fetch_system eq '' ) {
+      cmd_fetchsearch();
+      $fetch_system='filefetch' if $fetch_system eq '';
+   }
    if ( -e "$path/cache.yml" ) {
       my $yml= CPAN::Meta::YAML->read("$path/cache.yml");
       $d= $yml->[0];
@@ -222,6 +229,12 @@ sub save {
 }
 
 sub fetch {
+   my ($uri)= @_;
+   my $fn= &{ $fetchsys{$fetch_system}->{cmd} }($uri);
+   return $fn;
+}
+
+sub fetch_filefetch {
    my ($uri)= @_;
    my ($ff, $w, $res);
 	local $File::Fetch::WARN=0;
@@ -235,6 +248,61 @@ sub fetch {
    return $res;
 }
 
+sub fetch_wget {
+   my ($uri)= @_;
+   my $opwd= getcwd;
+   chdir $path;
+   system('wget', '-q', '--no-check-certificate', '-Ofetch.tmp', $uri);
+   chdir $opwd;
+   if ( $? ==0 ) {
+      return 'fetch.tmp';
+   }
+}
+
+sub fetch_curl {
+   my ($uri)= @_;
+   my $opwd= getcwd;
+   chdir $path;
+   system('curl', '-s', '--insecure', '-ofetch.tmp', $uri);
+   chdir $opwd;
+   if ( $? ==0 ) {
+      return 'fetch.tmp';
+   }
+}
+
+%fetchsys= (
+   filefetch=> {
+      cmd=> \&fetch_filefetch,
+      rate=> 0,
+   },
+   wget=> {
+      cmd=> \&fetch_wget,
+      rate=> 2,
+   },
+   curl=> {
+      cmd=> \&fetch_curl,
+      rate=> 1,
+   },
+);
+
+sub cmd_fetchsearch {
+   my $turl="https://irssi.org/robots.txt";
+   foreach my $k ( sort { $fetchsys{$a}->{rate} <=> $fetchsys{$b}->{rate} } keys %fetchsys ) {
+      print_short "test $k";
+      my $fn= &{ $fetchsys{$k}->{cmd} }($turl);
+      next if $fn eq '' ;
+      open my $fi, "<", "$path/$fn";
+      my @fs = stat $fi;
+      close $fi;
+      unlink "$path/$fn";
+      next if $fs[7] < 7;
+      print_short "set $k";
+      $fetch_system=$k;
+      Irssi::settings_set_str($IRSSI{name}.'_fetch_system', $k);
+      last;
+   }
+}
+
 sub getmeta {
    my @msg;
    foreach my $n ( @{ $d->{rconfig} } ) {
@@ -272,16 +340,18 @@ sub cmd_getmeta {
 
 sub print_getmeta {
    my ( $pn ) = @_;
-   # write back to main!
-   $d->{rscripts} = $pn->{res}->[0]->{rscripts} ;
-   $d->{rstat} = $pn->{res}->[0]->{rstat} ;
-   foreach my $n ( @{ $d->{rconfig} } ) {
-      $source{$n->{name}}= $n;
+   if ( scalar (@{$pn->{res}->[1]}) ==0 ) {
+      # write back to main!
+      $d->{rscripts} = $pn->{res}->[0]->{rscripts} ;
+      $d->{rstat} = $pn->{res}->[0]->{rstat} ;
+      foreach my $n ( @{ $d->{rconfig} } ) {
+         $source{$n->{name}}= $n;
+      }
+      print_short "database cache updatet"; 
    }
    foreach my $s (@{$pn->{res}->[1]} ) {
       print_short $s; 
    }
-   print_short "database cache updatet"; 
 }
 
 sub cmd_reload {
@@ -347,6 +417,7 @@ sub cmd_info {
             push @r, sinfo 11, "Authors", $n->{authors};
             push @r, sinfo 11, "Contact", $n->{contact};
             push @r, sinfo 11, "Description", $n->{description};
+            push @r, sinfo 11, "Modified", $n->{modified};
             if ( exists $n->{modules} ) {
                push @r, " ";
                push @r, "  Needed Perl modules:";
@@ -936,6 +1007,9 @@ sub cmd_top {
          cmd=> \&cmd_top,
          rate=>1,
    },
+   fetchsearch=> {
+         cmd=> \&cmd_fetchsearch,
+   },
 );
 
 sub cmd {
@@ -1016,7 +1090,10 @@ sub sig_setup_changed {
    if ( !-e $path ) {
       mkdir $path;
    }
-
+   my $fs= Irssi::settings_get_str($IRSSI{name}.'_fetch_system');
+   if ( exists $fetchsys{ $fs } ) {
+      $fetch_system= $fs;
+   }
 }
 
 sub UNLOAD {
@@ -1036,7 +1113,8 @@ sub UNLOAD {
 
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
 Irssi::settings_add_bool($IRSSI{name} ,$IRSSI{name}.'_autorun_link', 1);
-Irssi::settings_add_bool($IRSSI{name}, $IRSSI{name}.'_integrate', 1);
+Irssi::settings_add_bool($IRSSI{name}, $IRSSI{name}.'_integrate', 0);
+Irssi::settings_add_str($IRSSI{name}, $IRSSI{name}.'_fetch_system', '');
 Irssi::settings_add_int($IRSSI{name}, $IRSSI{name}.'_cache_timeout', 24*60*60);
 
 Irssi::command_bind($IRSSI{name}, \&cmd);

From d3e29e82ecad315896a8a63a64015748d1913c98 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Wed, 10 Mar 2021 18:58:36 +0100
Subject: [PATCH 16/22] bsd fetch

---
 scripts/scriptassist2.pl | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index fda050286..2951c4a0c 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -270,6 +270,17 @@ sub fetch_curl {
    }
 }
 
+sub fetch_fetch {
+   my ($uri)= @_;
+   my $opwd= getcwd;
+   chdir $path;
+   system('fetch','-q', '--no-verify-peer', '--no-verify-hostname', '-ofetch.tmp', $uri);
+   chdir $opwd;
+   if ( $? ==0 ) {
+      return 'fetch.tmp';
+   }
+}
+
 %fetchsys= (
    filefetch=> {
       cmd=> \&fetch_filefetch,
@@ -283,6 +294,10 @@ sub fetch_curl {
       cmd=> \&fetch_curl,
       rate=> 1,
    },
+   fetch=> {
+      cmd=> \&fetch_fetch,
+      rate=> 3,
+   },
 );
 
 sub cmd_fetchsearch {

From 4f12e430b7335271165275c3b50b0eef6f58483e Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sat, 13 Mar 2021 14:37:42 +0100
Subject: [PATCH 17/22] bug

---
 scripts/scriptassist2.pl | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 2951c4a0c..791f812f8 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -234,6 +234,15 @@ sub fetch {
    return $fn;
 }
 
+sub url2target {
+   my ( $url )=@_;
+   my $t= "fetch.tmp";
+   if ( $url=~ m#/([^/]*\.pl)$# ) {
+      $t=$1;
+   }
+   return $t;
+}
+
 sub fetch_filefetch {
    my ($uri)= @_;
    my ($ff, $w, $res);
@@ -251,33 +260,36 @@ sub fetch_filefetch {
 sub fetch_wget {
    my ($uri)= @_;
    my $opwd= getcwd;
+   my $t= url2target $uri;
    chdir $path;
-   system('wget', '-q', '--no-check-certificate', '-Ofetch.tmp', $uri);
+   system('wget', '-q', '--no-check-certificate', '-O', $t, $uri);
    chdir $opwd;
    if ( $? ==0 ) {
-      return 'fetch.tmp';
+      return $t;
    }
 }
 
 sub fetch_curl {
    my ($uri)= @_;
    my $opwd= getcwd;
+   my $t= url2target $uri;
    chdir $path;
-   system('curl', '-s', '--insecure', '-ofetch.tmp', $uri);
+   system('curl', '-s', '--insecure', '-o',$t, $uri);
    chdir $opwd;
    if ( $? ==0 ) {
-      return 'fetch.tmp';
+      return $t;
    }
 }
 
 sub fetch_fetch {
    my ($uri)= @_;
    my $opwd= getcwd;
+   my $t= url2target $uri;
    chdir $path;
-   system('fetch','-q', '--no-verify-peer', '--no-verify-hostname', '-ofetch.tmp', $uri);
+   system('fetch','-q', '--no-verify-peer', '--no-verify-hostname', '-o', $t, $uri);
    chdir $opwd;
    if ( $? ==0 ) {
-      return 'fetch.tmp';
+      return $t;
    }
 }
 

From 9414b8937dbc7cb377b4e8e0bc92ad26e012910d Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sat, 13 Mar 2021 16:32:09 +0100
Subject: [PATCH 18/22] self check

---
 scripts/scriptassist2.pl | 41 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 791f812f8..d7edfdc94 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -26,6 +26,7 @@
     changed => '2021-02-13',
     modules => '',
     commands=> 'scriptassist2',
+    selfcheckcmd=> 'scriptassist2 selfcheck',
 );
 
 my $help = << "END";
@@ -92,6 +93,7 @@ END
 my %cmds;
 
 my ($fetch_system, %fetchsys);
+my ($selfcheck);
 
 my %bg_process= ();
 
@@ -975,6 +977,42 @@ sub cmd_top {
    print_rating 'top', $maxl, \%srate;
 }
 
+sub cmd_selfcheck {
+   my $t=19;
+   print_short "start self check ( ${t}s )";
+   $selfcheck->{metalast}= $d->{rstat}->{irssi}->{last};
+   $selfcheck->{metalast}=0 if !defined $selfcheck->{metalast};
+   $selfcheck->{ratelast}= $d->{rrate_state}->{last};
+   $selfcheck->{ratelast}=0 if !defined $selfcheck->{ratelast};
+   cmd_getrate();
+   cmd_getmeta();
+   Irssi::timeout_add_once($t*1000, \&selfcheck, '' );
+}
+
+sub selfcheck {
+   print_short "check results";
+   my $s='ok';
+   if (  ! defined $d->{rstat}->{irssi}->{last} ||
+         $selfcheck->{metalast} == $d->{rstat}->{irssi}->{last} ) {
+      $s= 'Error: fetch getmeta';
+      print_short $s;
+   } elsif (scalar( keys %{$d->{rscripts}->{irssi}} ) < 50 ) {
+      $s= 'Error: meta result count ('.scalar( keys %{$d->{rscripts}->{irssi}} ).')';
+      print_short $s;
+   }
+   if ( !defined $d->{rrate_state}->{last} || 
+         $selfcheck->{ratelast} == $d->{rrate_state}->{last} ) {
+      $s= 'Error: fetch getrate';
+      print_short $s;
+   } elsif ( scalar( keys %srate) <5 ){
+      $s= 'Error: srate result count ('.scalar( keys %srate).')';
+      print_short $s;
+   }
+   print_short "self check ok" if $s eq "ok";
+   my $schs =  exists $Irssi::Script::{'selfcheckhelperscript::'};
+   Irssi::command("selfcheckhelperscript $s") if ( $schs );
+}
+
 %cmds= (
    reload=> {
          cmd=> \&cmd_reload,
@@ -1037,6 +1075,9 @@ sub cmd_top {
    fetchsearch=> {
          cmd=> \&cmd_fetchsearch,
    },
+   selfcheck=> {
+         cmd=> \&cmd_selfcheck,
+   },
 );
 
 sub cmd {

From 99c72aaa390d6e80a70879ee4facba40ccd0b11e Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sat, 13 Mar 2021 18:46:29 +0100
Subject: [PATCH 19/22] help + format

---
 scripts/scriptassist2.pl | 98 +++++++++++++++++++++++-----------------
 1 file changed, 56 insertions(+), 42 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index d7edfdc94..a48840648 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -17,16 +17,17 @@
 
 $VERSION = '0.01';
 %IRSSI = (
-    authors => 'bw1',
-    contact => 'bw1@aol.at',
-    name => 'scriptassist2',
-    description   => 'This script really does nothing. Sorry.',
-    license => 'lgpl',
-    url     => 'https://scripts.irssi.org/',
-    changed => '2021-02-13',
-    modules => '',
-    commands=> 'scriptassist2',
-    selfcheckcmd=> 'scriptassist2 selfcheck',
+   authors     => 'bw1',
+   contact     => 'bw1@aol.at',
+   name        => 'scriptassist2',
+   description => 'keeps your scripts on the cutting edge',
+   license     => 'lgpl',
+   url         => 'https://scripts.irssi.org/',
+   changed     => '2021-02-13',
+   modules     => 'POSIX File::Glob CPAN::Meta::YAML File::Fetch Time::Piece Digest::file Digest::MD5 Text::Wrap'.
+                  'JSON::PP Cwd',
+   commands    => 'scriptassist2',
+   selfcheckcmd=> 'scriptassist2 selfcheck',
 );
 
 my $help = << "END";
@@ -34,9 +35,9 @@
   $IRSSI{name}
 %9Version%9
   $VERSION
-%9description%9
+%9Description%9
   $IRSSI{description}
-%9commands%9
+%9Commands%9
   /scriptassist check
       Check all loaded scripts for new available versions
   /scriptassist update <script|all>
@@ -63,7 +64,20 @@
       Retrieve and load the script
   /scriptassist autorun <script>
       Toggles automatic loading of <script>
+  /scriptassist reload
+      load config and more from 'cache.yml'
+  /scriptassist save
+      save config and more to 'cache.yml'
+  /scriptassist getmeta
+      download meta data from the web
+  /scriptassist getrate
+      download rating infos from the github
+  /scriptassist fetchsearch
+      autodetect a fetch mechanism
+  /scriptassist selfcheck
+      start a self check
 %9See also%9
+  https://scripts.irssi.org/scripts/scriptassist.pl
   https://perldoc.perl.org/perl.html
   https://github.com/irssi/irssi/blob/master/docs/perl.txt
   https://github.com/irssi/irssi/blob/master/docs/signals.txt
@@ -87,7 +101,7 @@ END
 # links to $d->{rconfig}->@
 my %source;
 
-# sortet rate;
+# sorted rate;
 my %srate;
 
 my %cmds;
@@ -151,19 +165,19 @@ sub sig_pidwait {
 
 sub print_box {
    my ( $head,  $foot, @inside)=@_;
-   Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_header', $head); 
+   Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_header', $head);
    foreach my $n ( @inside ) {
       foreach ( split /\n/, $n ) {
-         #Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_inside', $_); 
-         Irssi::print("%R|%n $_", MSGLEVEL_CLIENTCRAP); 
+         #Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_inside', $_);
+         Irssi::print("%R|%n $_", MSGLEVEL_CLIENTCRAP);
       }
    }
-   Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_footer', $foot); 
+   Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'box_footer', $foot);
 }
 
 sub print_short {
    my ( $str )= @_;
-   Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'short_msg', $str); 
+   Irssi::printformat(MSGLEVEL_CLIENTCRAP, 'short_msg', $str);
 }
 
 sub installed_version {
@@ -252,7 +266,7 @@ sub fetch_filefetch {
    $ff = File::Fetch->new (
       uri => $uri,
    );
-   $w = $ff->fetch(to => $path,); 
+   $w = $ff->fetch(to => $path,);
    if ( $w ) {
       $res= $ff->file;
    }
@@ -349,7 +363,7 @@ sub getmeta {
             }
             my $t=localtime();
             $d->{rstat}->{$n->{name}}->{last}= $t->epoch;
-            $d->{rstat}->{$n->{name}}->{digest}= $di; 
+            $d->{rstat}->{$n->{name}}->{digest}= $di;
             unlink "$path/$fn";
          }
       } else {
@@ -360,8 +374,8 @@ sub getmeta {
 }
 
 sub cmd_getmeta {
-   print_short "Please wait..."; 
-   background({ 
+   print_short "Please wait...";
+   background({
       cmd => \&getmeta,
       last => [ \&print_getmeta ],
    });
@@ -376,21 +390,21 @@ sub print_getmeta {
       foreach my $n ( @{ $d->{rconfig} } ) {
          $source{$n->{name}}= $n;
       }
-      print_short "database cache updatet"; 
+      print_short "database cache updatet";
    }
    foreach my $s (@{$pn->{res}->[1]} ) {
-      print_short $s; 
+      print_short $s;
    }
 }
 
 sub cmd_reload {
    init();
-   print_short "reloadet"; 
+   print_short "reloadet";
 }
 
 sub cmd_save {
    save();
-   print_short "write to disk"; 
+   print_short "write to disk";
 }
 
 sub sinfo {
@@ -617,8 +631,8 @@ sub cmd_install {
          push @sl, $s;
       }
    }
-   print_short "Please wait..."; 
-   background({ 
+   print_short "Please wait...";
+   background({
       cmd => \&bg_install,
       args => [ @sl ],
       last => [ \&print_install ],
@@ -635,7 +649,7 @@ sub bg_install {
             rename Irssi::get_irssi_dir()."/scripts/$fn", Irssi::get_irssi_dir()."/scripts/$fn.bak";
          }
          rename "$path/$fn", Irssi::get_irssi_dir()."/scripts/$fn";
-         push @r, $fn; 
+         push @r, $fn;
       }
    }
    return @r;
@@ -732,8 +746,8 @@ sub cmd_update {
          }
       }
    }
-   print_short "Please wait..."; 
-   background({ 
+   print_short "Please wait...";
+   background({
       cmd => \&bg_install,
       args => [ @r ],
       current => [ @current ],
@@ -830,11 +844,11 @@ sub get_rate {
             my $b=$n->{body};
             $b =~ m/([\w-]+\.pl)/;
             my $fn= $1;
-            my $p = $n->{reactions}->{'+1'} 
-                        + $n->{reactions}->{'hooray'} 
-                        + $n->{reactions}->{'rocket'} 
+            my $p = $n->{reactions}->{'+1'}
+                        + $n->{reactions}->{'hooray'}
+                        + $n->{reactions}->{'rocket'}
                         + $n->{reactions}->{'heart'} ;
-            my $m = $n->{reactions}->{'-1'} 
+            my $m = $n->{reactions}->{'-1'}
                         + $n->{reactions}->{'confused'};
             my $sum= $p-$m;
             if ( $p >0 || $m >0) {
@@ -866,8 +880,8 @@ sub cmd_getrate {
    }
    #use LWP::UserAgent;
    require LWP::UserAgent;
-   print_short "Please wait..."; 
-   background({ 
+   print_short "Please wait...";
+   background({
       cmd => \&get_rate,
       last => [ \&print_getrate ],
    });
@@ -1000,7 +1014,7 @@ sub selfcheck {
       $s= 'Error: meta result count ('.scalar( keys %{$d->{rscripts}->{irssi}} ).')';
       print_short $s;
    }
-   if ( !defined $d->{rrate_state}->{last} || 
+   if ( !defined $d->{rrate_state}->{last} ||
          $selfcheck->{ratelast} == $d->{rrate_state}->{last} ) {
       $s= 'Error: fetch getrate';
       print_short $s;
@@ -1096,8 +1110,8 @@ sub cmd {
             }
          }
          if ( $r ) {
-            print_short "Please wait..."; 
-            background({ 
+            print_short "Please wait...";
+            background({
                cmd => \&getmeta,
                cmd_args => [$c, @args],
                last => [ \&print_getmeta, \&last_cmd ],
@@ -1112,8 +1126,8 @@ sub cmd {
                return;
             }
             require LWP::UserAgent;
-            print_short "Please wait..."; 
-            background({ 
+            print_short "Please wait...";
+            background({
                cmd => \&get_rate,
                cmd_args => [$c, @args],
                last => [ \&print_getrate, \&last_cmd ],

From da46980ecbffebb61af45dfffacd466312a8c8b6 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sun, 14 Mar 2021 14:53:30 +0100
Subject: [PATCH 20/22] completet, split cache.yml

---
 scripts/scriptassist2.pl | 111 ++++++++++++++++++++++++++++++++-------
 1 file changed, 91 insertions(+), 20 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index a48840648..4efd773ba 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -38,43 +38,43 @@
 %9Description%9
   $IRSSI{description}
 %9Commands%9
-  /scriptassist check
+  /$IRSSI{name} check
       Check all loaded scripts for new available versions
-  /scriptassist update <script|all>
+  /$IRSSI{name} update <script|all>
       Update the selected or all script to the newest version
-  /scriptassist search <query>
+  /$IRSSI{name} search <query>
       Search the script database
-  /scriptassist info <scripts>
+  /$IRSSI{name} info <scripts>
       Display information about <scripts>
-  /scriptassist ratings <scripts|all>
+  /$IRSSI{name} ratings <scripts|all>
       Retrieve the average ratings of the the scripts
-  /scriptassist top <num>
+  /$IRSSI{name} top <num>
       Retrieve the first <num> top rated scripts
-  /scriptassist new <num>
+  /$IRSSI{name} new <num>
       Display the newest <num> scripts
-  /scriptassist rate <script>
+  /$IRSSI{name} rate <script>
       Rate the script if you like it
-  /scriptassist contact <script>
+  /$IRSSI{name} contact <script>
       Write an email to the author of the script
       (Requires OpenURL)
-  /scriptassist cpan <module>
+  /$IRSSI{name} cpan <module>
       Visit CPAN to look for missing Perl modules
       (Requires OpenURL)
-  /scriptassist install <script>
+  /$IRSSI{name} install <script>
       Retrieve and load the script
-  /scriptassist autorun <script>
+  /$IRSSI{name} autorun <script>
       Toggles automatic loading of <script>
-  /scriptassist reload
+  /$IRSSI{name} reload
       load config and more from 'cache.yml'
-  /scriptassist save
+  /$IRSSI{name} save
       save config and more to 'cache.yml'
-  /scriptassist getmeta
+  /$IRSSI{name} getmeta
       download meta data from the web
-  /scriptassist getrate
+  /$IRSSI{name} getrate
       download rating infos from the github
-  /scriptassist fetchsearch
+  /$IRSSI{name} fetchsearch
       autodetect a fetch mechanism
-  /scriptassist selfcheck
+  /$IRSSI{name} selfcheck
       start a self check
 %9See also%9
   https://scripts.irssi.org/scripts/scriptassist.pl
@@ -108,6 +108,7 @@ END
 
 my ($fetch_system, %fetchsys);
 my ($selfcheck);
+my (@comp_start,%comp_scripts);
 
 my %bg_process= ();
 
@@ -206,9 +207,21 @@ sub init {
       cmd_fetchsearch();
       $fetch_system='filefetch' if $fetch_system eq '';
    }
+   #if ( -e "$path/cache.yml" ) {
+   #   my $yml= CPAN::Meta::YAML->read("$path/cache.yml");
+   #   $d= $yml->[0];
+   #}
+   if ( -e "$path/config.yml" ) {
+      my $yml= CPAN::Meta::YAML->read("$path/config.yml");
+      foreach my $k ( keys %{ $yml->[0] } ) {
+         $d->{$k}= $yml->[0]->{$k};
+      }
+   }
    if ( -e "$path/cache.yml" ) {
       my $yml= CPAN::Meta::YAML->read("$path/cache.yml");
-      $d= $yml->[0];
+      foreach my $k ( keys %{ $yml->[0] } ) {
+         $d->{$k}= $yml->[0]->{$k};
+      }
    }
    if ( ref($d) ne 'HASH' || ! exists $d->{rconfig} ) {
       $d= undef;
@@ -237,10 +250,22 @@ sub init {
          }
       }
    }
+   init_complete();
 }
 
 sub save {
-   my $yml= CPAN::Meta::YAML->new( $d );
+   my $config;
+   $config->{rconfig} = $d->{rconfig};
+   $config->{autorun} = $d->{autorun};
+   my $ymlco= CPAN::Meta::YAML->new( $config );
+   $ymlco->write("$path/config.yml");
+   my $cache;
+   foreach my $k ( keys %$d ) {
+      next if ( $k eq 'rconfig');
+      next if ( $k eq 'autorun');
+      $cache->{$k} = $d->{$k};
+   }
+   my $yml= CPAN::Meta::YAML->new( $cache );
    $yml->write("$path/cache.yml");
 }
 
@@ -1040,6 +1065,7 @@ sub selfcheck {
    info=> {
          cmd=> \&cmd_info,
          meta=>1,
+         complete=>'scripts',
    },
    search=> {
          cmd=> \&cmd_search,
@@ -1055,13 +1081,16 @@ sub selfcheck {
    },
    install=> {
          cmd=> \&cmd_install,
+         complete=>'scripts',
    },
    autorun=> {
          cmd=> \&cmd_autorun,
+         complete=>'scripts',
    },
    update=> {
          cmd=> \&cmd_update,
          meta=>1,
+         complete=>'scripts_all',
    },
    cpan=> {
          cmd=> \&cmd_cpan,
@@ -1070,6 +1099,7 @@ sub selfcheck {
    contact=> {
          cmd=> \&cmd_contact,
          meta=>1,
+         complete=>'scripts',
    },
    getrate=> {
          cmd=> \&cmd_getrate,
@@ -1077,10 +1107,12 @@ sub selfcheck {
    rate=> {
          cmd=> \&cmd_rate,
          rate=>1,
+         complete=>'scripts',
    },
    ratings=> {
          cmd=> \&cmd_ratings,
          rate=>1,
+         complete=>'scripts_all',
    },
    top=> {
          cmd=> \&cmd_top,
@@ -1178,6 +1210,44 @@ sub sig_setup_changed {
    }
 }
 
+sub init_complete {
+   @comp_start=();
+   foreach my $k ( keys %cmds ){
+      next unless exists $cmds{$k}->{complete};
+      my $c="/$IRSSI{name} $k";
+      push @comp_start, $c;
+      if (Irssi::settings_get_bool($IRSSI{name}.'_integrate') ) {
+         my $c="/script $k";
+         push @comp_start, $c;
+      }
+   }
+   %comp_scripts=();
+   foreach my $n ( reverse @{ $d->{rconfig} } ) {
+      foreach my $k ( keys %{ $d->{rscripts}->{$n->{name}} } ) {
+         if ( !exists $comp_scripts{$k} ){
+            $comp_scripts{$k}=[];
+         }
+         push @{$comp_scripts{$k}}, $n->{name};
+      }
+   }
+}
+
+sub do_complete {
+	my ($strings, $window, $word, $linestart, $want_space) = @_;
+	my $ok;
+	foreach (@comp_start) {
+		$ok=1 if ($linestart =~ m/^$_/);
+	}
+	return unless $ok;
+   my @args=split /\s+/, $linestart;
+   my @str;
+   push @str, 'all' if ($cmds{$args[1]}->{complete} eq 'scripts_all');
+   push @str, grep { m/^$word/} keys %comp_scripts;
+   @$strings= @str;
+	$$want_space = 1;
+	Irssi::signal_stop;
+}
+
 sub UNLOAD {
    save();
 }
@@ -1192,6 +1262,7 @@ sub UNLOAD {
 
 Irssi::signal_add('setup changed', \&sig_setup_changed);
 Irssi::signal_add('pidwait', \&sig_pidwait);
+Irssi::signal_add_first('complete word',  \&do_complete);
 
 Irssi::settings_add_str($IRSSI{name} ,$IRSSI{name}.'_path', 'scriptassist2');
 Irssi::settings_add_bool($IRSSI{name} ,$IRSSI{name}.'_autorun_link', 1);

From 7cde079fa6551d1295576ce97760e3325320839c Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Sun, 14 Mar 2021 17:12:12 +0100
Subject: [PATCH 21/22] bug in fetch

---
 scripts/scriptassist2.pl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 4efd773ba..1cc4f2cdb 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -308,6 +308,7 @@ sub fetch_wget {
    if ( $? ==0 ) {
       return $t;
    }
+   return undef;
 }
 
 sub fetch_curl {
@@ -315,11 +316,12 @@ sub fetch_curl {
    my $opwd= getcwd;
    my $t= url2target $uri;
    chdir $path;
-   system('curl', '-s', '--insecure', '-o',$t, $uri);
+   system('curl', '-f', '-s', '--insecure', '-o',$t, $uri);
    chdir $opwd;
    if ( $? ==0 ) {
       return $t;
    }
+   return undef;
 }
 
 sub fetch_fetch {
@@ -327,11 +329,12 @@ sub fetch_fetch {
    my $opwd= getcwd;
    my $t= url2target $uri;
    chdir $path;
-   system('fetch','-q', '--no-verify-peer', '--no-verify-hostname', '-o', $t, $uri);
+   system('fetch','-q', '-1', '--no-verify-peer', '--no-verify-hostname', '-o', $t, $uri);
    chdir $opwd;
    if ( $? ==0 ) {
       return $t;
    }
+   return undef;
 }
 
 %fetchsys= (

From 00e8bcde0a6fcf63271edaf7a15590d4ffca2109 Mon Sep 17 00:00:00 2001
From: bw1 <bw1@aol.at>
Date: Mon, 29 Mar 2021 23:08:14 +0200
Subject: [PATCH 22/22] install -auto

---
 scripts/scriptassist2.pl | 95 ++++++++++++++++++++++++----------------
 1 file changed, 57 insertions(+), 38 deletions(-)

diff --git a/scripts/scriptassist2.pl b/scripts/scriptassist2.pl
index 1cc4f2cdb..b29893524 100644
--- a/scripts/scriptassist2.pl
+++ b/scripts/scriptassist2.pl
@@ -62,6 +62,8 @@
       (Requires OpenURL)
   /$IRSSI{name} install <script>
       Retrieve and load the script
+  /$IRSSI{name} install -auto <script>
+      Retrieve, load the script and add to autorun
   /$IRSSI{name} autorun <script>
       Toggles automatic loading of <script>
   /$IRSSI{name} reload
@@ -645,6 +647,10 @@ sub cmd_new {
 sub cmd_install {
    my ( @args )= @_;
    my @sl;
+   my $auto;
+   if ( $args[0] eq '-auto' ) {
+      $auto= shift @args;
+   }
    foreach my $sn ( @args ) {
       $sn =~ s/\.pl$//i;
       my $fn ="$sn.pl";
@@ -663,6 +669,7 @@ sub cmd_install {
    background({
       cmd => \&bg_install,
       args => [ @sl ],
+      auto => $auto,
       last => [ \&print_install ],
    });
 }
@@ -683,6 +690,48 @@ sub bg_install {
    return @r;
 }
 
+sub autorun {
+   my ( $sn, $on ) =@_;
+   $sn =~ s/\.pl$//i;
+   my $fn = "$sn.pl";
+   my $of=Irssi::get_irssi_dir()."/scripts/$fn";
+   if (Irssi::settings_get_bool($IRSSI{name}.'_autorun_link') ) {
+      my $af=Irssi::get_irssi_dir()."/scripts/autorun/$fn";
+      if (-e $af && !defined $on ) {
+         if ( -l $af ) {
+            unlink $af;
+            print_short "Autorun of $sn disabled";
+         } else {
+            print_short "$fn is not a symlink";
+         }
+      } else {
+         if ( -e $of && !(-e $af) ) {
+            symlink "../$fn", $af;
+            print_short "Autorun of $sn enabled";
+         }
+      }
+   } else {
+      if ( !exists $d->{autorun} ) {
+         $d->{autorun}=[];
+      }
+      my $r;
+      for (my $c=0; $c < scalar( @{ $d->{autorun} } ) ; $c++) {
+         if ($d->{autorun}->[$c] eq $fn) {
+            if ( ! defined $on ) {
+               splice @{ $d->{autorun} } , $c ,1;
+               print_short "Autorun of $sn disabled";
+            }
+            $r=1;
+            last;
+         }
+      }
+      if (!$r && -e $of ) {
+         push @{ $d->{autorun} }, $fn;
+         print_short "Autorun of $sn enabled";
+      }
+   }
+}
+
 sub print_install {
    my ( $pn ) = @_;
    my @res;
@@ -692,6 +741,9 @@ sub print_install {
       if ( !installed_version $sn ) {
          Irssi::command("script load $fn");
          push @res, "%go%n %9$sn%9 installed";
+         if ( $pn->{auto} eq '-auto' ) {
+            autorun $sn, 1;
+         }
       } else {
          push @res, "%ro%n %9$sn%9 already loaded, please try 'update'";
       }
@@ -702,42 +754,7 @@ sub print_install {
 sub cmd_autorun {
    my ( @args )= @_;
    foreach my $sn ( @args ){
-      $sn =~ s/\.pl$//i;
-      my $fn = "$sn.pl";
-      my $of=Irssi::get_irssi_dir()."/scripts/$fn";
-      if (Irssi::settings_get_bool($IRSSI{name}.'_autorun_link') ) {
-         my $af=Irssi::get_irssi_dir()."/scripts/autorun/$fn";
-         if (-e $af ) {
-            if ( -l $af ) {
-               unlink $af;
-               print_short "Autorun of $sn disabled";
-            } else {
-               print_short "$fn is not a symlink";
-            }
-         } else {
-            if ( -e $of ) {
-               symlink "../$fn", $af;
-               print_short "Autorun of $sn enabled";
-            }
-         }
-      } else {
-         if ( !exists $d->{autorun} ) {
-            $d->{autorun}=[];
-         }
-         my $r;
-         for (my $c=0; $c < scalar( @{ $d->{autorun} } ) ; $c++) {
-            if ($d->{autorun}->[$c] eq $fn) {
-               splice @{ $d->{autorun} } , $c ,1;
-               $r=1;
-               print_short "Autorun of $sn disabled";
-               last;
-            }
-         }
-         if (!$r && -e $of ) {
-            push @{ $d->{autorun} }, $fn;
-            print_short "Autorun of $sn enabled";
-         }
-      }
+      autorun $sn;
    }
 }
 
@@ -1084,7 +1101,7 @@ sub selfcheck {
    },
    install=> {
          cmd=> \&cmd_install,
-         complete=>'scripts',
+         complete=>'scripts_auto',
    },
    autorun=> {
          cmd=> \&cmd_autorun,
@@ -1245,7 +1262,9 @@ sub do_complete {
    my @args=split /\s+/, $linestart;
    my @str;
    push @str, 'all' if ($cmds{$args[1]}->{complete} eq 'scripts_all');
-   push @str, grep { m/^$word/} keys %comp_scripts;
+   push @str, '-auto' if ($cmds{$args[1]}->{complete} eq 'scripts_auto' && scalar(@args) == 2);
+   push @str,  sort keys %comp_scripts;
+   @str= grep { m/^$word/} @str;
    @$strings= @str;
 	$$want_space = 1;
 	Irssi::signal_stop;