Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Was develop/4.0 branch abandoned? #272

Open
hiroshi opened this issue May 29, 2019 · 4 comments
Open

[question] Was develop/4.0 branch abandoned? #272

hiroshi opened this issue May 29, 2019 · 4 comments
Assignees

Comments

@hiroshi
Copy link

hiroshi commented May 29, 2019

I'm trying to update an app that depended on APIKit 4.0.0-beta.1 (swift 3) to current swift version. The app is using progressHandler.
However, 4.0.0-beta.1 tag is on develop/4.0 branch. It seems that the branch is not merged into master and latest release tag 5.0.0.

@ikesyo
Copy link
Collaborator

ikesyo commented May 29, 2019

I'm not sure about that development branch/the beta tag.

@ishkawa Could you clarify this?

@hiroshi
Copy link
Author

hiroshi commented May 29, 2019

Thanks for your response, @ikesyo.

Just FYI, I'm trying to merge current master into the develop/4.0 branch.
https://github.com/hiroshi/APIKit/tree/develop/4.0
Some tests are still failing so far...
Also, the app is not worked with Xcode 10.2.1 yet for other reasons...
I'll report if it works or failed....

Anyway, the progressHandler feature is not being to be merged in the main line, maybe I need to migrate to other solutions though...
(I don't mean to blame any of it. ;-)

@davdroman
Copy link

There are some PRs that went into develop/4.0 that never made it to master, for example #230. If the branch was abandoned, it'd be good to at least move all the missing commits to master for the next major release, since some of them are extremely useful features.

@417-72KI
Copy link
Contributor

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants