Avoid renaming unwanted part of the path in dataset loading scripts #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update update_probs to only update the probabilities, as the name implies * update semantic segmentation to update labels based on probabilities at the end of an update * Docstring for Returns updated * styling * build gui module --------- Co-authored-by: Benjamin Ummenhofer <[email protected]>
# Conflicts: # ci/run_ci.sh
In get_data method of KITTISplit class, paths are created by renaming some parts of other paths (like replacing 'velodyne' by 'label_2'. This can create problems if you work on full path (i.e. if you have a velodyne directory in the path)
ssheorey
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kitti.py, in get_data method of KITTISplit class, paths are created by renaming some parts of other paths (like replacing 'velodyne' by 'label_2'. This can create problems if you work on full path (i.e. if you have a velodyne directory in the path).
Same issues fixed in matterport_objects.py and waymo.py
This change is