Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dependency on pandas in Pypi metadata #5060

Open
3 tasks done
joshuagruenstein opened this issue Apr 28, 2022 · 2 comments
Open
3 tasks done

Unnecessary dependency on pandas in Pypi metadata #5060

joshuagruenstein opened this issue Apr 28, 2022 · 2 comments
Labels
bug Not a build issue, this is likely a bug.

Comments

@joshuagruenstein
Copy link

joshuagruenstein commented Apr 28, 2022

Checklist

Describe the issue

Open3D includes the following metadata in their releases to Pypi:

Requires-Dist: setuptools (>=40.8.0)
Requires-Dist: wheel (>=0.36.0)
Requires-Dist: numpy (>=1.18.0)
Requires-Dist: ipywidgets (>=7.6.0)
Requires-Dist: pygments (>=2.7.4)
Requires-Dist: jupyter-packaging (~=0.10)
Requires-Dist: jupyterlab (==3.*,>=3.0.0)
Requires-Dist: addict
Requires-Dist: pillow (>=8.2.0)
Requires-Dist: matplotlib (>=3)
Requires-Dist: numpy (>1.15)
Requires-Dist: pandas (>=1.0)
Requires-Dist: pyyaml (>=5.4.1)
Requires-Dist: scikit-learn (>=0.21)
Requires-Dist: tqdm
Requires-Dist: pyquaternion

However, the Open3D code does not actually depend on pandas: a ctrl-f through the code-base verifies this. Having this unnecessary dependency tricks build tools like Poetry into installing unnecessary packages, and in Poetry's case leads to exponentially longer build times.

Steps to reproduce the bug

Go to https://pypi.org/pypi/open3d/json to see the metadata. ctrl-f to see the pandas dependency.

Error message

N/A

Expected behavior

This dependency should not be required, and should be removed from the metadata on Pypi.

Open3D, Python and System information

N/A: this is verifiable from any browser.

Additional information

No response

@joshuagruenstein joshuagruenstein added the bug Not a build issue, this is likely a bug. label Apr 28, 2022
@johnthagen
Copy link
Contributor

johnthagen commented Jan 26, 2023

I believe related to

Could probably be fixed more holistically/permanently by:

For Poetry, (which uses the JSON API) see why the JSON API has inherent problems with packages like Open3D that have different dependencies depending on the platform:

@johnthagen
Copy link
Contributor

It looks like the ideal here is for Open3d to use markers (e.g. platform_system == "Windows") to explicitly mark the dependencies they have that differ between platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not a build issue, this is likely a bug.
Projects
None yet
Development

No branches or pull requests

2 participants