Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway component not enabled by .values #19799

Closed
howardjohn opened this issue Dec 26, 2019 · 6 comments · May be fixed by istio/operator#727
Closed

Gateway component not enabled by .values #19799

howardjohn opened this issue Dec 26, 2019 · 6 comments · May be fixed by istio/operator#727
Assignees
@richardwxn @ostromart
Labels
area/environments/operator Issues related to Operator or installation
Milestone
1.5

Comments

@howardjohn
Copy link
Member

--set values.gateways.istio-egressgateway.enabled=true does nothing -- egress is still disabled. --set values.gateways.istio-egressgateway.enabled=true --set gateways.components.egressGateway.enabled=true must be set, which is breaking the helm passthrough API
@howardjohn howardjohn added the area/environments/operator Issues related to Operator or installation label Dec 26, 2019
@howardjohn howardjohn added this to the 1.5 milestone Dec 26, 2019
@howardjohn howardjohn mentioned this issue Dec 26, 2019
Closed
@richardwxn
Copy link
Contributor

I checked the code and it seems like it is a gap not just for egressgateway. Take a look at the IsComponentEnabledInSpec function at https://github.com/istio/operator/blob/master/pkg/name/name.go#L142, it only check the enablement value from ISCP api node for istio components and only the thirdParty component which is not defined in ISCP would be check against values pass through as well.

@richardwxn
Copy link
Contributor

I would verify again and create a PR to fix it

@richardwxn richardwxn mentioned this issue Dec 30, 2019
Open
@myidpt
Copy link
Contributor

myidpt commented Jan 13, 2020

Hi Martin, can you help to take a look?

@richardwxn
Copy link
Contributor

The new PR to fix core component enablement issues after new operator API merge: #20244.

However, the enablement issue for addOnComponents seems more complicated, check detail here: #20316

@howardjohn howardjohn mentioned this issue Jan 20, 2020
Closed
@howardjohn howardjohn mentioned this issue Jan 28, 2020
Closed
@howardjohn
Copy link
Member Author

@richardwxn any update on this?

@richardwxn
Copy link
Contributor

@howardjohn the fix was merged already, closing it

@balamuru balamuru mentioned this issue Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardwxn richardwxn

@ostromart ostromart

Labels
area/environments/operator Issues related to Operator or installation
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

Check enablement from values part as well richardwxn/operator
5 participants
@myidpt @howardjohn @richardwxn @ostromart @istio-policy-bot