Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+f does not work in windows #12

Open
transilvlad opened this issue Jun 26, 2017 · 14 comments
Open

ctrl+f does not work in windows #12

transilvlad opened this issue Jun 26, 2017 · 14 comments

Comments

@transilvlad
Copy link

For some reason even in bash (ubuntu) mode it still does not work.
It opens manually and everything else works.

@davobutt
Copy link

davobutt commented Jul 7, 2017

I suspect this is related to vercel/hyper#1121 rather than hyper-search

@borekb
Copy link

borekb commented Sep 26, 2017

I'm not sure, even when I do manual Edit > Find > Toggle Find Bar, I get nothing. I'm on 2.0 though so that might be related?

@jq-87
Copy link

jq-87 commented Oct 5, 2017

Same on Mac

  • OS version and name: 10.12.5 - MacOS Sierra
  • Hyper.app version: 1.4.8

(Edit > Find > Toggle Find Bar) also does NOT work.

@jaanauati
Copy link
Owner

been doing a little digging on this, it seems the last updates made regarding hterm are causing this issue, will try to push a fix in the next couple of weeks

@ChristinWhite
Copy link

Just confirming, updated to Hyper 2.1.1 (Canary) from 1.x and command-f is no longer working.

High Sierra 10.13.1

@simmessa
Copy link

Also on Windows 10 (WLS - Bash) but you can fix this by forking the hyper-search plugin (with hpm) and edit the source:

$ hpm f hyper-search

then edit ~/.hyper_plugins/local/hyper-search/src/constants.js

and modify:

module.exports.LEAD_KEY = process.platform === 'darwin' ? 'Cmd' : 'Ctrl';
in:
module.exports.LEAD_KEY = process.platform === 'darwin' ? 'Cmd' : 'Alt';

So that Alt+f will open search input.

Cheers.

S.

@jaanauati
Copy link
Owner

just published a fix intended to deal with the issues you were getting for hyper >=2, not sure what's going with osx/hyper 1.48 though, it does work for me, can u guys all please give this a try again?

@simmessa i don't have a windows box handy to test this, can u please submit a pull request with that fix? i would really appreciate it.

thanks

@jaanauati jaanauati mentioned this issue Nov 24, 2017
@horseinthesky
Copy link

modify:
module.exports.LEAD_KEY = process.platform === 'darwin' ? 'Cmd' : 'Ctrl';
to:
module.exports.LEAD_KEY = process.platform === 'darwin' ? 'Cmd' : 'Alt';

in C:\Users\horseinthesky\.hyper_plugins\node_modules\hyper-search\src\constants.js
fixes work on Windows

but can we have horkeys settings in .hyper.js config?

Otherwise keys are being overridden after restart.

@Koslun
Copy link

Koslun commented Apr 17, 2018

This is still not working for me on my Windows box.

Using these plugins: ["hyperpower", "hyper-pane", "hyper-material-theme", "hyper-search"], with version 2.0.0 of Hyper.

Agree that a place to configure hot keys might be good enough. Especially since I believe this seems to be a bug with Hyper or one of its dependencies rather than with this library. Specifically this: vercel/hyper#1121 (comment).

@jaanauati
Copy link
Owner

jaanauati commented Jun 10, 2018

just pushed a fix for this in 0.0.10, new shortcuts is shift+ctrl-f

I still need to figure out what to do with shift+ctrl+g but that is another story, will review alternatives later.

Important note: keep in mind to restart hyper after updating.
thanks.

This was referenced Jun 10, 2018
@hassanalami
Copy link

I'm using Hyper 2.1.2 on Windows 7 and the Ctrl + F and Shift + Ctrl + F are not working

@jrhorn424
Copy link

This should be re-opened IMO.

@jaanauati jaanauati reopened this Jul 14, 2019
@yousifalraheem
Copy link

yousifalraheem commented Dec 12, 2019

This is easily fixed with this:

config: {
    // ...
    hyperSearchUI: {
        hotkey: "Ctrl+Shift+f" // Or whatever you want
    }
    // ...
}

@HoverBaum
Copy link

A fresh install of Hyper and hyper-search on Windows worked for me today.

Only needed to figure out that it is Ctrl + Shift + f that you need to press.

Repository owner deleted a comment from technosoft-admin Mar 4, 2024
Repository owner deleted a comment from Idris933 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

14 participants