Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the SlotsProvider set PAGE level targeting? #204

Open
patrick-mcdougle opened this issue Sep 10, 2020 · 0 comments
Open

Should the SlotsProvider set PAGE level targeting? #204

patrick-mcdougle opened this issue Sep 10, 2020 · 0 comments
Labels

Comments

@patrick-mcdougle
Copy link
Contributor

I was browsing through the codebase and I noticed the only way to set page level targeting (on the pubads service directly) is to use the function on the manager. IMO the slots provider would be a good place to set PAGE level targeting and the slot to be a good place to set SLOT targeting? What would you think of this change? Since we're doing manual merging in the slot today, I don't think this would be a bc break, it would just use the appropriate functions of the GPT library (and reduce the amount of merging you have to do manually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants