Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting docs on sizeMapping #236

Open
hayleybech opened this issue May 23, 2022 · 0 comments
Open

Conflicting docs on sizeMapping #236

hayleybech opened this issue May 23, 2022 · 0 comments
Labels

Comments

@hayleybech
Copy link

hayleybech commented May 23, 2022

We had trouble getting the sizeMapping to work when following your sizeMapping, until we clicked the links to read Google's own documentation. That's when we realised it seems to work by specifying minimum viewport sizes not maximum sizes.

Your docs and examples on this page https://react-dfp.surge.sh/adslot/sizemapping/ show viewports working as maximum widths, however Google's docs and examples here https://developers.google.com/publisher-tag/guides/ad-sizes#responsive_ads show them working as minimum widths, and after testing, that does seem to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants