Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform certain option fields before rendering #13

Open
jackHedaya opened this issue Feb 15, 2021 · 0 comments
Open

Transform certain option fields before rendering #13

jackHedaya opened this issue Feb 15, 2021 · 0 comments
Labels
improvement Makes a feature better ins some way
Milestone
Backlog

Comments

@jackHedaya
Copy link
Owner

Certain fields (like expirationDate) are stored as in non user-friendly formats. A transformation should be done before rendering. Question is whether it should be done on front end or backend.

Pros of Front over Back

  • Data is not affected and can be manipulated via expressions
  • Easier documentation coming from TD Ameritrade

Cons

  • Less intuitive expressions. For example, comparing data as a Unix time stamp is weird
  • More site bloat as a new dependency is likely going to be needed for Dates
@jackHedaya jackHedaya added this to the Backlog milestone Feb 15, 2021
@jackHedaya jackHedaya added the enhancement New feature or request label Feb 16, 2021
@jackHedaya jackHedaya added improvement Makes a feature better ins some way and removed enhancement New feature or request labels May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Makes a feature better ins some way
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@jackHedaya