Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zalsa_in/zalsa_out plugins select wrong default resampling quality #94

Open
farshield opened this issue Feb 1, 2025 · 1 comment
Open

Comments

@farshield
Copy link

There's a bug in the default resampling quality selection. This happens when the user does not specify the quality explicitly using the command-line flag -Q:

jack_load usb_in zalsa_in -i "-d hw:USB -r 48000 -p 256 -n 3"

Instead of relying on the automatic calculation (based on the sampling rate of the Jack server), it always defaults to 16.

For a Jack server running at 48 kHz, the default resampling quality should be 32, as is the case with the zita-ajbridge tools. For 44.1 kHz, it should be 48, and so on.

To work around this, the user has to explicitly set the quality:

jack_load usb_in zalsa_in -i "-d hw:USB -r 48000 -p 256 -n 3 -Q 32"
@farshield
Copy link
Author

Pull request is up: #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant