update_in_batches should take the same param types as update_all

[andyvb]

Currently #update_in_batches only accepts Hash, but it should accept the same types of arguments as #update_all (and the same arguments), namely string, array, or hash. Also, might be worth checking if there any arguments that are accepted by both find_in_batches AND update_all, that could conflict?

Anyway doing this:

MyModel.update_in_batches('foo = bar')

Crashes with this:

TypeError: no implicit conversion of Symbol into String
    from .../update_in_batches-0.0.2/lib/update_in_batches.rb:6:in `delete'
    from .../update_in_batches-0.0.2/lib/update_in_batches.rb:6:in `update_in_batches'

[jakeonrails]

I somehow missed this! Great request. Unsure if I'm going to make the change right now - are you still using this gem?

[NuckChorris]

Isn't this gem equivalent to the following in modern versions of Rails, and can thus be deprecated entirely?

model.in_batches { |batch| batch.update_all() }

[jakeonrails]

Yup! The in_batches method is superior as it's more flexible and can handle different types of operations (like deletes). Anyone using this gem in a recent version of Rails could replace it with in_batches.