rubocop: fixes.

Author: James Moriarty

.rubocop.yml

@@ -0,0 +1,4 @@
+Documentation:
+  Enabled: false
+Metrics/LineLength:
+  Max: 120

Gemfile

@@ -2,20 +2,21 @@ source 'https://rubygems.org'
 
 ruby '2.3.0'
 
-gem 'sinatra',    '~> 1'
+gem 'aws-sdk'
+gem 'google-cloud-storage'
 gem 'grape',      '~> 0.11'
-gem 'roar',       '~> 1'
 gem 'grape-roar', '~> 0.3'
-gem 'aws-sdk',    '~> 2'
-gem 'google-cloud-storage'
 gem 'mini_magick'
 gem 'puma'
+gem 'roar'
+gem 'sinatra'
 
 group 'test' do
-  gem 'rake', '~> 10.0'
+  gem 'codeclimate-test-reporter'
   gem 'pry'
-  gem 'rspec'
   gem 'rack-test'
+  gem 'rake', '~> 10.0'
+  gem 'rspec'
+  gem 'rubocop', require: false
   gem 'simplecov'
-  gem 'codeclimate-test-reporter'
 end

Gemfile.lock

@@ -8,6 +8,7 @@ GEM
       tzinfo (~> 1.1)
     addressable (2.5.0)
       public_suffix (~> 2.0, >= 2.0.2)
+    ast (2.3.0)
     aws-sdk (2.5.5)
       aws-sdk-resources (= 2.5.5)
     aws-sdk-core (2.5.5)
@@ -95,6 +96,9 @@ GEM
     mustermann19 (0.4.4)
       enumerable-lazy
     os (0.9.6)
+    parser (2.3.3.0)
+      ast (~> 2.2)
+    powerpack (0.1.1)
     pry (0.10.3)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
@@ -108,6 +112,7 @@ GEM
       rack
     rack-test (0.6.3)
       rack (>= 1.0)
+    rainbow (2.1.0)
     rake (10.5.0)
     representable (2.3.0)
       uber (~> 0.0.7)
@@ -127,6 +132,13 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.4.0)
     rspec-support (3.4.1)
+    rubocop (0.46.0)
+      parser (>= 2.3.1.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
     signet (0.7.3)
       addressable (~> 2.3)
       faraday (~> 0.9)
@@ -147,6 +159,7 @@ GEM
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
     uber (0.0.15)
+    unicode-display_width (1.1.1)
     virtus (1.0.5)
       axiom-types (~> 0.1)
       coercible (~> 1.0)
@@ -157,7 +170,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  aws-sdk (~> 2)
+  aws-sdk
   codeclimate-test-reporter
   google-cloud-storage
   grape (~> 0.11)
@@ -167,10 +180,11 @@ DEPENDENCIES
   puma
   rack-test
   rake (~> 10.0)
-  roar (~> 1)
+  roar
   rspec
+  rubocop
   simplecov
-  sinatra (~> 1)
+  sinatra
 
 BUNDLED WITH
    1.11.2

Rakefile

@@ -3,7 +3,7 @@ begin
 
   RSpec::Core::RakeTask.new(:spec)
 
-  task :default => :spec
+  task default: :spec
 rescue LoadError
-  # no rspec available
+  puts 'no rspec available'
 end

bin/console

@@ -1,10 +1,10 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "poto"
+require 'bundler/setup'
+require 'poto'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-require "pry"
+require 'pry'
 Pry.start

bin/poto-aws-s3

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 
-require "rack"
+require 'rack'
 
-app, options = Rack::Builder.new_from_string <<-EOF
+app, _options = Rack::Builder.new_from_string <<-EOF
 $LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
 
 require "poto"
@@ -25,5 +25,5 @@ EOF
 
 Rack::Server.start(
   app:  app,
-  Port: ENV.fetch("PORT", 9292)
+  Port: ENV.fetch('PORT', 9292)
 )

bin/poto-google-cloud-storage

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 
-require "rack"
+require 'rack'
 
-app, options = Rack::Builder.new_from_string <<-EOF
+app, _options = Rack::Builder.new_from_string <<-EOF
 $LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
 
 require "poto"
@@ -30,5 +30,5 @@ EOF
 
 Rack::Server.start(
   app:  app,
-  Port: ENV.fetch("PORT", 9292)
+  Port: ENV.fetch('PORT', 9292)
 )

lib/poto.rb

@@ -1,11 +1,11 @@
 $LOAD_PATH.unshift File.dirname(__FILE__)
 
-require "active_support"
-require "active_support/core_ext/object/to_param"
-require "active_support/core_ext/object/try"
-require "poto/version"
-require "poto/api"
-require "poto/image_proxy"
-require "poto/app"
+require 'active_support'
+require 'active_support/core_ext/object/to_param'
+require 'active_support/core_ext/object/try'
+require 'poto/version'
+require 'poto/api'
+require 'poto/image_proxy'
+require 'poto/app'
 
 module Poto; end

lib/poto/api.rb

@@ -1,13 +1,13 @@
-require "base64"
-require "grape"
-require "grape/roar"
-require "poto/file_repository/proxy"
-require "poto/representers/file_representer"
-require "poto/representers/file_collection_representer"
+require 'base64'
+require 'grape'
+require 'grape/roar'
+require 'poto/file_repository/proxy'
+require 'poto/representers/file_representer'
+require 'poto/representers/file_collection_representer'
 
 module Poto
   class API < Grape::API
-    content_type :json, "application/hal+json"
+    content_type :json, 'application/hal+json'
     format       :json
     formatter    :json, Grape::Formatter::Roar
 
@@ -30,10 +30,10 @@ def url_for(opts, path, query = {})
         URI::Generic.build(
           host:   request.host,
           port:   request.port,
-          path:   File.join(opts[:env]["SCRIPT_NAME"], path),
+          path:   File.join(opts[:env]['SCRIPT_NAME'], path),
           query:  query.to_param,
           scheme: request.scheme
-        ).to_s.gsub(/\?$/, "")
+        ).to_s.gsub(/\?$/, '')
       end
 
       def id

lib/poto/app.rb

@@ -1,11 +1,11 @@
-require "sinatra"
+require 'sinatra'
 
 module Poto
   class App < Sinatra::Base
-    set :public_folder, File.join(File.dirname(__FILE__), "..", "..", "public")
+    set :public_folder, File.join(File.dirname(__FILE__), '..', '..', 'public')
 
-    get("/") do
-      File.read(File.join("public", "index.html"))
+    get('/') do
+      File.read(File.join('public', 'index.html'))
     end
   end
 end

lib/poto/ext/open_uri.rb

@@ -1,5 +1,7 @@
 module OpenURI
   class << self
-    def redirectable?(*); true; end
+    def redirectable?(*)
+      true
+    end
   end
 end

lib/poto/file_repository/aws/s3.rb

@@ -1,6 +1,6 @@
-require "base64"
-require "poto/file_repository/aws/s3/client"
-require "poto/file_repository/aws/s3/file_collection_mapper"
+require 'base64'
+require 'poto/file_repository/aws/s3/client'
+require 'poto/file_repository/aws/s3/file_collection_mapper'
 
 module Poto
   module FileRepository
@@ -21,7 +21,7 @@ def all(prefix:, page:, per_page:)
           objects = client.objects(
             page:     page,
             per_page: per_page,
-            prefix:   prefix,
+            prefix:   prefix
           )
 
           FileCollectionMapper.new(objects).call

lib/poto/file_repository/aws/s3/client.rb

@@ -1,4 +1,4 @@
-require "aws-sdk"
+require 'aws-sdk'
 
 module Poto
   module FileRepository
@@ -16,7 +16,7 @@ def objects(prefix:, page:, per_page:)
               bucket:   bucket,
               marker:   page,
               max_keys: per_page,
-              prefix:   prefix,
+              prefix:   prefix
             )
           end
 

lib/poto/file_repository/aws/s3/file_collection_mapper.rb

@@ -1,5 +1,5 @@
-require "poto/file_repository/aws/s3/file_mapper"
-require "poto/file_repository/file_collection"
+require 'poto/file_repository/aws/s3/file_mapper'
+require 'poto/file_repository/file_collection'
 
 module Poto
   module FileRepository

lib/poto/file_repository/aws/s3/file_mapper.rb

@@ -1,6 +1,6 @@
-require "base64"
+require 'base64'
 
-require "poto/file_repository/file"
+require 'poto/file_repository/file'
 
 module Poto
   module FileRepository

lib/poto/file_repository/file.rb

@@ -1,5 +1,5 @@
 module Poto
   module FileRepository
-    File = Struct.new("File", :id, :name, :size)
+    File = Struct.new('File', :id, :name, :size)
   end
 end

lib/poto/file_repository/file_collection.rb

@@ -1,5 +1,5 @@
 module Poto
   module FileRepository
-    FileCollection = Struct.new("FileCollection", :files, :page, :next_page)
+    FileCollection = Struct.new('FileCollection', :files, :page, :next_page)
   end
 end

lib/poto/file_repository/google/cloud/storage.rb

@@ -1,7 +1,7 @@
-require "base64"
-require "google/cloud/storage"
+require 'base64'
+require 'google/cloud/storage'
 
-require "poto/file_repository/google/cloud/storage/file_collection_mapper"
+require 'poto/file_repository/google/cloud/storage/file_collection_mapper'
 
 module Poto
   module FileRepository

lib/poto/file_repository/google/cloud/storage/file_collection_mapper.rb

@@ -1,7 +1,7 @@
-require "base64"
+require 'base64'
 
-require "poto/file_repository/file_collection"
-require "poto/file_repository/google/cloud/storage/file_mapper"
+require 'poto/file_repository/file_collection'
+require 'poto/file_repository/google/cloud/storage/file_mapper'
 
 module Poto
   module FileRepository

lib/poto/file_repository/google/cloud/storage/file_mapper.rb

@@ -1,6 +1,6 @@
-require "base64"
+require 'base64'
 
-require "poto/file_repository/file"
+require 'poto/file_repository/file'
 
 module Poto
   module FileRepository

lib/poto/file_repository/proxy.rb

@@ -1,4 +1,4 @@
-require "poto/file_repository/dsl"
+require 'poto/file_repository/dsl'
 
 module Poto
   module FileRepository

lib/poto/image_proxy.rb

@@ -1,25 +1,25 @@
-require "sinatra"
-require "tmpdir"
+require 'sinatra'
+require 'tmpdir'
 
-require "poto/services/download"
-require "poto/services/file_cache"
-require "poto/services/resize"
+require 'poto/services/download'
+require 'poto/services/file_cache'
+require 'poto/services/resize'
 
 module Poto
   class ImageProxy < Sinatra::Base
     set :cache_path, Dir.tmpdir
 
     helpers do
       def src
-        URI(params["src"].gsub(/\A\/\//, "http://"))
+        URI(params['src'].gsub(%r{\A\/\/}, 'http://'))
       end
 
       def width
-        params["width"].to_i
+        params['width'].to_i
       end
 
       def height
-        params["height"].to_i
+        params['height'].to_i
       end
 
       def cache(key, &set)
@@ -35,7 +35,7 @@ def resize(path, height, width)
       end
     end
 
-    get("/") do
+    get('/') do
       src_path = cache(src.path)                        { download(src) }
       dst_path = cache("#{src_path}#{width}x#{height}") { resize(src_path, height, width) }