Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding pr template, yaml lint, gitignore #43

Conversation

jeshernandez
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@jeshernandez
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented Jan 6, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jeshernandez
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jeshernandez
Copy link
Contributor Author

jeshernandez commented Jan 6, 2025

Okay, so I guess two things. (reviewing this: https://github.com/contributor-assistant/github-action?tab=readme-ov-file )

  1. You can't sign too soon (aka add the comment before the runner executes the action).
  2. Now, a rule visolation error is happening related to updating the json file https://github.com/jamespilgrim/PiTrac/actions/runs/12637411892/job/35211538806
    Screenshot 2025-01-06 at 10 31 14 AM

@jeshernandez
Copy link
Contributor Author

We can try deleting the JSON file and having the bot re-create it. It says if it was manually created, it may fail. That may not have been the case, but could be a workaround?

@jamespilgrim jamespilgrim merged commit 78515ae into jamespilgrim:main Jan 6, 2025
1 check failed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
@jamespilgrim
Copy link
Owner

Sorry for the thrash, Jesse. It seemed like the protected list was wrong and you fixed it - is that right? Is there something I need to do other than just merging and committing your pull request (which I did)? My inexperience with github is probably showing here.... :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants