Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS build crashes on tapping on Chat again after closing Chat window #3355

Closed
ann0see opened this issue Aug 24, 2024 · 2 comments · Fixed by #3413
Closed

iOS build crashes on tapping on Chat again after closing Chat window #3355

ann0see opened this issue Aug 24, 2024 · 2 comments · Fixed by #3413
Labels
bug Something isn't working

Comments

@ann0see
Copy link
Member

ann0see commented Aug 24, 2024

Describe the bug

Building Jamulus for iOS on Qt6 with setWindowState ( Qt::WindowMaximized ); set in the constructor of CChatDlg provides a "close" button and a somewhat usable UI for the chat window.
However, after closing the window and then tapping on the Chat button on the main window again crashes the app with a NULL pointer dereference (?)
ASSERT failure in QCoreApplication::sendEvent: "Unexpected null receiver", file /Users/qt/work/qt/qtbase/src/corelib/kernel/qcoreapplication.cpp, line 1577
To Reproduce

  • Build Jamulus with Qt6 for iOS,
  • Open the app
  • Tap on Chat
  • Close chat by tapping on the close button
  • Tap on Chat again and observe the app crash

Expected behavior
Tapping on Chat again doesn't crash the application.

Screenshots

Operating system
iOS 17

Version of Jamulus

3.10.0dev-58000016
Additional context
I believe that we leak a pointer somewhere/don't recreate it. By calling close() it gets deallocated and then we get a null pointer somewhere.

@ann0see ann0see added the bug Something isn't working label Aug 24, 2024
@github-project-automation github-project-automation bot moved this to Triage in Tracking Aug 24, 2024
@ann0see
Copy link
Member Author

ann0see commented Aug 24, 2024

I believe this doesn't occur with Qt5 - but I can't reliably test this.

@ann0see ann0see closed this as completed Dec 23, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Tracking Dec 23, 2024
@ann0see ann0see added this to the Release 3.12.0 milestone Dec 23, 2024
@ann0see
Copy link
Member Author

ann0see commented Dec 23, 2024

Fixed by #3413

@ann0see ann0see linked a pull request Dec 23, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant