Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS build using macos-12 runner now fails #3433

Closed
softins opened this issue Dec 5, 2024 · 7 comments · Fixed by #3445
Closed

iOS build using macos-12 runner now fails #3433

softins opened this issue Dec 5, 2024 · 7 comments · Fixed by #3445
Labels
tooling Changes to the automated build system

Comments

@softins
Copy link
Member

softins commented Dec 5, 2024

Github have now discontinued support for the macos-12 runner, so we need to move those builds to at least macos-13.

Just raising this issue to give it visibility.

@softins softins added the tooling Changes to the automated build system label Dec 5, 2024
@ann0see
Copy link
Member

ann0see commented Dec 5, 2024

Time to update the iOS build to Qt6 then.
Not sure about macOS legacy.

@softins
Copy link
Member Author

softins commented Dec 6, 2024

#3436 fixes the build for MacOS Legacy.

I tried the same fix for iOS, but the build failed for other reasons, which I have not yet understood.

@softins softins changed the title Mac legacy and iOS builds using macos-12 runner now fail iOS build using macos-12 runner now fails Dec 9, 2024
@softins
Copy link
Member Author

softins commented Dec 9, 2024

Now that the macOS Legacy build has been successfully moved to the macos-13 runner, have updated the issue title to just refer to iOS.

Don't yet know what the right solution is for iOS. Needed also to change the SDK version from 13 to 14, and the build no longer succeeded.

@ann0see
Copy link
Member

ann0see commented Dec 9, 2024

Updating to Qt6, I suppose.
Otherwise building Qt 5.15 from source.

There are still some open PRs and issues with the Qt6 build.

@softins
Copy link
Member Author

softins commented Dec 10, 2024

See also #3293 and the comments there about the need to move from the "legacy build system" to the "modern build system" when using SDK 14.

@pljones pljones added this to Tracking Dec 18, 2024
@github-project-automation github-project-automation bot moved this to Triage in Tracking Dec 18, 2024
@pljones pljones added this to the Release 3.12.0 milestone Dec 18, 2024
@pljones pljones moved this from Triage to Backlog in Tracking Dec 18, 2024
@ann0see ann0see moved this from Backlog to Waiting on Team in Tracking Dec 18, 2024
@ann0see ann0see moved this from Waiting on Team to Backlog in Tracking Dec 18, 2024
@ann0see
Copy link
Member

ann0see commented Dec 20, 2024

I've tried to compile Jamulus locally on macOS with the 18.2 SDK and it fails with a linker error related to ffmpeg. (Will try to debug it further and then open an issue) I do not remember that we use ffmpeg anywhere.

The qtmultimedia plugin might pull it in.

@ann0see ann0see mentioned this issue Dec 23, 2024
5 tasks
@ann0see ann0see linked a pull request Dec 23, 2024 that will close this issue
5 tasks
@ann0see
Copy link
Member

ann0see commented Dec 23, 2024

I'd go proceed as follows:

  • Upgrade main to Qt6
  • Afterwards debug further UI issues
  • The problem is that the CI breaks otherwise.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Tracking Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Changes to the automated build system
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants