Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nl web translation for 3.11.0 #1015

Closed
ann0see opened this issue Aug 4, 2024 · 8 comments · Fixed by #1019
Closed

Update nl web translation for 3.11.0 #1015

ann0see opened this issue Aug 4, 2024 · 8 comments · Fixed by #1019
Assignees
Labels
translation Issue or PR releated to translation

Comments

@ann0see
Copy link
Member

ann0see commented Aug 4, 2024

Hi @henkdegroot,

We are getting ready for the 3.11.0 release and have created the next-release branch (full diff).

We would be happy if you updated the translations for nl by 2024-08-21.

Please either update the translations on Hosted Weblate, or use Git:

  • Start your work in your fork on a branch based on jamuluswebsite's next-release branch.
  • Update the language-specific files using your favourite editor (or directly on GitHub),
  • New/changed images are listed at the end of this issue. Generate new URLs for your image .inc files.
  • Commit and push your changes to your fork,
  • Open a Pull Request with your translations to the next-release branch with the subject Update nl web translation for 3.11.0,
  • Link your PR(s) to this issue by including Fixes #1015 in the PR content.

Suggested commit and PR message:

Update nl web translation for 3.11.0

Fixes #1015

Feel free to use this Issue to discuss anything you need prior to making any PR (and in your native language if needed).

Further documentation can be found in TRANSLATING.md.

Thanks for contributing to Jamulus!


New/Changed screenshots:

Please replace with new URLs for your screenshots here, and use those URLs in your .inc files.

settings-profile

server-window-setup

server-window-options

@ann0see ann0see added the translation Issue or PR releated to translation label Aug 4, 2024
@ann0see ann0see added this to the Release 3.11.0 milestone Aug 4, 2024
@ann0see ann0see added this to Tracking Aug 4, 2024
@github-project-automation github-project-automation bot moved this to Triage in Tracking Aug 4, 2024
@ann0see
Copy link
Member Author

ann0see commented Aug 4, 2024

Screenshot update as for the screenshots in: #1002

@henkdegroot
Copy link
Contributor

@ann0see seems the screenshots in this PR are not the images to update. Am I correct? And only need screenshots as referenced in #1002?

Just want to prevent I am going doing something not needed (did not look at the translations for the website yet)

@ann0see
Copy link
Member Author

ann0see commented Aug 5, 2024

Yes. Check #1002

@henkdegroot
Copy link
Contributor

New images for the website:

Connect-dialog_nl

Advanced-settings_nl

@henkdegroot
Copy link
Contributor

@pljones I have used the same logic/url reference aa was for ES images. Believe git is converting the url used in the inc file to a temp url with additional security access. Not sure if that will be generating the same reference each time or not. GitHub seems to have changed the logic for the url.

Happy to use either, but thought it would be best to be consistent.

@pljones
Copy link
Contributor

pljones commented Aug 7, 2024

Sorry, ignore my (now deleted comment) -- somehow I got my references confused here whilst checking things.

I couldn't get these to update the first time:
http://jamuluswebsite.drealm.info/nl/wiki/Software-Manual#verbindenafmelden-knop
http://jamuluswebsite.drealm.info/nl/wiki/Software-Manual#geavanceerde-instellingen
Looks okay now.

@henkdegroot
Copy link
Contributor

henkdegroot commented Aug 7, 2024

@pljones, no worries. Think the doc detailing how to embed images could be updated to ensure the desired link is used as the naming has slightly changed.

@henkdegroot
Copy link
Contributor

Updated the translation using Weblate, however seems the NL update is not appearing in the weblate PR.

@pljones pljones linked a pull request Aug 31, 2024 that will close this issue
@ann0see ann0see closed this as completed Sep 1, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Tracking Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Issue or PR releated to translation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants