Connect to dev server

[Tweekism]

Hey Peeps,

Another day another dumb question... So I was previously doing this fine, I'm not sure what has happened.

I run yarn dev then yarn viv README.md it says its going to connect on port 3000 but them it doesn't, the browser pops up connected to 31622.

What incredibly obviously thing am i doing wrong today? Lol.

[jannis-baum]

Strange! I assume you are on the latest commit on main and have run yarn?

I can't reproduce this but one thing that strikes out from the screenshots is that your development server has actually stopped for whatever reason (Note "clean exit - waiting for changes before restarting" from nodemon). But even then running yarn viv README.md should still start a development server on port 3000 and open the file there. So not sure what's going on to be honest.

I would suggest investigating why the server might have stopped (maybe you killed it trying to kill the non-development server?) and if that doesn't lead anywhere printing the address in src/app.ts and checking where it points.

[Tweekism]

Hey @jannis-baum

Ok peeps are calling on me to go play warzone with them lol. However I think I found the issue and I think it's a bug. Remember I'm completely new to javascript / typescript, so go easy on me lol 😅

Is there a way on GitHub to reference lines of code in a comment?

Anyway in parser/config.ts on line 60 there is an if statement first added in commit 07296ea (tag: bug) feat(#90): improve conf retrieval. Which is:-

if (config === undefined) return defaultConfig;

Meaning if you don't have a config at ~/.vivify.json or ~/.vivify/config.json (mine is currently renamed to .vivify.json.off) then the function returns and never gets to the section that overrides with the environment variables starting on line 73

    // environment overrides
    for (const [env, key] of envConfigs) {
        if (process.env[env]) config[key] = process.env[env];
    }
    return config;

Are you able to replicate if by renaming / moving your vivify config temporarily and then running the yarn dev thing?

[jannis-baum]

Ah, yes, good spot! That's it. I will fix it ^^ Thanks a lot for finding that!

[jannis-baum]

Fixed in #128!

[Tweekism]

I may not know how to code, but I can cook up a mad git bisect...

[jannis-baum]

Hahaha🔥

Since this was a potentially quite annoying bug I made a new minor release: https://github.com/jannis-baum/Vivify/releases/tag/v0.2.1

[tuurep]

Wanna see something funny? I'm trying to debug why some neovim operators are misbehaving

So this slipped in my configs:

Bagbiwum, what a name 😄

[Tweekism]

How did that get in there?

[tuurep]

Using init.lua as a test buffer for https://github.com/echasnovski/mini.operators